New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596043 link

Starred by 3 users
Status: Fixed
Owner:
█ shanmug...@samsung.com
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 225863



Sign in to add a comment

[svg2] Move path interrogation functions to SVGGeometryElement

Project Member Reported by f...@opera.com, Mar 18 2016 
https://www.w3.org/2016/03/17-svg-minutes.html#item03

RESOLUTION: Make the getTotalLength() and getPointAtLength(distance) methods, currently defined on the SVGPathElement interface, available for all elements that implement the SVGGeometryElement interface. The length calculation would be based on the equivalent path for each shape.

RESOLUTION: Make the pathLength attribute and IDL property available on all elements that implement the SVGGeometryElement interface.

Comment 2 by shanmug...@samsung.com, Oct 6 2016

Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/887bbf6c0edcabfa012099379c2d68a3dc4afd3f

commit 887bbf6c0edcabfa012099379c2d68a3dc4afd3f
Author: shanmuga.m <shanmuga.m@samsung.com>
Date: Thu Oct 27 10:25:20 2016

Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement.

spec:
https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

BUG= 596043 

Review-Url: https://codereview.chromium.org/2413753004
Cr-Commit-Position: refs/heads/master@{#427992}

[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt
[add] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-attached.html
[add] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html
[add] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getTotalLength-attached.html
[add] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getTotalLength-detached.html
[add] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-valid-arguments.html
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/path-pointAtLength-expected.txt
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/path-pointAtLength.html
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/path-totalLength-expected.txt
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/path-totalLength.html
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/script-tests/path-pointAtLength.js
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dom/script-tests/path-totalLength.js
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGPathElement-valid-arguments-expected.txt
[delete] https://crrev.com/6539870a0bbb33b28a1b56c85124874eb22c9e68/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGPathElement-valid-arguments.html
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/Source/core/svg/SVGGeometryElement.h
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/Source/core/svg/SVGPathElement.h
[modify] https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f/third_party/WebKit/Source/core/svg/SVGPathElement.idl
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6

commit 6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6
Author: shanmuga.m <shanmuga.m@samsung.com>
Date: Wed Nov 30 09:11:37 2016

Move pathLength attribute from SVGPathElement to SVGGeometryElement.

spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

BUG= 596043 

Review-Url: https://codereview.chromium.org/2525233002
Cr-Commit-Position: refs/heads/master@{#435194}

[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/svg/stroke/pathlength-with-geometry-element-expected.html
[add] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/svg/stroke/pathlength-with-geometry-element.html
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGGeometryElement.h
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGPathElement.h
[modify] https://crrev.com/6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6/third_party/WebKit/Source/core/svg/SVGPathElement.idl

Comment 5 by dtapu...@chromium.org, Dec 6 2016

Components: Blink>SVG

Comment 6 by f...@opera.com, Dec 15 2016

Status: Fixed (was: Assigned)
Looks like all expected changes have landed.
►

Sign in to add a comment