"WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest" is flaky |
||||||||||||
Issue description"WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNXaWRnZXRUZXN0LkRlc2t0b3BOYXRpdmVXaWRnZXROb1BhaW50QWZ0ZXJDbG9zZVRlc3QM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 18 2016
I'll disable the test for now.
,
Mar 18 2016
Patch in flight: https://codereview.chromium.org/1810213006/. Sky, please help with an owner?
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf8c1b168b318343b64d8cf465a1520fefdbb745 commit bf8c1b168b318343b64d8cf465a1520fefdbb745 Author: phoglund <phoglund@chromium.org> Date: Fri Mar 18 15:00:41 2016 Disabling flaky DesktopNativeWidgetNoPaintAfterCloseTest BUG= 596039 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/1810213006 Cr-Commit-Position: refs/heads/master@{#381968} [modify] https://crrev.com/bf8c1b168b318343b64d8cf465a1520fefdbb745/ui/views/widget/widget_unittest.cc
,
Mar 18 2016
,
Mar 18 2016
Looks like tapted@ is the right owner (from 595179)
,
Mar 18 2016
This is mojo specific. Two interesting backtraces: #0 0x000000cb404b base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7f95bfe4acb0 <unknown> #2 0x7f95bfab30d5 gsignal #3 0x7f95bfab683b abort #4 0x7f95bd135cc2 base::debug::BreakDebugger() #5 0x7f95bd13d02a logging::LogMessage::~LogMessage() #6 0x7f95bcc12d1c mojo::internal::SharedData<>::Holder::Release() #7 0x7f95bd0c7147 _ZN4base8internal9BindStateINS0_15RunnableAdapterIPFvRKN4mojo8CallbackIFvNS3_9StructPtrIN3mus5mojom29CommandBufferInitializeResultEEEEEES9_EEESE_JSD_EE7DestroyEPNS0_13BindStateBaseE #8 0x7f95bd0c7262 _ZNSt11_Tuple_implILm1EJN4base8internal13PassedWrapperIN4mojo12InterfacePtrIN3mus5mojom19CommandBufferClientEEEEENS2_INS3_16ScopedHandleBaseINS3_18SharedBufferHandleEEEEENS2_INS3_5ArrayIiEEEENS0_8CallbackIFvNS3_9StructPtrINS6_29CommandBufferInitializeResultEEEELNS1_8CopyModeE1EEEEED2Ev #9 0x7f95bd0c71c2 _ZN4base8internal9BindStateINS0_15RunnableAdapterIMN3mus17CommandBufferImplEFvN4mojo12InterfacePtrINS3_5mojom19CommandBufferClientEEENS5_16ScopedHandleBaseINS5_18SharedBufferHandleEEENS5_5ArrayIiEERKNS_8CallbackIFvNS5_9StructPtrINS7_29CommandBufferInitializeResultEEEELNS0_8CopyModeE1EEEEEEFvPS4_S9_SC_SE_SN_EJNS0_17UnretainedWrapperIS4_EENS0_13PassedWrapperIS9_EENSV_ISC_EENSV_ISE_EESL_EE7DestroyEPNS0_13BindStateBaseE #10 0x7f95bd14f0bd base::PendingTask::~PendingTask() #11 0x7f95bd142471 base::MessageLoop::DoWork() #12 0x7f95bd143b5f base::MessagePumpDefault::Run() #13 0x7f95bd141a6c base::MessageLoop::RunHandler() #14 0x7f95bd1505bc base::RunLoop::Run() #15 0x7f95bd141490 base::MessageLoop::Run() #16 0x7f95bd160043 base::Thread::ThreadMain() #17 0x7f95bd15f55d base::(anonymous namespace)::ThreadFunc() #18 0x7f95bfe42e9a start_thread #19 0x7f95bfb7038d clone r8: 00007f95bb9a99b0 r9: 00007f95bfbc5280 r10: 0000000000000008 r11: 0000000000000202 r12: 00002dd4a4ded3e8 r13: 00007f95bb9aa190 r14: 00007f95bb9a9df8 r15: 00007f95bb9a9de8 di: 0000000000007670 si: 00000000000076ad bp: 00007f95bb9aa178 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007f95bb9a9848 ip: 00007f95bfab30d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] [29640:29640:0318/040318:1402503556:FATAL:compositor.cc(441)] Check failed: false. #0 0x000000cb44ae base::debug::StackTrace::StackTrace() #1 0x000000cbe19b logging::LogMessage::~LogMessage() #2 0x000000c3b1d5 ui::Compositor::DidFailToInitializeOutputSurface() #3 0x00000056d215 cc::LayerTreeHost::DidFailToInitializeOutputSurface() #4 0x00000059bea0 cc::SingleThreadProxy::SetOutputSurface() #5 0x00000056cc5d cc::LayerTreeHost::SetOutputSurface() #6 0x000000c3aa06 ui::Compositor::SetOutputSurface() #7 0x000000485dcd views::SurfaceContextFactory::CreateOutputSurface() #8 0x000000c3b151 ui::Compositor::RequestNewOutputSurface() #9 0x00000059bb8a cc::SingleThreadProxy::RequestNewOutputSurface() #10 0x00000047fa7c _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN5views15NativeWidgetMusEFvvEEEFvPS7_EJNS_7WeakPtrIS7_EEEEENS0_12InvokeHelperILb1EvSA_EEFvvEE3RunEPNS0_13BindStateBaseE #11 0x00000047fa7c _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN5views15NativeWidgetMusEFvvEEEFvPS7_EJNS_7WeakPtrIS7_EEEEENS0_12InvokeHelperILb1EvSA_EEFvvEE3RunEPNS0_13BindStateBaseE #12 0x000000d0581c base::debug::TaskAnnotator::RunTask() #13 0x000000cc2c4b base::MessageLoop::RunTask() #14 0x000000cc2f48 base::MessageLoop::DeferOrRunPendingTask() #15 0x000000cc30fb base::MessageLoop::DoWork() #16 0x000000cc4e59 base::MessagePumpGlib::Run() #17 0x000000cc279c base::MessageLoop::RunHandler() #18 0x000000cd2aac base::RunLoop::Run() #19 0x0000009021da views::ViewsTestBase::RunPendingMessages() #20 0x000000454d83 views::test::WidgetTest_DesktopNativeWidgetNoPaintAfterCloseTest_Test::TestBody() #21 0x000000d12f47 testing::Test::Run() #22 0x000000d13a1a testing::TestInfo::Run() #23 0x000000d13ea3 testing::TestCase::Run() #24 0x000000d1ad69 testing::internal::UnitTestImpl::RunAllTests() #25 0x000000d1aa0e testing::UnitTest::Run() #26 0x00000048c671 base::TestSuite::Run() #27 0x00000049917f base::(anonymous namespace)::LaunchUnitTestsInternal() #28 0x000000499044 base::LaunchUnitTests() #29 0x000000437d90 views::RunAllUnittests() #30 0x7f072d6bc76d __libc_start_main #31 0x000000437c39 <unknown> Fady or Rob, any ideas?
,
Mar 19 2016
Detected 4 new flakes for test/step "WidgetTest.DesktopNativeWidgetNoPaintAfterHideTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJXaWRnZXRUZXN0LkRlc2t0b3BOYXRpdmVXaWRnZXROb1BhaW50QWZ0ZXJIaWRlVGVzdAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Mar 21 2016
Disabling the test in the meantime.
,
Mar 21 2016
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe798ace4947a979b13dd4da463ece27ccfde840 commit fe798ace4947a979b13dd4da463ece27ccfde840 Author: phoglund <phoglund@chromium.org> Date: Mon Mar 21 09:36:09 2016 Disabling flaky DesktopNativeWidgetNoPaintAfterHideTest TBR=tapted@chromium.org BUG= 596039 Review URL: https://codereview.chromium.org/1817973002 Cr-Commit-Position: refs/heads/master@{#382260} [modify] https://crrev.com/fe798ace4947a979b13dd4da463ece27ccfde840/ui/views/widget/widget_unittest.cc
,
Mar 24 2016
These tests also fail consistently on the 'Chromium Mojo Windows' FYI bot: https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest WidgetTest.DesktopNativeWidgetNoPaintAfterHideTest Can you fix/disable these on Windows too?
,
May 31 2016
Detected 3 new flakes for test/step "WidgetTest.DesktopNativeWidgetNoPaintAfterHideTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJXaWRnZXRUZXN0LkRlc2t0b3BOYXRpdmVXaWRnZXROb1BhaW50QWZ0ZXJIaWRlVGVzdAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jun 1 2016
Disabling the test on Windows as well. fsamuel, please look into this or reassign to a better owner.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc1e8ff3f07c8bc2d2e109078479cbc82f148280 commit fc1e8ff3f07c8bc2d2e109078479cbc82f148280 Author: pkasting <pkasting@chromium.org> Date: Wed Jun 01 12:05:32 2016 Disable flaky test on Windows as well. BUG= 596039 TEST=none TBR=guidou Review-Url: https://codereview.chromium.org/2028953003 Cr-Commit-Position: refs/heads/master@{#397108} [modify] https://crrev.com/fc1e8ff3f07c8bc2d2e109078479cbc82f148280/ui/views/widget/widget_unittest.cc
,
Jun 1 2016
Detected 3 new flakes for test/step "WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNXaWRnZXRUZXN0LkRlc2t0b3BOYXRpdmVXaWRnZXROb1BhaW50QWZ0ZXJDbG9zZVRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jun 1 2016
,
Jun 1 2016
Disabled DesktopNativeWidgetNoPaintAfterCloseTest on Windows.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b1a3a0cef7431736a887d488be7cb9aa4c40a13 commit 2b1a3a0cef7431736a887d488be7cb9aa4c40a13 Author: guidou <guidou@chromium.org> Date: Wed Jun 01 16:53:06 2016 Disable flaky WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest on Windows. BUG= 596039 TBR=pkasting Review-Url: https://codereview.chromium.org/2032463004 Cr-Commit-Position: refs/heads/master@{#397162} [modify] https://crrev.com/2b1a3a0cef7431736a887d488be7cb9aa4c40a13/ui/views/widget/widget_unittest.cc
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3845af20c5138df223fd0fba3eb5a275aacea6b8 commit 3845af20c5138df223fd0fba3eb5a275aacea6b8 Author: sadrul <sadrul@chromium.org> Date: Wed Jun 01 19:30:08 2016 views: Fix a couple of flaky tests on windows/linux, disable them on mus. We can no longer expect a single cycle of message-loop iteration to paint a widget, since painting is now driven by BeginFrameSource. So update the tests to wait for the painting to happen first. These tests create desktop-widgets, which we do not support in mus, so disable the tests in mus. BUG= 596039 Review-Url: https://codereview.chromium.org/2032573002 Cr-Commit-Position: refs/heads/master@{#397206} [modify] https://crrev.com/3845af20c5138df223fd0fba3eb5a275aacea6b8/ui/views/widget/widget_unittest.cc
,
Jun 7 2016
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by phoglund@chromium.org
, Mar 18 2016