New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596033 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Apr 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
sgabr...@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [MD] Different colors of focus ring is seen on 'installed theme' info bar.

Reported by rk...@etouch.net, Mar 18 2016 
Chrome Version: 51.0.2682.0 Revision 153a9028e5cb73e3c707b4884550499e2a08af5c-refs/heads/master@{#381839}(32/64 bit)
OS: Windows(Win-7 Aero Enabled)

URL: https://chrome.google.com/webstore/detail/wolf-and-the-ice-planet/gffkhmkbijdmbncaoclaclldnbndflck?hl=en

Precondition: Enable 'Material design in the browser's top chrome' by selecting 'Material' option.

What steps will reproduce the problem?
(1) Launch chrome,navigate to above url and click on 'ADD TO CHROME'(Installed theme info bar appeared ).
(2) Press Tab key on info bar and observe.

Different colors of focus ring is seen on info bar i.e. For 'UNDO' option is shown blue focus ring and for 'Close icon' is shown white focus ring.

Same color of focus ring should be seen on info bar.

This is a regression issue,broken in 'M-51', Manual regression range:

Good Build: 51.0.2680.0
Bad Build: 51.0.2681.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/d9e2244521e29edad88f9fbdd6dc90affcd1c1b6..36fc372117d5c40162dc014aaba4bbb7e3d5779a?pretty=fuller&n=10

Suspecting: r381377
Actual_Focus.mp4
984 KB Download
Expected_Focus.mp4
481 KB Download

Comment 1 by ranjitkan@chromium.org, Mar 18 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 2 by est...@chromium.org, Mar 18 2016 

please post screenshots, not videos

Comment 3 by rk...@etouch.net, Mar 21 2016 

With respect to comment 2:

Kindly refer the attached screenshot for the different color of focus ring.
Screenshot.png
24.9 KB View Download

Comment 4 by est...@chromium.org, Mar 21 2016

Cc: sgabr...@chromium.org
+sgabriel -- what is the focus ring supposed to look like on the close button?

Comment 5 by est...@chromium.org, Mar 21 2016

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2

Comment 6 by sgabr...@chromium.org, Mar 21 2016 

Can we apply the same treatment as the buttons ?

Comment 7 by est...@chromium.org, Mar 21 2016 

sure. What dimensions?

Comment 8 by sgabr...@chromium.org, Mar 21 2016 

similarly to the buttons, it's width and height + 1pt padding + 1pt border. See attached for a preview.
close-selected.png
14.0 KB View Download

Comment 9 by sgabr...@chromium.org, Mar 21 2016 

I attached some measure. 
Based on the 24px hover state, you have a 28x28px selected inner border of 2px.

Rounded corners of the stroke should be 4px.
measures.png
11.2 KB View Download

Comment 10 by tdander...@chromium.org, Mar 22 2016

Components: -UI>Browser>Themes UI>Browser>Infobars
Labels: OS-Chrome
Note this is also seen on Chrome OS. Use Ctrl+F2 (Ctrl + forward arrow on a CrOS keyboard layout) to cycle focus into the infobar, then use arrow keys to move focus ring between the infobar's undo and close buttons.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9

commit ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9
Author: estade <estade@chromium.org>
Date: Wed Mar 23 01:22:52 2016

[MD] Use same focus ring on BarControlButton as MdTextButton.

BUG= 596033 

Review URL: https://codereview.chromium.org/1817253003

Cr-Commit-Position: refs/heads/master@{#382759}

[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/chrome/browser/ui/views/bar_control_button.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/custom_button.h
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/ee3ec60a1260a0c72edaae3a4b72c90bae93a2d9/ui/views/controls/button/md_text_button.h

Comment 12 by est...@chromium.org, Apr 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment