New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596011 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Mar 2016
Cc:
yukishiino@chromium.org
█ hlopko@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Push ScriptWrappable inheritance down to subclasses in the SVGAnimatedProperty class hierarchy

Project Member Reported by f...@opera.com, Mar 18 2016 
The ScriptWrappable interface is currently inherited by the baseclass SVGAnimatedPropertyBase, but not all subclasses need the functionality that it provides (SVGAnimatedPath, SVGAnimatedPoints, ...)

Try to push the ScriptWrappable inheritance down into the subclasses that are actually wrapped by V8 objects.

Comment 1 by f...@opera.com, Mar 18 2016

Components: Blink>SVG

Comment 2 by yukishiino@chromium.org, Mar 18 2016

Cc: yukishiino@chromium.org
Components: Blink>Bindings

Comment 3 by hlopko@chromium.org, Mar 18 2016

Cc: hlopko@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c

commit adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c
Author: fs <fs@opera.com>
Date: Mon Mar 21 10:51:17 2016

Push ScriptWrappable inheritance down from SVGAnimatedPropertyBase

Rather than letting the base inherit and then override for actually
wrappable subclasses, put the inheritance in the subclasses.
This avoids having "dead" ScriptWrappables on subclasses that don't need
this functionality.
Since this removes the last user of the DEFINE_WRAPPERTYPEINFO_NOT_REACHED
macro, remove that too.

BUG= 596011 

Review URL: https://codereview.chromium.org/1807333003

Cr-Commit-Position: refs/heads/master@{#382265}

[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedAngle.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedInteger.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedLengthList.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedNumber.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedRect.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedString.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.h
[modify] https://crrev.com/adc7b8b7f37f3135c0e5c464680f6e0bb98dfc1c/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

Comment 5 by f...@opera.com, Mar 21 2016

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment