New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596009 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Use GTK icons with material design mode

Reported by yanp...@gmail.com, Mar 18 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Steps to reproduce the problem:
There is a chrome experiment, which will be soon default in chrome, called #top-chrome-md. There is also option in settings, which allows you to use GTK theme or Native chrome Blue theme.

If you use GTK theme, icons on the top panel (Back, Forward, Reload and Home) are still material which looks eclectical and doesn't match your theme. Neither it is they look out of place on linux desktop, they might be invisible if you use DARK theme.

What is the expected behavior?

What went wrong?
Icons are non-gtk

Did this work before? N/A 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: 
Flash Version:
 

Comment 1 by meh...@chromium.org, Mar 18 2016

Cc: est...@chromium.org
Labels: Proj-MaterialDesign-NativeUI

Comment 2 by est...@chromium.org, Mar 18 2016

Status: Untriaged (was: Unconfirmed)
> Neither it is they look out of place on linux desktop, they might be invisible if you use DARK theme.

this is not true (unless you have a broken dark theme). They will be colorized appropriately.

Comment 3 by yanp...@gmail.com, Jun 14 2016

Now there is now way to set GTK icons from theme, even in chrome labs. Chrome looks out of place a bit
I migrated from google-chrome to chromium-browser specifically for Linux theme support, but it seems to have been removed again here too.

Here I've attached a screenshot from the chrome setting paqe showing the gtk+ theme being in used while sanctimoniously showing the new chrome icons in use, as well as a window with the system stock icons to show the contrast/mistake.
chromium-icons-and-system-icons.png
31.4 KB View Download
Yes, there was a change in behavior here. Philosophically, the GTK theme mode is a sort of crossbreed between your system theme and the Chrome default theme. For example, the tabstrip still looks like a Chrome tabstrip and not a GTK tabstrip. The buttons used to be taken from the GTK theme, but now are just colorized according to the GTK theme. Where the balance lies between what looks good, bad, Chromey or system-y is a matter of taste.

One problem with using the system buttons is that the sizing won't always work that well. I've seen configurations where the edges of the icons were cut off inside our buttons (the toolbar not  being resizable according to its fonts, contents, etc.) and I expect this would happen more frequently with the new, smaller buttons.

That said, if the overwhelming majority opinion was that we should be using GTK button icons, I wouldn't argue. However, if that were the overwhelming opinion I'd expect to have seen more activity on the bug tracker (on this bug or elsewhere) so I'm skeptical that's the case.

Comment 6 by yanp...@gmail.com, Jul 9 2016

GTK3 has symbolic icons which are SVGs inside. Their color is defined by theme. And their size can be reshaped anyhow. https://developer.gnome.org/hig/stable/icons-and-artwork.html.en

Comment 7 by est...@chromium.org, Jul 11 2016

Cc: knt...@gmail.com
Adding support for gtk3 symbolic icons might be nice.
Cc: bettes@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
+bettes@  On linux, should we use the icons that match the system theme (image in c#4)?  Or should we always use the MD icons?  Personally, I'm indifferent.

Comment 9 by est...@chromium.org, Nov 16 2017

My opinion is that we should continuing doing what we do today: use the MD icons, and color them according to the gtk theme.

I don't know if Alan has an opinion or not, but historically Linux UI decisions have been made by whoever's working on Linux.
Status: WontFix (was: Assigned)
That is a reasonable compromise, and I'd agree it's the best solution.  bettes@ please shout if you have a strong opinion otherwise

Sign in to add a comment