New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596003 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Weird font is seen over the bookmark bar.

Reported by dmascare...@etouch.net, Mar 18 2016

Issue description

Chrome Version:51.0.2682.0 (Official Build) 153a9028e5cb73e3c707b4884550499e2a08af5c-refs/heads/master@{#381839} (32/64-bit)
OS: Windows 8/ Windows 10

URL: https://chrome.google.com/webstore/detail/space-zastavkifreeru/hifhddjdplehpbndiikdofeaopbimfmi?utm_source=chrome-ntp-icon 

Precondition: Enable 'Material design in the browser's top chrome' flag from 'chrome://flags'.

What steps will reproduce the problem?
1) Launch chrome, go to above URL and add the theme.
2) Open Incognito window and observe the bookmark bar.

Actual: Weird font is seen over the bookmark bar.

Expected: Font should be proper.

This is a Regression issue broken in M-51 and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/b5022da0db55451ec2f7f77230a385ca0ff4bd81..450f77295c65afc4068dc8441ad4c91ff0b9947c?pretty=fuller&n=100

Suspecting: r381528

Manual bisect:
Good build: 51.0.2680.0
Bad build: 51.0.2681.0

Note: 1. Issue is not seen on Mac OS, Windows 7 and Linux OS.
      2. Above issue is theme specific issue.
 
Actual_blur.png
179 KB View Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 2 by est...@chromium.org, Mar 18 2016

Cc: pkasting@chromium.org
Labels: -ReleaseBlock-Stable -M-51 Proj-MaterialDesign-NativeUI
since this is windows specific and MD-specific, it's not (yet) targeted at m51.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30b95559fb5be38c99cffe3dc365a43594bc73a8

commit 30b95559fb5be38c99cffe3dc365a43594bc73a8
Author: estade <estade@chromium.org>
Date: Fri Mar 18 20:50:24 2016

[MD] Fix bookmark bar painting bugs.

This fixes the background color bug.

This may or may not fix the text rendering bug (but the text rendering bug
is not that important to fix promptly).

BUG= 595978 , 596003 

Review URL: https://codereview.chromium.org/1815743002

Cr-Commit-Position: refs/heads/master@{#382079}

[modify] https://crrev.com/30b95559fb5be38c99cffe3dc365a43594bc73a8/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c36752121a1aa0dda90b9800962319587995e763

commit c36752121a1aa0dda90b9800962319587995e763
Author: Evan Stade <estade@chromium.org>
Date: Mon Mar 21 21:59:51 2016

[MD] Fix bookmark bar painting bugs.

This fixes the background color bug.

This may or may not fix the text rendering bug (but the text rendering bug
is not that important to fix promptly).

BUG= 595978 , 596003 

Review URL: https://codereview.chromium.org/1815743002

Cr-Commit-Position: refs/heads/master@{#382079}
(cherry picked from commit 30b95559fb5be38c99cffe3dc365a43594bc73a8)

Review URL: https://codereview.chromium.org/1823623003 .

Cr-Commit-Position: refs/branch-heads/2661@{#329}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/c36752121a1aa0dda90b9800962319587995e763/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Tested the same on win8.1, win10 on chrome version 50.0.2661.48 - Font was not blurred but there is some painting issue resulting in grey shadows on the bookmark bar.

Please find the screenshot

estade@, Could you please confirm on the fix.
596003.png
4.8 MB View Download

Comment 7 by est...@chromium.org, Mar 22 2016

we don't care about MD on windows in m50. Can you test on tip of tree instead?
Labels: -Pri-1 M-51 Pri-2
Status: Fixed (was: Assigned)
remaining work is tracked in  bug 596370 

Sign in to add a comment