New issue
Advanced search Search tips

Issue 595985 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

v8.parseOnBackground trace events should be shown in DevTools Timeline.

Project Member Reported by horo@chromium.org, Mar 18 2016

Issue description

Asynchronously loaded JS files may be parsed on the SriptStreamerThread.
But currently DevTools Timeline doesn't show the parse events.
 

Comment 2 by horo@chromium.org, Mar 18 2016

Labels: -Type-Bug Type-Feature
Thanks for doing this horo. These events have been phantoms!
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23441ef2a1903a977eea7feef9160ef80cf19e8c

commit 23441ef2a1903a977eea7feef9160ef80cf19e8c
Author: horo <horo@chromium.org>
Date: Fri Mar 25 06:52:31 2016

Show v8.parseOnBackground in DevTools Timeline

BUG= 595985 

Review URL: https://codereview.chromium.org/1807193003

Cr-Commit-Position: refs/heads/master@{#383259}

[add] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/resources/timeline-script-parse.php
[add] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-script-parse-expected.txt
[add] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-script-parse.html
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js
[modify] https://crrev.com/23441ef2a1903a977eea7feef9160ef80cf19e8c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Comment 5 by horo@chromium.org, Mar 25 2016

Status: Fixed (was: Started)
Now we can see "Parse Script" in Timeline of DevTools.
Yey!
parse_script.png
122 KB View Download

Comment 6 by horo@chromium.org, Mar 28 2016

$ git find-releases  23441ef2a1903a977eea7feef9160ef80cf19e8c
commit 23441ef2a1903a977eea7feef9160ef80cf19e8c was:
  initially in 51.0.2691.0

Sign in to add a comment