Regression: Bookmark bar color does not change to default color on changing to default theme.
Reported by
vvishwak...@etouch.net,
Mar 18 2016
|
|||||||||||
Issue descriptionVersion: 51.0.2682.0 (Official Build) 153a9028e5cb73e3c707b4884550499e2a08af5c-refs/heads/master@{#381839} (32/64-bit) OS: Linux, Windows (Win 7- Aero enabled) URL: https://chrome.google.com/webstore/detail/alien-landscape/cedecfjcjkdclhodgcjnfjhmmmpbpdch?utm_source=chrome-ntp-icon Precondition: Enable 'Material design in the browser's top chrome' flag from 'chrome://flags'. What steps will reproduce the problem? 1) Launch chrome, go to above URL and add the theme. 2) Press Ctrl+Shift+B (to show Bookmarks bar) and go to chrome://settings. 3) Reset to default theme from chrome://settings and observe the bookmarks bar. Bookmark bar is seen in blue color (i.e applied theme color). Bookmark bar should change to default color. This is a Regression issue broken in M-51, will soon update other info
,
Mar 18 2016
Adding release block label, please undo if not the case.
,
Mar 18 2016
can you post screenshots instead of screencasts
,
Mar 18 2016
Issue 595595 has been merged into this issue.
,
Mar 18 2016
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b95559fb5be38c99cffe3dc365a43594bc73a8 commit 30b95559fb5be38c99cffe3dc365a43594bc73a8 Author: estade <estade@chromium.org> Date: Fri Mar 18 20:50:24 2016 [MD] Fix bookmark bar painting bugs. This fixes the background color bug. This may or may not fix the text rendering bug (but the text rendering bug is not that important to fix promptly). BUG= 595978 , 596003 Review URL: https://codereview.chromium.org/1815743002 Cr-Commit-Position: refs/heads/master@{#382079} [modify] https://crrev.com/30b95559fb5be38c99cffe3dc365a43594bc73a8/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Mar 18 2016
,
Mar 19 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 21 2016
,
Mar 21 2016
Please try to merge your change to M50 branch 2661 asap as we're getting closer to M50 beta candidate cut for this week. Thank you.
,
Mar 21 2016
,
Mar 21 2016
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c36752121a1aa0dda90b9800962319587995e763 commit c36752121a1aa0dda90b9800962319587995e763 Author: Evan Stade <estade@chromium.org> Date: Mon Mar 21 21:59:51 2016 [MD] Fix bookmark bar painting bugs. This fixes the background color bug. This may or may not fix the text rendering bug (but the text rendering bug is not that important to fix promptly). BUG= 595978 , 596003 Review URL: https://codereview.chromium.org/1815743002 Cr-Commit-Position: refs/heads/master@{#382079} (cherry picked from commit 30b95559fb5be38c99cffe3dc365a43594bc73a8) Review URL: https://codereview.chromium.org/1823623003 . Cr-Commit-Position: refs/branch-heads/2661@{#329} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/c36752121a1aa0dda90b9800962319587995e763/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Mar 22 2016
,
Mar 22 2016
Tested the same on win8.1 and Linux 14.04 chrome version 50.0.2661.48 - Bookmark bar changes to default color on clicking the "Reset to Default Theme" button in chrome://settings Please find the screenshot
,
Mar 28 2016
Verified on 51.0.2692.0/8121.0.0 dev-channel Chrome OS daisy |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by vvishwak...@etouch.net
, Mar 18 2016Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
694 KB
694 KB Download
744 KB
744 KB Download