ping? if not infra who should this be? Adding trooper.

Infra doesn't own analyze.py; it is owned by chromium/src.git folks (and perhaps most closely by gyp/gn folks, since it relies on their dependency graph iirc).

It knew that it needed to compile the sbox tests. I don't know why it didn't test them.

odd ... it's not immediately obvious to me what happened either. I'll take a look.

Okay, the problem is that the binaries are listed as compile targets but not test steps, so the bot is not actually configured to run the tests in any circumstances.

https://code.google.com/p/chromium/codesearch?q=testing%2Fbuildbot%2Fchromium.win.json#chromium/src/testing/buildbot/chromium.win.json&l=1624

i.e., analyze did what we asked it to do. To fix this, start actually running the tests on the Win8 Aura bot.

hmm. good point.

also, no dchecks on that bot. sigh.

in comment #7, wfh@ wrote:
> also, no dchecks on that bot. sigh.

I'm not sure I understand. dcheck_always_on==true on that bot:

https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/119098/steps/generate_build_files%20%28with%20patch%29/logs/stdio

sorry I was looking at Win8 Aura on the waterfall:

https://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/37808/steps/gclient%20runhooks/logs/stdio

I think they might share parts of the same configuration?

They do share much of the same configuration (including the lists of compile targets and tests to run), but they do *not* share the same MB/GYP/GN flags, exactly because we want dchecks enabled on the release trybots but not the release waterfall bots.

Oh okay I did not realise that was intentional for these to be different. that makes sense then.

I don't think I can go through and enable a load of tests on the "Win8 Aura" configuration as neither the try nor the waterfall bot uses swarming.

I think I'll go ahead and enable the sbox_* tests since those are so platform specific, and then go back to concentrating on getting win10 running on swarming.

Actually, it should be safe to just add tests that use swarming.

I'll post a separate CL to convert the existing tests to swarming as a start.

When manually running sbox_integration_tests on Window 10, two of the tests fail; AllowOpenEvent and DenyOpenEvent. According to jschuh@, all the AppContainerTests should probably be removed since they're not correct or have outlived their usefulness. Once those tests are disabled, sbox_integration_tests run successfully.