Extension API code uses linked_ptr in containers because that's all that worked when the generation was written. Now we can use the pure types if we make them moveable.
Issue 581625 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5 commit 63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 22 22:11:00 2016 [Extensions] Update generated code to support move operations Generated extensions code currently uses linked_ptrs for non-copyable types stored in containers. Instead, these types should just be movable. Update the code generator to support move operations for flagged idl files and apply it to the developerPrivate API as a first step/POC. BUG= 595949 Review URL: https://codereview.chromium.org/1811413002 Cr-Commit-Position: refs/heads/master@{#382704} [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/developer_private_api.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/developer_private_api.h [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/developer_private_mangle.h [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/extension_info_generator.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/extension_info_generator.h [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/browser/extensions/api/developer_private/inspectable_views_finder.h [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/chrome/common/extensions/api/developer_private.idl [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/cc_generator.py [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/cpp_type_generator.py [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/cpp_type_generator_test.py [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/h_generator.py [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/idl_schema.py [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/test/BUILD.gn [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/test/json_schema_compiler_tests.gyp [add] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/test/objects_movable.idl [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/test/objects_unittest.cc [modify] https://crrev.com/63ef43c0af90ca5f23d0606e2394b0e5f25fc0b5/tools/json_schema_compiler/util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6446c0e591ed89ee959511dd4f1c9cb5c4290609 commit 6446c0e591ed89ee959511dd4f1c9cb5c4290609 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 24 18:09:14 2016 [Extensions] Update generated code to support movable additional properties The initial pass-through missed updating "additional_properties". Fix this. BUG= 595949 Review URL: https://codereview.chromium.org/1829753003 Cr-Commit-Position: refs/heads/master@{#383097} [modify] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/cc_generator.py [modify] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/test/BUILD.gn [modify] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/test/json_schema_compiler_tests.gyp [modify] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/test/objects_movable.idl [add] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/test/objects_movable_json.json [modify] https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609/tools/json_schema_compiler/test/objects_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5 commit fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 24 19:27:06 2016 [Extensions] Convert APIs to use movable types [2] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Nowe, we can make these types movable. Update the following APIs to use movable types in this CL: - bookmark_manager_private.json - bookmarks.json - braille_display_private.idl - browser_action.json BUG= 595949 Review URL: https://codereview.chromium.org/1828633002 Cr-Commit-Position: refs/heads/master@{#383119} [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/common/extensions/api/bookmark_manager_private.json [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/common/extensions/api/bookmarks.json [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/common/extensions/api/braille_display_private.idl [modify] https://crrev.com/fa7d4b31e34874d58cae9a35f65d8bf2f9b9bab5/chrome/common/extensions/api/browser_action.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cb4c0e1be53447096ae11f820bb408b71184682 commit 1cb4c0e1be53447096ae11f820bb408b71184682 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 24 20:52:17 2016 [Extensions] Convert APIs to use movable types [3] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - browser.idl - browsing_data.json - cast_devices_private.idl - cast_streaming_receiver_session.idl - cast_streaming_rtp_stream.idl - cast_streaming_session.idl - cast_streaming_udp_transport.idl - certificate_provider.idl - certificate_provider_internal.idl - chrome_web_view_internal.json - chromeos_info_private.json - cloud_print_private.json - command_line_private.json - commands.json - content_settings.json - context_menus.json - context_menus_internal.json - cookies.json - copresence.idl - copresence_private.idl BUG= 595949 Review URL: https://codereview.chromium.org/1828683002 Cr-Commit-Position: refs/heads/master@{#383142} [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cookies/cookies_api.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cookies/cookies_helpers.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cookies/cookies_helpers.h [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/cookies/cookies_unittest.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/copresence/copresence_api.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/copresence/copresence_translations.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/copresence/copresence_translations.h [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/browser.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/browsing_data.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cast_devices_private.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cast_streaming_receiver_session.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cast_streaming_rtp_stream.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cast_streaming_session.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cast_streaming_udp_transport.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/certificate_provider.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/certificate_provider_internal.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/chrome_web_view_internal.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/chromeos_info_private.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cloud_print_private.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/command_line_private.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/commands.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/content_settings.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/context_menus.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/context_menus_internal.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/cookies.json [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/copresence.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/common/extensions/api/copresence_private.idl [modify] https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682/chrome/renderer/extensions/cast_streaming_native_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8e259c41e62ac086c681cff8fddd54fd8e30e73 commit c8e259c41e62ac086c681cff8fddd54fd8e30e73 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 24 21:56:24 2016 [Extensions] Convert APIs to use movable types [4] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - cryptotoken_private.idl - dashboard_private.json - data_reduction_proxy.json - debugger.json - declarative_content.json - desktop_capture.json - dial.idl - downloads.idl - downloads_internal.idl - easy_unlock_private.idl - echo_private.json - enterprise_device_attributes.idl - enterprise_platform_keys.idl - enterprise_platform_keys_internal.idl - enterprise_platform_keys_private.json - extension.json - feedback_private.idl BUG= 595949 Review URL: https://codereview.chromium.org/1822303002 Cr-Commit-Position: refs/heads/master@{#383157} [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/chromeos/feedback_util.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/dial/dial_api.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/downloads/downloads_api.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/feedback_private/feedback_private_api.h [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/feedback_private/feedback_service.cc [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/browser/extensions/api/feedback_private/feedback_service.h [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/cryptotoken_private.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/dashboard_private.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/data_reduction_proxy.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/debugger.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/declarative_content.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/desktop_capture.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/dial.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/downloads.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/downloads_internal.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/easy_unlock_private.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/echo_private.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/enterprise_device_attributes.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/enterprise_platform_keys.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/enterprise_platform_keys_internal.idl [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/enterprise_platform_keys_private.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/extension.json [modify] https://crrev.com/c8e259c41e62ac086c681cff8fddd54fd8e30e73/chrome/common/extensions/api/feedback_private.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c commit 467b5a8a1ccb999cbbd04a86bdec9a893e960a2c Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 25 00:10:47 2016 [Extensions] Convert APIs to use movable types [5] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - file_browser_handler.json - file_browser_handler_internal.json - file_manager_private.idl - file_manager_private_internal.idl - file_system.idl - file_system_provider.idl - file_system_provider_internal.idl BUG= 595949 Review URL: https://codereview.chromium.org/1829783002 Cr-Commit-Position: refs/heads/master@{#383198} [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/event_router.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/file_system_provider/operations/get_actions.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/extensions/api/file_system/file_system_api.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/extensions/api/file_system/file_system_api.h [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_browser_handler.json [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_browser_handler_internal.json [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_manager_private_internal.idl [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_system.idl [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_system_provider.idl [modify] https://crrev.com/467b5a8a1ccb999cbbd04a86bdec9a893e960a2c/chrome/common/extensions/api/file_system_provider_internal.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e624f8b800c3d12e0b6e513e807540eb4b4a631 commit 2e624f8b800c3d12e0b6e513e807540eb4b4a631 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 00:15:03 2016 [Extensions] Convert APIs to use movable types [9] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - processes.idl - proxy.json - resources_private.idl - screenlock_private.idl - sessions.json - settings_private.idl - signed_in_devices.idl - streams_private.idl - sync_file_system.idl - system_indicator.idl - system_private.json - tab_capture.idl - tabs.json BUG= 595949 Review URL: https://codereview.chromium.org/1827083005 Cr-Commit-Position: refs/heads/master@{#383625} [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/browser/extensions/api/processes/processes_api.cc [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/browser/extensions/api/sessions/sessions_api.cc [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/browser/extensions/api/sessions/sessions_api.h [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/browser/extensions/api/settings_private/settings_private_event_router.cc [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/processes.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/proxy.json [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/resources_private.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/screenlock_private.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/sessions.json [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/settings_private.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/signed_in_devices.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/streams_private.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/sync_file_system.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/system_indicator.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/system_private.json [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/tab_capture.idl [modify] https://crrev.com/2e624f8b800c3d12e0b6e513e807540eb4b4a631/chrome/common/extensions/api/tabs.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34f19a4895dd3899747867cea91b3a8400d6b231 commit 34f19a4895dd3899747867cea91b3a8400d6b231 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 00:18:56 2016 [Extensions] Convert APIs to use movable types [10] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - terminal_private.json - top_sites.json - tts.json - tts_engine.json - types.json - types_private.json - users_private.idl - wallpaper.json - wallpaper_private.json - web_navigation.json - webrtc_audio_private.idl - webrtc_desktop_capture_private.idl - webrtc_logging_private.idl - webstore.json - webstore_private.json - webstore_widget_private.idl - webview_tag.json - alarms.idl - app_current_window_internal.idl - app_runtime.idl - app_view_guest_internal.json - app_window.idl - audio.idl Also change AudioGetInfoFunction to be a SyncExtensionFunction for cleanup. BUG= 595949 Review URL: https://codereview.chromium.org/1833053004 Cr-Commit-Position: refs/heads/master@{#383628} [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/terminal_private.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/top_sites.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/tts.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/tts_engine.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/types.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/types_private.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/users_private.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/wallpaper.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/wallpaper_private.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/web_navigation.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webrtc_audio_private.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webrtc_desktop_capture_private.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webrtc_logging_private.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webstore.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webstore_private.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webstore_widget_private.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/chrome/common/extensions/api/webview_tag.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/alarms/alarms_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/audio/audio_api.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/audio/audio_api.h [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/audio/audio_service.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/audio/audio_service.h [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/browser/api/audio/audio_service_chromeos.cc [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/alarms.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/app_current_window_internal.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/app_runtime.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/app_view_guest_internal.json [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/app_window.idl [modify] https://crrev.com/34f19a4895dd3899747867cea91b3a8400d6b231/extensions/common/api/audio.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6 commit f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 16:57:11 2016 [Extensions] Convert APIs to use movable types [7] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - language_settings_private.idl - launcher_page.idl - launcher_search_provider.idl - log_private.idl - manifest_types.json - mdns.idl - media_galleries.idl - media_player_private.json - metrics_private.json - music_manager_private.idl - notification_provider.idl - notifications.idl BUG= 595949 Review URL: https://codereview.chromium.org/1825913002 Cr-Commit-Position: refs/heads/master@{#383746} [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.h [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.h [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/log_parser.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/log_parser.h [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/syslog_parser.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/syslog_parser.h [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/log_private/syslog_parser_unittest.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/mdns/mdns_api.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/notification_provider/notification_provider_api.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/extensions/api/notifications/notifications_api.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/notifications/notification_conversion_helper.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/browser/notifications/notification_conversion_helper_unittest.cc [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/language_settings_private.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/launcher_page.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/launcher_search_provider.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/log_private.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/manifest_types.json [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/mdns.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/media_galleries.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/media_player_private.json [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/metrics_private.json [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/music_manager_private.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/notification_provider.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/common/extensions/api/notifications.idl [modify] https://crrev.com/f841714cfa6a02bfa3f4bb5cdb3e0bda2ba7d8a6/chrome/utility/media_galleries/media_metadata_parser.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899 commit 8b7c7100ce06ea32d7eccea1d69a0c9e5704f899 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 20:27:54 2016 [Extensions] Convert APIs to use movable types [11] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - bluetooth.idl - bluetooth_private.idl - bluetooth_socket.idl - cast_channel.idl - declarative_web_request.json - diagnostics.idl - display_source.idl - dns.idl - document_scan.idl - events.json - extension_options_internal.idl - extension_types.json - extension_view_internal.json - extensions_manifest_types.json - guest_view_internal.json - hid.idl - idle.json Also add templates for movable types with errors. Note: The declarative content API uses events::Rules as linked ptrs to do cheap refcounting (which it shouldn't do). This will be addressed in a separate CL. BUG= 595949 Review URL: https://codereview.chromium.org/1841483002 Cr-Commit-Position: refs/heads/master@{#383804} [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/declarative/declarative_api.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/display_source/display_source_apitest.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/display_source/display_source_connection_delegate.h [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/bluetooth.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/bluetooth_private.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/bluetooth_socket.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/cast_channel.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/declarative_web_request.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/diagnostics.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/display_source.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/dns.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/document_scan.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/events.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/extension_options_internal.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/extension_types.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/extension_view_internal.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/extensions_manifest_types.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/guest_view_internal.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/hid.idl [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/idle.json [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/extensions/common/api/printer_provider/usb_printer_manifest_data.cc [modify] https://crrev.com/8b7c7100ce06ea32d7eccea1d69a0c9e5704f899/tools/json_schema_compiler/util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9 commit 7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 21:24:57 2016 [Extensions] Convert APIs to use movable types [8] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - omnibox.json - page_action.json - page_capture.json - passwords_private.idl - permissions.json - platform_keys.idl - platform_keys_internal.idl - preferences_private.json - privacy.json BUG= 595949 TBR=mpearson@chromium.org (trivial c/b/autocomplete/ change) Review URL: https://codereview.chromium.org/1833773002 Cr-Commit-Position: refs/heads/master@{#383829} [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/omnibox/omnibox_api.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/omnibox.json [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/page_action.json [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/page_capture.json [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/passwords_private.idl [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/permissions.json [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/platform_keys.idl [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/platform_keys_internal.idl [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/preferences_private.json [modify] https://crrev.com/7edeeeeb5245c12eba7c32cd683f1fb6b159d1b9/chrome/common/extensions/api/privacy.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d993d51b92d973c55e30b32711942861adfaa298 commit d993d51b92d973c55e30b32711942861adfaa298 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 29 21:32:58 2016 [Extensions] Convert APIs to use movable types [12] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - management.json - mime_handler_private.idl - mojo_private.idl - networking_config.idl - networking_private.idl - power.idl - printer_provider.idl - printer_provider_internal.idl - runtime.json BUG= 595949 Review URL: https://codereview.chromium.org/1841543002 Cr-Commit-Position: refs/heads/master@{#383832} [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/browser/api/management/management_api.cc [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/browser/api/networking_config/networking_config_api.cc [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/browser/api/printer_provider/printer_provider_api.cc [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/management.json [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/mime_handler_private.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/mojo_private.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/networking_config.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/networking_private.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/power.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/printer_provider.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/printer_provider_internal.idl [modify] https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298/extensions/common/api/runtime.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22abe73df650a8adaf0b78e02ebbbb4e670f3470 commit 22abe73df650a8adaf0b78e02ebbbb4e670f3470 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 30 22:36:11 2016 [Extensions] Convert APIs to use movable types [1] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - accessibility_features.json - activity_log_private.json - appview_tag.idl - audio_modem.idl - autofill_private.idl - automation.idl - automation_internal.idl - autotest_private.idl - bluetooth_low_energy.idl BUG= 595949 Review URL: https://codereview.chromium.org/1825263002 Cr-Commit-Position: refs/heads/master@{#384120} [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/activity_log/activity_actions.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/activity_log/activity_actions.h [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/audio_modem/audio_modem_api.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/autofill_private/autofill_util.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/autofill_private/autofill_util.h [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/accessibility_features.json [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/activity_log_private.json [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/appview_tag.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/audio_modem.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/autofill_private.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/automation.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/automation_internal.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/autotest_private.idl [modify] https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470/chrome/common/extensions/api/bluetooth_low_energy.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/372cf1d54c86e42644b7ef4a6269ee11f4ec278d commit 372cf1d54c86e42644b7ef4a6269ee11f4ec278d Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 30 22:46:17 2016 [Extensions] Convert APIs to use movable types [14] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - experience_sampling_private.json - windows.json - test.json - usb.idl - virtual_keyboard_private.json - vpn_provider.idl - web_request.json - web_request_internal.json - web_view_internal.json - webcam_private.idl BUG= 595949 Review URL: https://codereview.chromium.org/1843163003 Cr-Commit-Position: refs/heads/master@{#384126} [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/chrome/browser/extensions/api/sessions/sessions_api.cc [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/chrome/browser/extensions/api/sessions/sessions_api.h [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/chrome/common/extensions/api/experience_sampling_private.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/chrome/common/extensions/api/windows.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/browser/api/usb/usb_api.cc [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/test.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/usb.idl [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/virtual_keyboard_private.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/vpn_provider.idl [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/web_request.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/web_request_internal.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/web_view_internal.json [modify] https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d/extensions/common/api/webcam_private.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7 commit d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 31 22:19:28 2016 [Extensions] Convert APIs to use movable types [13] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - serial.idl - socket.idl - sockets_tcp.idl - sockets_tcp_server.idl - sockets_udp.idl - system_cpu.idl - system_display.idl - system_memory.idl - system_network.idl - system_storage.idl BUG= 595949 Review URL: https://codereview.chromium.org/1842953002 Cr-Commit-Position: refs/heads/master@{#384416} [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/chrome/browser/extensions/display_info_provider_aura.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/chrome/browser/extensions/display_info_provider_mac.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/chrome/browser/extensions/display_info_provider_win.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/serial/serial_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/serial/serial_api.h [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/socket/socket_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/sockets_udp/sockets_udp_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/cpu_info_provider.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/cpu_info_provider.h [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/cpu_info_provider_linux.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/cpu_info_provider_mac.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/cpu_info_provider_win.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_cpu/system_cpu_apitest.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_display/display_info_provider.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_display/display_info_provider.h [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_display/system_display_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_network/system_network_api.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_storage/storage_info_provider.cc [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/browser/api/system_storage/storage_info_provider.h [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/serial.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/socket.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/sockets_tcp.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/sockets_tcp_server.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/sockets_udp.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/system_cpu.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/system_display.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/system_memory.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/system_network.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/common/api/system_storage.idl [modify] https://crrev.com/d91f8ca4e5fdec5d220c6176d3f28c50834cb3f7/extensions/shell/browser/shell_display_info_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f48f9852d1ffdffa967cca7a25e7be2f7718b077 commit f48f9852d1ffdffa967cca7a25e7be2f7718b077 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 01 00:16:00 2016 [Extensions] Support choices in autogenerated movable types Choices were left out of our movable type generation. Add them, and add a test. BUG= 595949 Review URL: https://codereview.chromium.org/1837293004 Cr-Commit-Position: refs/heads/master@{#384443} [modify] https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077/tools/json_schema_compiler/cc_generator.py [modify] https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077/tools/json_schema_compiler/test/objects_movable.idl [modify] https://crrev.com/f48f9852d1ffdffa967cca7a25e7be2f7718b077/tools/json_schema_compiler/test/objects_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f501c58425cbab94a2f1004f20102353665da37c commit f501c58425cbab94a2f1004f20102353665da37c Author: eero.hakkinen <eero.hakkinen@intel.com> Date: Fri Apr 01 08:13:44 2016 [chrome.displaySource] Fix API conversion to moveable types. Not all display source files were converted to use moveable types by https://codereview.chromium.org/1841483002. That rendered display source uncompilable. This CL finishes the conversion. BUG=242107, 595949 Review URL: https://codereview.chromium.org/1845263002 Cr-Commit-Position: refs/heads/master@{#384517} [modify] https://crrev.com/f501c58425cbab94a2f1004f20102353665da37c/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da55d726a92435889ff6561fc3008765890d1f6 commit 9da55d726a92435889ff6561fc3008765890d1f6 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 01 18:57:57 2016 [Extensions] Remove 'use_movable_types' from code generation The 'use_movable_types' compiler option was added to piecemeal migrate extension apis to use movable types in code generation. This completes the migration, so we can remove this support. The entry in the json/idl files will be removed separately. BUG= 595949 Review URL: https://codereview.chromium.org/1853573002 Cr-Commit-Position: refs/heads/master@{#384649} [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/chrome/browser/extensions/api/history/history_api.cc [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/cc_generator.py [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/cpp_type_generator.py [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/cpp_type_generator_test.py [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/h_generator.py [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/idl_schema.py [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/test/arrays_unittest.cc [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/test/choices_unittest.cc [modify] https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6/tools/json_schema_compiler/test/idl_schemas_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88 commit e7b32419fe1b86cea29cad5dc1d54787f3d0ee88 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Sat Apr 02 01:31:02 2016 [Extensions] Remove the "use_movable_types" entry from idl/json files All APIs are converted to using movable types, and it is the default in code generation since r384649. We can remove the entry in the json/idl files. Also print an error with the filename if a file fails to parse as json. BUG= 595949 Review URL: https://codereview.chromium.org/1848103005 Cr-Commit-Position: refs/heads/master@{#384773} [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/accessibility_features.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/activity_log_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/appview_tag.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/audio_modem.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/autofill_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/automation.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/automation_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/autotest_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/bluetooth_low_energy.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/bookmark_manager_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/bookmarks.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/braille_display_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/browser.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/browser_action.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/browsing_data.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cast_devices_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cast_streaming_receiver_session.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cast_streaming_rtp_stream.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cast_streaming_session.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cast_streaming_udp_transport.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/certificate_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/certificate_provider_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/chrome_web_view_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/chromeos_info_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cloud_print_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/command_line_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/commands.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/content_settings.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/context_menus.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/context_menus_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cookies.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/copresence.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/copresence_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/cryptotoken_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/dashboard_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/data_reduction_proxy.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/debugger.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/declarative_content.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/desktop_capture.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/developer_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/dial.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/downloads.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/downloads_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/easy_unlock_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/echo_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/enterprise_device_attributes.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/enterprise_platform_keys.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/enterprise_platform_keys_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/enterprise_platform_keys_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/experience_sampling_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/extension.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/feedback_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_browser_handler.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_browser_handler_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_manager_private_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_system.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_system_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/file_system_provider_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/first_run_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/font_settings.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/gcd_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/gcm.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/hangouts_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/history.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/hotword_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/i18n.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/identity.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/identity_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/idltest.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/image_writer_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/inline_install_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/input_ime.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/input_method_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/instance_id.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/language_settings_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/launcher_page.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/launcher_search_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/log_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/manifest_types.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/mdns.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/media_galleries.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/media_player_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/metrics_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/music_manager_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/notification_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/notifications.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/omnibox.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/page_action.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/page_capture.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/passwords_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/permissions.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/platform_keys.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/platform_keys_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/preferences_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/privacy.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/processes.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/proxy.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/resources_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/screenlock_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/sessions.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/settings_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/signed_in_devices.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/streams_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/sync_file_system.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/system_indicator.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/system_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/tab_capture.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/tabs.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/terminal_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/top_sites.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/tts.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/tts_engine.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/types.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/types_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/users_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/wallpaper.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/wallpaper_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/web_navigation.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webrtc_audio_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webrtc_desktop_capture_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webrtc_logging_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webstore.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webstore_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webstore_widget_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/webview_tag.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/chrome/common/extensions/api/windows.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/alarms.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/app_current_window_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/app_runtime.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/app_view_guest_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/app_window.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/audio.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/bluetooth.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/bluetooth_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/bluetooth_socket.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/cast_channel.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/declarative_web_request.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/diagnostics.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/display_source.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/dns.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/document_scan.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/events.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/extension_options_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/extension_types.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/extension_view_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/extensions_manifest_types.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/guest_view_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/hid.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/idle.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/management.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/mime_handler_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/mojo_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/networking_config.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/networking_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/power.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/printer_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/printer_provider_internal.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/runtime.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/serial.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/socket.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/sockets_tcp.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/sockets_tcp_server.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/sockets_udp.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/system_cpu.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/system_display.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/system_memory.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/system_network.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/system_storage.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/test.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/usb.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/virtual_keyboard_private.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/vpn_provider.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/web_request.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/web_request_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/web_view_internal.json [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/extensions/common/api/webcam_private.idl [modify] https://crrev.com/e7b32419fe1b86cea29cad5dc1d54787f3d0ee88/tools/json_schema_compiler/json_schema.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d8ce9c0d399ff8897632ce7469c56f2e2487234 commit 3d8ce9c0d399ff8897632ce7469c56f2e2487234 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Mon Apr 04 21:14:16 2016 [Extensions] Remove linked_ptr entirely from extensions generated code After the work to implement movable types in extensions generated code (completed in r384773), we now only use linked_ptrs to store base::Values in containers. Luckily, we don't need to - convert these to scoped_ptrs and eliminate all traces of linked_ptrs from extensions generated code. BUG= 595949 TBR=isherman@chromium.org (autofill IWYU fix) Review URL: https://codereview.chromium.org/1854993002 Cr-Commit-Position: refs/heads/master@{#385005} [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/chrome/browser/chromeos/extensions/file_manager/job_event_router.h [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/browser/api/declarative/declarative_rule.h [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/browser/api/declarative/declarative_rule_unittest.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/browser/api/declarative/rules_registry.h [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/browser/api/system_storage/system_storage_apitest.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/extensions/common/api/declarative/declarative_manifest_data.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/tools/json_schema_compiler/cpp_type_generator.py [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/tools/json_schema_compiler/h_generator.py [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/tools/json_schema_compiler/util.cc [modify] https://crrev.com/3d8ce9c0d399ff8897632ce7469c56f2e2487234/tools/json_schema_compiler/util.h
out/Debug/gen/extensions/common/api $ grep linked_ptr ./* <nothing> out/Debug/gen/chrome/common/extensions/api $ grep linked_ptr ./* <nothing> tools/json_schema_compiler $ git grep linked_ptr <nothing> Work here is done. :)
Fantastic.
Comment 1 by rdevlin....@chromium.org
, Mar 22 2016