New issue
Advanced search Search tips

Issue 595946 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Have LogDog Annotee emit links to LogDog streams.

Project Member Reported by d...@chromium.org, Mar 18 2016

Issue description

Have LogDog Annotee emit links to LogDog streams.

This will involve:
1) Adding the capability for waterfalls to display additional links alongside their standard set.
2) Augmenting LogDog to emit log links when configured.
3) Augmenting annotated_run.py with additional parameters to construct the link.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a4b7935b55e9081b324db3c016788ae9ecaca2cd

commit a4b7935b55e9081b324db3c016788ae9ecaca2cd
Author: dnj@chromium.org <dnj@chromium.org>
Date: Fri Mar 18 23:04:59 2016

Add log and link aliasing to BuildBot.

This adds support for log/url aliases to BuildBot, and augments the
annotation engine to extract aliases from specially-formatted STEP_LINK
commands.

BuildBot will now associate and render a log/url's alias alongside it in
the build view.

The BuildBot annotation parser will identify STEP_LINK of the form
"alias-->orig", and add it as an alias for "orig" called "alias" instead
of as a separate URL link.

The template and BuildBot changes are intended to be backwards-compatible
with currently-running BuildBot instances to allow for master restarts
to pick this up gradually. A master that hasn't restarted will render
alias annotations as just more links (e.g., "alias-->orig"), should
aliases be emitted to that master before it has been restarted.

BUG= chromium:595946 
TEST=local
  - First up a custom waterfall / recipe engine, ran, looks decent.

Review URL: https://codereview.chromium.org/1812163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299396 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.chromium.perf.fyi/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.chromium/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.chromiumos/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.tryserver.blink/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.tryserver.chromium.linux/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/masters/master.tryserver.chromium.perf/templates/build.html
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/scripts/master/chromium_step.py
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/scripts/master/unittests/annotator_test.py
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/third_party/buildbot_8_4p1/buildbot/status/buildstep.py
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/third_party/buildbot_8_4p1/buildbot/status/web/build.py
[modify] https://crrev.com/a4b7935b55e9081b324db3c016788ae9ecaca2cd/third_party/buildbot_8_4p1/buildbot/status/web/templates/build.html

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 18 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 19 2016

Comment 5 by d...@chromium.org, Mar 21 2016

Cc: estaab@chromium.org
Last thing will be to add a "beta" banner to the log viewer now that it's public-ish. I'll do that in the morning.

Comment 6 by d...@chromium.org, Mar 21 2016

Status: Fixed (was: Started)

Comment 7 by aga...@chromium.org, Apr 27 2016

Components: Infra>Platform
Labels: -Infra-Platform

Sign in to add a comment