Find a better solution than symlinking files from one app to another |
||
Issue descriptionSince I needed to reuse some code from test-results app in chromium-try-flakes app (to avoid duplicating that code), I've created a symlink in https://chromium.googlesource.com/infra/infra/+/master/appengine/chromium_try_flakes/third_party/test_results/test_results/ to https://chromium.googlesource.com/infra/infra/+/master/appengine/test_results/appengine_module/test_results/handlers/util.py. I realize that this is not the best solution and that appengine_modules should be used instead. However, I've failed to 'make the world a better place' by moving test_results module into https://chromium.googlesource.com/infra/infra/+/master/appengine_module/. Afte the move a lot of tests fail: ... [error output here] ... Therefore not having a better idea I proceeded with symlinking. However, after chatting with Philippe today and learning that he and Erik were working on a better structure for the infra directory, I've decided to file this bug to keep track of the symlink and have it converted to a better solution later.
,
Jan 10
Archiving issues older than 2 years with no owner or component. |
||
►
Sign in to add a comment |
||
Comment 1 by serg...@chromium.org
, Mar 18 2016Forgot the error output: Traceback (most recent call last): File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/pipeline.py", line 513, in result_loop_single_context gen_loop_process(*test_gen_args) File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/pipeline.py", line 334, in gen_loop_process result_queue.put_nowait) File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 452, in gen_stage_loop for test in tests: File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/pipeline.py", line 277, in generate_tests gens = get_test_gens_package(testing_context, subpath=subpath) File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/pipeline.py", line 242, in get_test_gens_package mod = load_module(modname) File "/Users/sergiyb/infra/ENV/lib/python2.7/site-packages/expect_tests/pipeline.py", line 212, in load_module mod = __import__(modname) File "/Users/sergiyb/infra/appengine_module/test_results/handlers/test/buildershandler_test.py", line 32, in <module> from appengine_module.test_results.handlers import buildershandler ImportError: No module named appengine_module.test_results.handlers WARNING:root:You are using the default Django version (0.96). The default Django version will change in an App Engine release in the near future. Please call use_library() to explicitly select a Django version. For more information see https://developers.google.com/appengine/docs/python/tools/libraries#Django Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 268, in _feed send(obj) IOError: [Errno 32] Broken pipe Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 268, in _feed send(obj) IOError: [Errno 32] Broken pipe Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 268, in _feed send(obj) IOError: [Errno 32] Broken pipe