Build failures due to chromeos-chrome-optin-fix.patch |
||||
Issue descriptionWe have build failures on Cave, Chell, Link and Veyron_Rialto due to a Chrome ebuild patch: chromeos-chrome-51.0.2679.0_rc-r1: * Applying chromeos-chrome-optin-fix.patch ... chromeos-chrome-51.0.2679.0_rc-r1: chromeos-chrome-51.0.2679.0_rc-r1: * Failed Patch: chromeos-chrome-optin-fix.patch ! chromeos-chrome-51.0.2679.0_rc-r1: * ( /mnt/host/source/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/files/chromeos-chrome-optin-fix.patch ) https://uberchromegw.corp.google.com/i/chromeos/builders/veyron-b-release-group/builds/1371 https://uberchromegw.corp.google.com/i/chromeos/builders/glados-release-group/builds/806 https://uberchromegw.corp.google.com/i/chromeos/builders/ivybridge-release-group/builds/1814 It seems highly likely that they were caused by this chump: https://chromium-review.googlesource.com/#/c/333220/ I'm not quite sure why only a few boards are affected, but we have some (unrelated) PFQ redness right now so maybe other boards just haven't caught up yet. Could someone more familiar with that patch please take a look?
,
Mar 17 2016
just revert & chump it
,
Mar 17 2016
vapier@ - can you do the revert? I don't really understand how that CL works or what the effect of the revert will be.
,
Mar 17 2016
I've already uploaded a vanilla revert at http://crosreview.com/333664 in accordance with #2. If that's somehow not the right thing to do, someone who actually knows what's going on here better stop me quickly.
,
Mar 17 2016
you can just use the "revert" button in this case
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bc23d3d8edf8217dea8e796edcca5b4fe31612d6 commit bc23d3d8edf8217dea8e796edcca5b4fe31612d6 Author: Julius Werner <jwerner@chromium.org> Date: Thu Mar 17 23:16:44 2016 Revert "chromeos-chrome: Temporarily patch the optin fix" This reverts commit 214a30ca7706a10d201962c7b48c6613ac1803b6. This patch broke Chrome on Cave, Chell, Link and Veyron_Rialto builders for unknown reasons. By the power vested in me through the office of Chrome OS Tree Sheriff, you are hereby reverted! BUG= chromium:595914 TEST=None Change-Id: I62f972a16294138526cc110a88dd7037c86f41a8 Reviewed-on: https://chromium-review.googlesource.com/333664 Reviewed-by: Julius Werner <jwerner@chromium.org> Commit-Queue: Julius Werner <jwerner@chromium.org> Tested-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/bc23d3d8edf8217dea8e796edcca5b4fe31612d6/chromeos-base/chromeos-chrome/chromeos-chrome-51.0.2679.0_rc-r1.ebuild [modify] https://crrev.com/bc23d3d8edf8217dea8e796edcca5b4fe31612d6/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild [delete] https://crrev.com/6f23a35b20595425ffd3ad367e250c5b510d5593/chromeos-base/chromeos-chrome/files/chromeos-chrome-optin-fix.patch
,
Mar 18 2016
Reverted. I'll check the canaries tomorrow to confirm the issue is resolved.
,
Mar 18 2016
Affected boards can now pass build_packages (except for Cave which has a new failure). |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Mar 17 2016