New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Spitzer fullscreen transitions hit a DCHECK in MediaWebContentsObserver

Project Member Reported by w...@chromium.org, Mar 17 2016

Issue description

On resume, the DidPlay notification is being sent to MWCO, but we never sent a DidPause notification for the suspend. MWCO DCHECKs that you don't try to add the same player twice.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fd2eb18f1ed48a1047d737a9db170608ac6f47

commit 73fd2eb18f1ed48a1047d737a9db170608ac6f47
Author: watk <watk@chromium.org>
Date: Fri Mar 18 21:45:57 2016

media: Allow WMPI to send playing started notification while playing

Previously MediaWebContentsObserver DCHECKed that an active player
was never added twice. To avoid complicated logic in WMPI to keep track
of when it's okay to send a playing notification to
MediaWebContentsObserver, now it's allowed to send it more than once.

BUG= 595903 ,  595970 

Review URL: https://codereview.chromium.org/1810213002

Cr-Commit-Position: refs/heads/master@{#382098}

[modify] https://crrev.com/73fd2eb18f1ed48a1047d737a9db170608ac6f47/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/73fd2eb18f1ed48a1047d737a9db170608ac6f47/content/browser/media/media_web_contents_observer.h

Labels: Merge-Request-50 Proj-Spitzer M-50

Comment 3 by tin...@google.com, Mar 19 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/217c5e96c255d046fce4a1743b560e7ee5625a82

commit 217c5e96c255d046fce4a1743b560e7ee5625a82
Author: Chris Watkins <watk@chromium.org>
Date: Mon Mar 21 18:08:05 2016

media: Allow WMPI to send playing started notification while playing

Previously MediaWebContentsObserver DCHECKed that an active player
was never added twice. To avoid complicated logic in WMPI to keep track
of when it's okay to send a playing notification to
MediaWebContentsObserver, now it's allowed to send it more than once.

BUG= 595903 ,  595970 

Review URL: https://codereview.chromium.org/1810213002

Cr-Commit-Position: refs/heads/master@{#382098}
(cherry picked from commit 73fd2eb18f1ed48a1047d737a9db170608ac6f47)

Review URL: https://codereview.chromium.org/1821753002 .

Cr-Commit-Position: refs/branch-heads/2661@{#321}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/217c5e96c255d046fce4a1743b560e7ee5625a82/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/217c5e96c255d046fce4a1743b560e7ee5625a82/content/browser/media/media_web_contents_observer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b91661ebac34b1096186920caff52cf8b142c55

commit 6b91661ebac34b1096186920caff52cf8b142c55
Author: dalecurtis <dalecurtis@chromium.org>
Date: Tue Mar 22 20:42:36 2016

Release media session and power save blockers for casting.

BUG= 595903 
TEST=none

Review URL: https://codereview.chromium.org/1813373003

Cr-Commit-Position: refs/heads/master@{#382670}

[modify] https://crrev.com/6b91661ebac34b1096186920caff52cf8b142c55/media/blink/webmediaplayer_impl.cc

Comment 6 by w...@chromium.org, Mar 24 2016

Status: Fixed (was: Started)

Sign in to add a comment