New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.sync.SyncTest#testRename is flaky on trybots

Project Member Reported by hush@chromium.org, Mar 17 2016

Issue description

It is failing natively at 
71c17:  03-17 21:10:43.779 32739 32739 F chromium: [FATAL:profile_sync_service.cc(1100)] Check failed: false. 

See this trybot run: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/39883

Add acleung and maxbogue because you reenabled the test in https://codereview.chromium.org/1731583002/
Can you guys investigate?

The attachment is a logcat section for the NOTREACHED crash

 
crash.txt
23.4 KB View Download

Comment 1 by hush@chromium.org, Mar 17 2016

Labels: OS-Android

Comment 2 by hush@chromium.org, Mar 18 2016

I will revert the CL because it flaked on a commit queue for a CL that's completely unrelated.

Comment 3 by hush@chromium.org, Mar 18 2016

eh.. I mean I will just disable it.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993c797f4056cb5accdbbdf906b53f9b2256b291

commit 993c797f4056cb5accdbbdf906b53f9b2256b291
Author: hush <hush@chromium.org>
Date: Wed Mar 23 18:22:05 2016

Disable SyncTest#testRename because it is flaky on CQ.

BUG= 595893 

Review URL: https://codereview.chromium.org/1815303002

Cr-Commit-Position: refs/heads/master@{#382885}

[modify] https://crrev.com/993c797f4056cb5accdbbdf906b53f9b2256b291/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java

Comment 5 by hush@chromium.org, Mar 23 2016

Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/682616a7c7f35634fa694a188ea0b5e97a5e8d8d

commit 682616a7c7f35634fa694a188ea0b5e97a5e8d8d
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Jun 07 18:55:28 2016

[Sync] Remove NOTREACHED that causes flakes in Android tests.

It doesn't seem to actually need to be there. The comment even says that
branch can happen and doesn't seem to mention it being a problem.

Specifically, I have seen this cause SyncTest.testRename to flake
locally.

BUG= 588050 , 595893 

Review-Url: https://codereview.chromium.org/2044213002
Cr-Commit-Position: refs/heads/master@{#398355}

[modify] https://crrev.com/682616a7c7f35634fa694a188ea0b5e97a5e8d8d/components/browser_sync/browser/profile_sync_service.cc

Sign in to add a comment