New issue
Advanced search Search tips

Issue 595885 link

Starred by 7 users
Status: Verified
Owner:
tommycli@chromium.org
Closed: Dec 2016
Cc:
mahmadi@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[People -> Easy Unlock] Turn off Dialog Mocks Needeed

Project Member Reported by tommycli@chromium.org, Mar 17 2016 
See below attached images for the current Options status quo.

I'm proceeding to implement using the old Options dialog layout as the live-mock, but I could use some actual mocks to get some definitive info.

Attached images:

1. Where to find the dialog (mock already exists)
2. The dialog when the user is Offline (Should there really be no buttons?)
3. The dialog when the user is Online (looks fine to me)
4. The video of the user actually clicking "Turn off". Note that a spinner appears in the bottom-left when the feature is turned off. Are we preserving that layout?

Thanks
IMG_20160317_143849.jpg
2.8 MB View Download
IMG_20160317_143925.jpg
2.9 MB View Download
IMG_20160317_143941.jpg
3.1 MB View Download
VID_20160317_144028.mp4
10.2 MB Download

Comment 1 by tommycli@chromium.org, Mar 17 2016 

There is also the "Error" condition which I was not able to replicate. The strings are:

Title: Smart Lock is unavailable
Body: Smart Lock is currently unavailable. Please try again later.
Turn Off Button: Text is "Retry"
Dismiss Button: Hidden

This also either needs a mock, or you can just tell me how you want it to look and behave.

Comment 2 by bettes@chromium.org, Mar 17 2016

Status: Assigned (was: Untriaged)

Comment 3 by bettes@chromium.org, Mar 17 2016

Status: Assigned (was: Untriaged)

Comment 4 by tommycli@chromium.org, Mar 18 2016 

One more situation needing mocking. If the proximity flag is allowed, there is one extra shown checkbox. (Only if Easy Unlock is already enabled)
Screenshot from 2016-03-18 13:53:40.png
28.8 KB View Download

Comment 5 by tommycli@chromium.org, Mar 18 2016 

Attached the "simple" implementation for that checkbox. Looks kind of bad because it stretches the settings-box beyond its intended size.
Screenshot from 2016-03-18 14:06:17.png
13.9 KB View Download

Comment 6 by tbuck...@chromium.org, Mar 25 2016

Labels: Pri-2 Type-Bug
Setting default priority/type

Comment 7 by tbuck...@chromium.org, Mar 25 2016 

Setting default priority/type

Comment 8 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-PeopleCrOS

Comment 9 by tbuck...@chromium.org, Aug 10 2016 

@tommycli I think monorail was down when I tried to post my last comment -- the dialog spec should have everything you need, can you let Alan know if there are any questions?

Comment 10 by tbuck...@chromium.org, Aug 10 2016 

 Issue 635353  has been merged into this issue.

Comment 11 by tommycli@chromium.org, Sep 13 2016

Cc: tommycli@chromium.org
Owner: mahmadi@chromium.org

Comment 12 by mahmadi@chromium.org, Nov 14 2016

Cc: -tommycli@chromium.org mahmadi@chromium.org
Owner: tommycli@chromium.org
Tommy, I recently landed a UI polish for the easy unlock row (https://codereview.chromium.org/2482553002/) However, I'm unsure what the status of other flows/mocks are. Assigning back to you to take over the effort.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90965e32c0587843c43b2765e98a8530ef92a0de

commit 90965e32c0587843c43b2765e98a8530ef92a0de
Author: tommycli <tommycli@chromium.org>
Date: Wed Nov 30 22:14:08 2016

MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG= 595885 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2539733004
Cr-Commit-Position: refs/heads/master@{#435441}

[modify] https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
[modify] https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de/chrome/browser/resources/settings/people_page/people_page.js

Comment 14 by tommycli@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)
Sure hope this works now.

Comment 15 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 16 by abod...@chromium.org, Apr 5 2017

Status: Verified (was: Fixed)
Chrome OS 9433.0.0 59.0.3055.0
►

Sign in to add a comment