New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595861 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Aug 7
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MaterialDesign] [Mac]: Tab icon from "Press tab to search..." in the Omnibox is too low

Project Member Reported by meh...@chromium.org, Mar 17 2016 
Version: Version 51.0.2681.0 canary (64-bit)
OS: 10.11.3

What steps will reproduce the problem?
(1) take a look at the screenshot


What is the expected output? What do you see instead?
Tab icon from "Press tab to search..." in the Omnibox is too low. 

Please use labels and text to provide additional information.
In the screenshot: top=old and bottom=MD


Thanks and regards
Mehmet
Bildschirmfoto 2016-03-17 um 21.36.49.png
46.3 KB View Download

Comment 1 by shrike@chromium.org, Mar 17 2016

Cc: -sgabr...@chromium.org shrike@chromium.org
Owner: sgabr...@chromium.org
The location bar is 1pt shorter in MD, so that's part of where the space went.

The vertical position is correct if all of the text (in the button and outside of it) is to share the same baseline.

Comment 2 by meh...@chromium.org, Mar 17 2016 

This is how it looks in Incognito.
Bildschirmfoto 2016-03-17 um 22.02.17.png
23.5 KB View Download

Comment 3 by sgabr...@chromium.org, Mar 21 2016 

I revamped tab search as part of MD to be simpler and the size of the chip. I attached the 1x and 2x .svgs. You should be able to switch the color from #5a5a5a to #FFF in incognito after prog rendering.

Let's also reduce the size of the "press | | to search [...]" to 12pt.
Preview and assets attached.
Tab-search.png
265 KB View Download
keyword_hint_tab-1x.svg
1.4 KB Download
keyword_hint_tab-2x.svg
1.4 KB Download

Comment 4 by sgabr...@chromium.org, Mar 21 2016

Cc: -shrike@chromium.org sgabr...@chromium.org
Owner: shrike@chromium.org

Comment 5 by shrike@chromium.org, Mar 21 2016

Blocking: 547953
Components: UI>Browser>Core
Labels: M-51
Sounds good.

Comment 6 by ugurcan....@gmail.com, Mar 23 2016 

+shrike It looks like traffic lights bar is translucent according to specs from comment #3. 

Tab strip changes don't seem to make the bar translucent. Is there a plan for it? I couldn't find any open bugs about it.

Comment 7 by shrike@chromium.org, Mar 23 2016 

The tab strip background (which includes the area behind the traffic lights) is definitely translucent. You have to have Material Design turned on and should place the window in front of a vibrant photo to see it (it can be very subtle).

If you still don't see it please don't add comments to this bug - this bug is not about the tab strip's background.

Comment 8 by ugurcan....@gmail.com, Mar 23 2016 

Filed  bug 597453 . Thanks.

Comment 9 by shrike@chromium.org, May 6 2016

Labels: -M-51 M-52
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by shrike@chromium.org, Jun 1 2016

Blocking: -547953
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 15 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by shrike@chromium.org, Oct 12 2016

Cc: shrike@chromium.org nyerramilli@chromium.org ranjitkan@chromium.org tkonch...@chromium.org
 Issue 655097  has been merged into this issue.

Comment 14 by shrike@chromium.org, Nov 16 2016

Labels: Proj-NativeMacMD

Comment 15 by shrike@chromium.org, Jan 24 2018

Cc: -shrike@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
No longer sure this is still a problem - moving back to triage.

Comment 16 by meh...@chromium.org, Jan 24 2018 

I still can reproduce it with Chrome Canary 66.0.3330.0 on macOS 10.12.6. It is more noticeable in Incognito. The icon is very close to the Omnibox border.

Please see the screenshot.
Bildschirmfoto 2018-01-24 um 19.31.23.png
19.6 KB View Download

Comment 17 by erikc...@chromium.org, Jan 30 2018

Labels: Hotlist-CocoaBrowser
Status: Available (was: Untriaged)

Comment 18 by meh...@chromium.org, Aug 7

Status: WontFix (was: Available)
This will be no longer an issue with MdRefresh. Closing.
►

Sign in to add a comment