Mash Shell Shelf Tooltips |
|||
Issue descriptionMash Shell Shelf Tooltips ShelfTooltipManager doesn't show bubble tooltips for shelf items in mash. See parent Issue 557406
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 commit 1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 Author: msw <msw@chromium.org> Date: Fri Mar 25 23:31:12 2016 Refine ash shelf tooltip closing on non-mash ChromeOS. Fixes a regression from: https://codereview.chromium.org/1816753002 Also reverse expected behavior for touching tooltips. (closes on stable, tests expected them to stay open...) Inline bubble function definitions. Call WillDeleteShelf earlier to fix a test crash... TODO: Encapsulate more ShelfLayoutManager code. BUG= 595853 TEST=ChromeOS tooltips stay open on hover; close for external touches. R=sky@chromium.org Review URL: https://codereview.chromium.org/1828133004 Cr-Commit-Position: refs/heads/master@{#383404} [modify] https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24/ash/shelf/shelf_tooltip_manager_unittest.cc
,
Mar 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/053ef0ef0cb9765594615de430fad25b24d100c6 commit 053ef0ef0cb9765594615de430fad25b24d100c6 Author: msw <msw@chromium.org> Date: Sat Mar 26 04:18:57 2016 Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #4 id:60001 of https://codereview.chromium.org/1828133004/ ) Reason for revert: Memory failures, eg. https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/8340 Original issue's description: > Refine ash shelf tooltip closing on non-mash ChromeOS. > > Fixes a regression from: https://codereview.chromium.org/1816753002 > Also reverse expected behavior for touching tooltips. > (closes on stable, tests expected them to stay open...) > > Inline bubble function definitions. > Call WillDeleteShelf earlier to fix a test crash... > TODO: Encapsulate more ShelfLayoutManager code. > > BUG= 595853 > TEST=ChromeOS tooltips stay open on hover; close for external touches. > R=sky@chromium.org > > Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 > Cr-Commit-Position: refs/heads/master@{#383404} TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 595853 Review URL: https://codereview.chromium.org/1836753002 Cr-Commit-Position: refs/heads/master@{#383444} [modify] https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6/ash/shelf/shelf_tooltip_manager_unittest.cc
,
Mar 28 2016
,
Mar 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2aa7f5e8870c04c8aff0fd5da27820636e53e38 commit c2aa7f5e8870c04c8aff0fd5da27820636e53e38 Author: msw <msw@chromium.org> Date: Mon Mar 28 22:23:07 2016 Refine ash shelf tooltip closing on non-mash ChromeOS. Fixes a regression from: https://codereview.chromium.org/1816753002 Also reverse expected behavior for touching tooltips. (closes on stable, tests expected them to stay open...) Inline bubble function definitions. Call WillDeleteShelf earlier to fix a test crash... TODO: Encapsulate more ShelfLayoutManager code. BUG= 595853 TEST=ChromeOS tooltips stay open on hover; close for external touches. R=sky@chromium.org Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 Cr-Commit-Position: refs/heads/master@{#383404} Review URL: https://codereview.chromium.org/1828133004 Cr-Commit-Position: refs/heads/master@{#383579} [modify] https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38/ash/shelf/shelf_widget.cc
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/327ea5e179d66d730bd6e03486b3494660d84dbc commit 327ea5e179d66d730bd6e03486b3494660d84dbc Author: msw <msw@chromium.org> Date: Tue Mar 29 00:04:44 2016 Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #5 id:80001 of https://codereview.chromium.org/1828133004/ ) Reason for revert: ash_unittests ShelfLayoutManagerTest.ShutdownHandlesWindowActivation failure on win: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47284 Original issue's description: > Refine ash shelf tooltip closing on non-mash ChromeOS. > > Fixes a regression from: https://codereview.chromium.org/1816753002 > Also reverse expected behavior for touching tooltips. > (closes on stable, tests expected them to stay open...) > > Inline bubble function definitions. > Call WillDeleteShelf earlier to fix a test crash... > TODO: Encapsulate more ShelfLayoutManager code. > > BUG= 595853 > TEST=ChromeOS tooltips stay open on hover; close for external touches. > R=sky@chromium.org > > Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 > Cr-Commit-Position: refs/heads/master@{#383404} > > Committed: https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38 > Cr-Commit-Position: refs/heads/master@{#383579} TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 595853 Review URL: https://codereview.chromium.org/1834203003 Cr-Commit-Position: refs/heads/master@{#383622} [modify] https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc/ash/shelf/shelf_widget.cc
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b1ca37ffa7c373b9b726f786f410bc80348a246 commit 5b1ca37ffa7c373b9b726f786f410bc80348a246 Author: msw <msw@chromium.org> Date: Tue Mar 29 20:11:01 2016 Refine ash shelf tooltip closing on non-mash ChromeOS. Fixes a regression from: https://codereview.chromium.org/1816753002 Also reverse expected behavior for touching tooltips. (closes on stable, tests expected them to stay open...) Inline bubble function definitions. Use WindowObserver to remove the handler on window destruction. TODO: Encapsulate more ShelfLayoutManager code. BUG= 595853 TEST=ChromeOS tooltips stay open on hover; close for external touches. R=sky@chromium.org Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 Cr-Commit-Position: refs/heads/master@{#383404} Committed: https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38 Cr-Commit-Position: refs/heads/master@{#383579} Review URL: https://codereview.chromium.org/1828133004 Cr-Commit-Position: refs/heads/master@{#383801} [modify] https://crrev.com/5b1ca37ffa7c373b9b726f786f410bc80348a246/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/5b1ca37ffa7c373b9b726f786f410bc80348a246/ash/shelf/shelf_tooltip_manager.h [modify] https://crrev.com/5b1ca37ffa7c373b9b726f786f410bc80348a246/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/5b1ca37ffa7c373b9b726f786f410bc80348a246/ash/shelf/shelf_widget.cc
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b53df9e2ff6a08ab6203129e8be41583712099f9 commit b53df9e2ff6a08ab6203129e8be41583712099f9 Author: msw <msw@chromium.org> Date: Wed May 04 21:28:37 2016 Close mash shelf tooltips on touches outside the shelf. Make ShelfTooltipManager a views::PointerWatcher. Close on mouse/touch press (including outside shelf root). BUG= 595853 TEST=Touches outside the shelf area close shelf tooltips. R=jamescook@chromium.org,sky@chromium.org Review-Url: https://codereview.chromium.org/1937673002 Cr-Commit-Position: refs/heads/master@{#391647} [modify] https://crrev.com/b53df9e2ff6a08ab6203129e8be41583712099f9/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/b53df9e2ff6a08ab6203129e8be41583712099f9/ash/shelf/shelf_tooltip_manager.h
,
May 4 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 23 2016