Mash Shell Shelf Alignment and Autohide Changing the mash shelf alignment or activating Autohide doesn't alter bounds. We'll need to add support in mash::wm::ShelfLayout. See parent Issue 557406
I'll take this. Also, msw@ is going to do some plumbing to get sysui and wm to talk to each other about autohide state.
Mike's actually doing the work on this right now. I'll take it back when I finish the system tray bubble stuff.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68b18edb1ca481397ac2ccd95c40e201f657adfe commit 68b18edb1ca481397ac2ccd95c40e201f657adfe Author: msw <msw@chromium.org> Date: Fri Apr 15 19:43:40 2016 Support additional mash shelf alignments. Support left/bottom/right alignments in ash::wm::ShelfLayout. Propagate alignment changes with a new ShelfLayout interface. Add RootWindowController::GetLayoutManagerForContainer helper. TODO: Update preferred sizes with alignment to avoid flicker. BUG= 595852 TEST=mash shelf supports left/bottom/right alignments (with some flicker). R=jamescook@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/1835403002 Cr-Commit-Position: refs/heads/master@{#387679} [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/ash/mus/shelf_delegate_mus.cc [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/ash/mus/shelf_delegate_mus.h [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/shelf/public/interfaces/BUILD.gn [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/shelf/public/interfaces/shelf.mojom [add] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/shelf/public/interfaces/shelf_constants.mojom [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/public/interfaces/BUILD.gn [add] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/public/interfaces/shelf_layout.mojom [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/root_window_controller.cc [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/root_window_controller.h [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/shelf_layout.cc [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/shelf_layout.h [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/window_manager_application.cc [modify] https://crrev.com/68b18edb1ca481397ac2ccd95c40e201f657adfe/mash/wm/window_manager_application.h
I split the autohide stuff into a separate bug, issue 613212 . This issue can probably be closed as fixed.
Comment 1 by jamescook@chromium.org
, Mar 28 2016Status: Assigned (was: Available)