New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595842 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 506977
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 506977



Sign in to add a comment

Windows 10 Stylus Flick gestures interfere with drawing via mouse events

Project Member Reported by tdres...@chromium.org, Mar 17 2016

Issue description

To repro:
On a Windows 10 device with a Stylus:
Enable "Use flicks to perform common actions quickly and easily"

- Visit https://output.jsbin.com/kiwimo/44/quiet
- Draw with the style, large curves illustrate the problem best

We should draw a smooth curve, but the first line segment is massive.

Disable flicks and retry, and we draw a smooth curve.

Edge doesn't have this issue, even with flicks enabled.
 

Comment 1 by jsc...@chromium.org, Mar 21 2016

Components: Internals>PlatformIntegration
Owner: kylixrd@chromium.org
kylixrd - Interested in pen input?
This may be because Edge is using the inking API?
It appears that Edge is disabling flick gestures while pointer events are listened to. I can get the flick to register with the pen in Chrome, but not in Edge.
There is a way to disable flick gestures for a specific region by responding to the WM_TABLET_QUERYSYSTEMGESTURESTATUS message. In fact, it seems that Edge always disables flicks. I cannot get Edge to respond to flick gestures at all.

Comment 5 by rbyers@chromium.org, Mar 29 2016

Blockedon: 506977
I thought ananta@ disabled flick gesture support back in December?  See  issue 506977 .
ananta@ did, in fact, disable this. I was checking it on M49 where it was reproducing. I then tested against a developer chromium build and it isn't reproducing. I'm installing Canary on the Surface device to test it.

All signs point to being fixed.
Status: WontFix (was: Assigned)
Sorry for the noise, I can't repro in Canary.
Mergedinto: 506977
Status: Duplicate (was: WontFix)
Sorry for even more noise...

Isn't this a duplicate then?
tl;dr; I'm reactivating this issue. I've been able to conclusively confirm that the MICROSOFT_TABLETPENSERVICE_PROPERTY window property must be set for every HWND that can receive pen/stylus input. This includes child windows. I was able to reproduce this on the Canary build using a Surface Book with the stylus.

I wrote a stand-alone app that is a top-level window with a child-window covering part of the window. The app disables Flicks on the parent window, but the child window still has them enabled. Using the stylus, input a flick and it will register when initiated on the child window, but not if initiated on the parent window.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e

commit fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e
Author: kylixrd <kylixrd@chromium.org>
Date: Thu Apr 07 21:05:18 2016

Need to set the MICROSOFT_TABLETPENSERVICE_PROPERTY window property even for child windows
to properly disable Flicks.

Added Tpcshrd.h header
All HWNDS need to have Flicks disabled

BUG= 595842 

Review URL: https://codereview.chromium.org/1852503002

Cr-Commit-Position: refs/heads/master@{#385846}

[modify] https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e/base/win/win_util.cc
[modify] https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e/base/win/win_util.h
[modify] https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/fd3c1f989b2e3012be9e6cffdb6bfa86b9fda99e/ui/views/win/hwnd_message_handler.cc

Sign in to add a comment