danakj@, care to take a look? Not sure if it's related to your last CL: https://codereview.chromium.org/1807813002 Example of a bot failing on those tests: https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/12021 Logfile: https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/12021/steps/content_browsertests%20on%20Windows-7-SP1/logs/SignalTest.BasicSignalQueryTest Looks like DISABLED tests are being triggered (ex: BrowserGpuChannelHostFactoryTest_DISABLED_GrContextKeepsGpuChannelAlive_Test)
Hah, I don't think DISABLED does anything in the middle of the string like that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ed4cc3da505493bf00915bce9dd252fa4806d3 commit 29ed4cc3da505493bf00915bce9dd252fa4806d3 Author: Stuart Langley <slangley@chromium.org> Date: Tue Nov 21 12:18:56 2017 Replace WTF_MAKE_NONCOPYABLE with DISALLOW_COPY_AND_ASSIGN in //WebKit/Source/core/css/ This changes is for files in the path //third_party/WebKit/Source/core/css/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 595832 Change-Id: Ic36c912529e907c36cead329bea67f558dd26c79 Reviewed-on: https://chromium-review.googlesource.com/780700 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#518223} [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSFontFace.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSFontFaceSource.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSGlobalRuleSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSPaintValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSPropertyValueSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSRuleList.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSStyleSheet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSTiming.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSValueList.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSValuePool.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/CSSVariableData.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/DocumentStyleSheetCollection.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/ElementRuleCollector.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/FontFace.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/FontFaceSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/FontFaceSetDocument.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/FontFaceSetWorker.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/MediaQueryList.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/MediaQueryMatcher.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/RuleFeatureSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/RuleSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/SelectorChecker.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/SelectorFilter.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/SelectorQuery.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/ShadowTreeStyleSheetCollection.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/StyleSheetCollection.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathInvert.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathMax.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathMin.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathNegate.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathProduct.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathSum.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMathVariadic.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSNumericArray.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSPositionValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSResourceValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSRotation.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSScale.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSSkew.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSStyleVariableReferenceValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/invalidation/PendingInvalidations.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSParserTokenStream.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSTokenizer.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/parser/MediaQueryParser.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/FontBuilder.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/MatchResult.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/StyleResolver.h [modify] https://crrev.com/29ed4cc3da505493bf00915bce9dd252fa4806d3/third_party/WebKit/Source/core/css/resolver/StyleResolverState.h
Comment 1 by danakj@chromium.org
, Mar 17 2016Status: Duplicate (was: Assigned)