devtools UI suggestion: remove redundant "add style rule" button |
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2680.0 Safari/537.36 Steps to reproduce the problem: 1. hover over a style rule in styles pane 2. hover over the three-dots icon in bottom-right 3. look at the redundant "add style rule" button and question why it is there What is the expected behavior? What went wrong? When I hover over the three-dots icon, I expect all of the options to be related to that style rule. Case in point, the "add color" and "add background-color" buttons. The "add style rule" violates my expectations. There is a very visible "add style rule" button at the top of the styles pane. I don't see the need for this redundant button. Did this work before? No Chrome version: 51.0.2680.0 Channel: canary OS Version: OS X 10.11.3 Flash Version: Shockwave Flash 21.0 r0
,
Mar 17 2016
Yup. that works for me too. Kayce do you want to submit a pull request? You can edit this file here: https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/elements/StylesSidebarPane.js#L772
,
Mar 18 2016
After submitting the bug I realized that it's useful to be able to specify exactly where a style rule is applied because of cascading. Paul sounds good!
,
Mar 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3fc784439707b10c8f01fdc8dec954d91d30200 commit b3fc784439707b10c8f01fdc8dec954d91d30200 Author: kayce <kayce@google.com> Date: Tue Mar 22 20:56:12 2016 update label in styles pane Changes label in devtools styles pane from "insert style rule" to "insert style rule below" for clarity. BUG= 595831 Review URL: https://codereview.chromium.org/1824013004 Cr-Commit-Position: refs/heads/master@{#382676} [modify] https://crrev.com/b3fc784439707b10c8f01fdc8dec954d91d30200/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
,
Mar 23 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by caseq@chromium.org
, Mar 17 2016Components: -Platform>DevTools Platform>DevTools>UX Platform>DevTools>HTML
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)