Specs for buttons: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_buttons.png%3Fz=width&fr=0&c=show

Specs for dialogs: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_dialogs.png%3Fz=width&fr=0&c=show

Setting default priority/type

Setting default priority/type

Are these dialogs still in progress? 

Deleted: Screen Shot 2016-03-29 at 3.28.05 PM.png 71.8 KB

	Screen Shot 2016-03-29 at 3.28.05 PM.png 71.8 KB View Download

I'll pick up the remaining work to make the <settings-dialog> conform to the spec.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5cee3f2dc56e81cef3a02e673114db58131370

commit 0c5cee3f2dc56e81cef3a02e673114db58131370
Author: dpapad <dpapad@chromium.org>
Date: Mon Apr 18 20:17:01 2016

MD Settings: Bring <settings-dialog> closer to dialog spec.

BUG= 595804 

Review URL: https://codereview.chromium.org/1893663003

Cr-Commit-Position: refs/heads/master@{#387998}

[modify] https://crrev.com/0c5cee3f2dc56e81cef3a02e673114db58131370/chrome/browser/resources/settings/settings_dialog.html
[modify] https://crrev.com/0c5cee3f2dc56e81cef3a02e673114db58131370/chrome/browser/resources/settings/settings_shared_css.html

@bettes: The dialogs are much closer to the spec now. There are some issues that I was not able to address

1) diameter of ripple effect on the 'x' button. Polymer does not seem to expose this for customization.
2) In the mocks there is an example of overflowing content with a custom looking scrollbar, not sure if this is intentional. Current implementation uses native scrollbars instead.
3) Overflow behavior in general. In the mocks, the buttons are always visible and the content above the buttons is scrolled. Implementation currently scrolls the contents of the entire dialog (including the title and the buttons).

Looking a lot better. Thanks for the update. 

1.) I don't think that's true. Check the "x-to-close" on the downloads page. 
2.) Native scrollbars is fine. Those mocks are meant to reflect an updated native scrollbar but we haven't gotten there yet. 
3.) What's an example of this? I can't find any.

Just reviewed your implementation on mac and cros. Quite a few discrepancies still:

Typography
- header text should be 16px
- content area text should be 13px
- paper-item in paper-dropdown-menu should be 13px 

Buttons
- button text should be 13px
- button height should be 32px. 
- button tray's left & right padding incorrect (16px not 24px) 

Container
- dialogs should have a 2px corner radius.

Most of the discrepancies you are mentioning do not reproduce on my Linux, which is odd. I'll try again on my Mac and update this bug. Are you using Chrome Canary version?

Regarding an example of a scrolling dialog, you can trigger this with any dialog if you make the height of the window too small. I also attached a screenshot.

Deleted: scroll_dialog.png 239 KB

	scroll_dialog.png 239 KB View Download

Yes. Same discrepancies are on my Cros machine v52.0.2715

@bettes: Can you paste a screenshot of the CSS inspector for the font size of the header text? In my case it is 15.9992px (as close as possible to 16px), see screenshot (on the right).

Deleted: font-size.png 225 KB

	font-size.png 225 KB View Download

Re: scrolling
I see now. That's not what we want just for the record. 

Actually, you're correct - I see the same. I was looking at the highlighted CSS in the attachment, which is inherited from what? 

It is inherited via multiple layers of CSS mixins, and eventually from https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polymer/v1_0/components-chromium/paper-styles/typography.html&l=116. It does, not really matter though, because we override that value by multiplying with 114.28% to get from 14px to the desired 16px.

Okay, good to know. I do believe the other text-size discrepancies hold true still. Let me know otherwise

Deleted: Screen Shot 2016-04-25 at 6.16.16 PM.png 345 KB

	Screen Shot 2016-04-25 at 6.16.16 PM.png 345 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca59f87d882632c9bb47acb15fcbc3d337f8282

commit 3ca59f87d882632c9bb47acb15fcbc3d337f8282
Author: dpapad <dpapad@chromium.org>
Date: Tue Apr 26 22:33:22 2016

More <settings-dialog> tweaks to match the spec.

 - Change dialog body and buttons font to 13px.
 - Change button container padding from 24px to 16px.
 - Add 2px border radius around dialog.

BUG= 595804 

Review URL: https://codereview.chromium.org/1921823005

Cr-Commit-Position: refs/heads/master@{#389918}

[modify] https://crrev.com/3ca59f87d882632c9bb47acb15fcbc3d337f8282/chrome/browser/resources/settings/settings_dialog.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c033875a2909ea96f107244452ba3a77f77825

commit 69c033875a2909ea96f107244452ba3a77f77825
Author: dbeam <dbeam@chromium.org>
Date: Tue May 24 19:07:23 2016

MD Settings: make bluetooth add device dialog prettier

Remove some artifacts from when it implemented
<settings-dialog>-esque style itself.

R=stevenjb@chromium.org
BUG= 595804 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2002363002
Cr-Commit-Position: refs/heads/master@{#395665}

[modify] https://crrev.com/69c033875a2909ea96f107244452ba3a77f77825/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0726838693d45b022178e8ddaea8120364ea876d

commit 0726838693d45b022178e8ddaea8120364ea876d
Author: dbeam <dbeam@chromium.org>
Date: Wed May 25 06:16:47 2016

MD Settings: fix overflow scrolling for <settings-dialog>

Currently the whole dialog scrolls if there's too much middle content.
We really just want a scrollbar between the title and the buttons.

BUG= 595804 
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1974193002
Cr-Commit-Position: refs/heads/master@{#395813}

[modify] https://crrev.com/0726838693d45b022178e8ddaea8120364ea876d/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/0726838693d45b022178e8ddaea8120364ea876d/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/0726838693d45b022178e8ddaea8120364ea876d/chrome/browser/resources/settings/settings_dialog.html
[modify] https://crrev.com/0726838693d45b022178e8ddaea8120364ea876d/chrome/browser/resources/settings/settings_dialog.js

with [1], here's a screenshot.

bettes@: purdy 'nuff?

[1] https://codereview.chromium.org/2009383003/

Deleted: 2016-05-25-143924_577x484_scrot.png 33.3 KB

	2016-05-25-143924_577x484_scrot.png 33.3 KB View Download

whooops

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8aadddb9e4b863f28c9d417310eb24eb716d48

commit 8a8aadddb9e4b863f28c9d417310eb24eb716d48
Author: dbeam <dbeam@chromium.org>
Date: Wed May 25 23:52:22 2016

MD Settings: fix settings-dialog (X) close button styles to match spec

BUG= 595804 
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2009383003
Cr-Commit-Position: refs/heads/master@{#396045}

[modify] https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48/chrome/browser/resources/settings/settings_dialog.html

It's purdy!

@dbeam: According to https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c10 the button height should be 32px. I had not fixed this initially because I was hitting https://github.com/PolymerElements/paper-button/issues/113, which was later fixed by https://github.com/PolymerElements/paper-button/commit/dddb83469d381df84766b05af56720b0b53e7cbd. Not sure if you addressed this already. If not, latest paper-button version should have the fix, so we could easily adjust the height to conform to the spec after a polymer roll.

Unassigning myself as an owner, since I am not actively working on this.
@dbeam: Do you know the status of this issue?

i think the only thing left is borders on the dialog contents when there's overflow (or maybe only when scrolling?).  see: paper-dialog-scrollable

@dbeam: Is  crbug.com/621659  addressing what you are referring to at comment #29? If so, let's connect those bugs.

 Issue 621659  has been merged into this issue.

I attempted to land a CL for this before the M58 branch-cut (https://codereview.chromium.org/2702523005/), and we decided to hold off on this because there were debates on whether or not having a bottom border is intuitive/meaningful enough of an indicator. Some alternatives that were brought up were inner-shadow or inner-fade-gradient.

If dbeam@ or bettes@ could chime in with a final call, I could pick up my CL again and try to land it.

Also just to double check, the dialogs that this bug still applies to I can find are:
- Clear Browsing Data (currently it has a permanent bottom-border, which is incorrect)
- Language -> Add language
- Autofill -> Add Address (on a small viewport)

Are there any potentially scrollable dialog that I missed?

The same approach I tried at https://bugs.chromium.org/p/chromium/issues/detail?id=699302&desc=2#c5, might be useful here. Will give it a shot and report back.

Re #38, the bottom border is the standard way in Material Design to indicate that more scrollable content is available: https://material.googleplex.com/components/dialogs.html#dialogs-specs

We should use the common pattern unless there is a very strong reason to diverge.