New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

FileSystemDirURLRequestJobTest.DirectoryListing crashes on drmemory bot

Project Member Reported by osh...@chromium.org, Mar 17 2016

Issue description

one of tests that started failing after VS2015 switch.
I'll exclude it.
 

Comment 1 by osh...@chromium.org, Mar 17 2016

Summary: FileSystemDirURLRequestJobTest.DirectoryListing crashes on drmemory bot (was: FileSystemDirURLRequestJobTest.DirectoryListing timeout on drmemory bot)
It's actually crashing

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/9871/steps/memory%20test%3A%20content/logs/stdio

[----------] 9 tests from FileSystemDirURLRequestJobTest
[ RUN      ] FileSystemDirURLRequestJobTest.DirectoryListing
<Application E:\b\build\slave\chromium-dbg-win-drmemory-full-3\build\src\out\Release\content_unittests.exe (984).  Dr. Memory internal crash at PC 0x65eadb63.  Please report this at http://drmemory.org/issues.  Program aborted.
0xc0000005 0x00000000 0x65eadb63 0x65eadb63 0x00000001 0x00000000
Base: 0x65e20000
Registers: eax=0x65f046e8 ebx=0x00000000 ecx=0x00000075 edx=0x00000000
	esi=0x2cd52988 edi=0x2cd52988 esp=0x1e46edb4 ebp=0x00000000
	eflags=0x000
1.10.0-2-(Mar  7 2016 23:05:56) win61

Comment 2 by jsb...@chromium.org, Mar 18 2016

Components: -Blink>FileAPI Blink>Storage>FileSystem

Comment 3 by osh...@chromium.org, Mar 18 2016

Cc: bruening@chromium.org brucedaw...@chromium.org
I filed a bug:

https://github.com/DynamoRIO/drmemory/issues/1870
Cc: sh...@chromium.org
 Issue 595490  has been merged into this issue.
Cc: thestig@chromium.org zhaoqin@chromium.org reillyg@chromium.org
 Issue 594808  has been merged into this issue.
Owner: bruening@chromium.org
I have a local fix for this and will update the Cr bits soon.
Cc: mmenke@chromium.org eroman@chromium.org
 Issue 594614  has been merged into this issue.
Cc: michaeln@chromium.org
 Issue 594785  has been merged into this issue.
Cc: mkwst@chromium.org
 Issue 594618  has been merged into this issue.
Status: Fixed (was: Assigned)
Cc: jrumm...@chromium.org xhw...@chromium.org ddorwin@chromium.org
 Issue 595156  has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa7a7747d6f9cb16cda4e8caf946ef2e26cc894b

commit fa7a7747d6f9cb16cda4e8caf946ef2e26cc894b
Author: bruening <bruening@chromium.org>
Date: Sun Mar 20 20:23:02 2016

Remove unused VS2015 realloc heap mismatch suppression.

The suppression was never hit on the bots, and I cannot reproduce it
locally even running Dr. Memory builds prior to the several VS2015 fixes.
If with the latest Dr. Memory it happens again in some environments, we
would prefer to address it at the Dr. Memory level rather than with a
Chromium suppression as it is general enough to affect external users.

BUG= 595792 
TBR=brucedawson@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1819753002

Cr-Commit-Position: refs/heads/master@{#382226}

[modify] https://crrev.com/fa7a7747d6f9cb16cda4e8caf946ef2e26cc894b/tools/valgrind/drmemory/suppressions.txt

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b119c2386ef476253fca400e865c4813aa0139

commit 81b119c2386ef476253fca400e865c4813aa0139
Author: bruening <bruening@chromium.org>
Date: Sun Mar 20 20:25:44 2016

Remove Dr. Memory suppression that is no longer needed.

We strongly suspect that this handle leak is caused by the  issue 595792 
crash and that the suppression is not needed.

BUG= 595156 , 595792 
TBR=oshima
NOTRY=true

Review URL: https://codereview.chromium.org/1821503002

Cr-Commit-Position: refs/heads/master@{#382230}

[modify] https://crrev.com/81b119c2386ef476253fca400e865c4813aa0139/tools/valgrind/drmemory/suppressions_full.txt

Sign in to add a comment