Missing entrypoint for restart. http://i.imgur.com/pilBe6i.png
this is already kind of what I was thinking of...
(also, not sure whether we should have lines inbetween the checkboxes, but that was just a local change I was making for technical reasons)
Issue 595908 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec8672509fbf27ad2aa14dbc83f0512cff34677 commit dec8672509fbf27ad2aa14dbc83f0512cff34677 Author: dbeam <dbeam@chromium.org> Date: Tue Mar 22 19:33:55 2016 MD Settings: implement "RESTART" button for hardware acceleration to take effect R=dpapad@chromium.org BUG= 595779 Review URL: https://codereview.chromium.org/1814703004 Cr-Commit-Position: refs/heads/master@{#382637} [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/app/settings_strings.grdp [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/metrics/chrome_metrics_service_accessor.h [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/advanced_page/advanced_page.html [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/advanced_page/advanced_page.js [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/system_page/compiled_resources2.gyp [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/system_page/system_page.html [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/system_page/system_page.js [add] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/system_page/system_page_browser_proxy.html [add] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/resources/settings/system_page/system_page_browser_proxy.js [delete] https://crrev.com/f4e57485631dc4c3beaa87de398975cab87fdc32/chrome/browser/resources/settings/system_page/system_page_delegate.html [delete] https://crrev.com/f4e57485631dc4c3beaa87de398975cab87fdc32/chrome/browser/resources/settings/system_page/system_page_delegate.js [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/ui/webui/settings/system_handler.cc [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/browser/ui/webui/settings/system_handler.h [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/test/data/webui/settings/cr_settings_browsertest.js [add] https://crrev.com/dec8672509fbf27ad2aa14dbc83f0512cff34677/chrome/test/data/webui/settings/system_page_tests.js
Setting default priority/type
fyi: this is what's currently implemented; i used existing paradigms. purdy enough?
Nice! Almost there :). You're missing the separator. Look to the dan's work on the people card, with the sign in / sign out button Updated mocks https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-System.png%3Fz=width
I revoke that comment in #12. Let's remove vertical separators for single line rows. SPEC https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_buttons.png%3Fz=width
Single-line rows only. Double-line rows (like people) should still be treated with a vertical spacing
great, then the current implementation matches already (w00t!)
Comment 1 by bettes@chromium.org
, Mar 17 2016