Setting default priority/type

Setting default priority/type

I took a pass at resolving this issue, by placing the IMPORT button at the sub-page header level. 

The button should follow the same spec for all dual action rows (separator + flat grey button) 

Mocks
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Privacy_Security_certificates.png%3Fz=width

Privacy specific spec
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-cards_privacy.png%3Fz=width

Deleted: Screen Shot 2016-03-25 at 6.16.40 PM.png 80.7 KB

	Screen Shot 2016-03-25 at 6.16.40 PM.png 80.7 KB View Download

Adding a button to the title row seems a little strange to me. Also, if it belongs to the tab instead of the whole sub-page as you said in #0 then it seems out-of-place there. Though it's tough to find an alternative given how much is going on in this screen. A couple options that come to mind:

Is the divider between "Global Trustee" and "Google Ltd." necessary, or could it at least not be fullbleed? If you can remove/change that, you could put a fullbleed divider after "Google Ltd." and make "Import" a normal action below it.

Alternatively, I feel like the tabs are a bit difficult to recognize here unless you're familiar with the old certificate manager UI. Would their purpose be clearer if you put the tabs into a dropdown, eg. "Show only [Your certificates]"? Then maybe an import button could go on the same line or right below it.

On second glance, I think you're probably right: the position of IMPORT should be below the tabs. I'll revisit this shortly. 

Let me think about the structure change to dropdown. It's interesting but I hesitate to move away from the tabbing structure though - i suspect the majority of people using this UI are people who are familiar with the old certificate manager UI. 

Also changing the structure from tabs to a dropdown is going to require more work, just noting this, to take into account before making a final decision.

depending on usage, maybe we could move the "IMPORT CERTIFICATES" to a button in the /section/ rather than the dialog?

Let's try coupling the action with the descriptor text first, before considering anything more drastic. Works rather nicely in empty states as well. See attachment. 

Page-specific spec
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-cards_privacy.png%3Fz=width

Mocks
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Privacy_Security_certificates.png%3Fz=width

Deleted: Screen Shot 2016-03-28 at 12.32.33 PM.png 90.2 KB

	Screen Shot 2016-03-28 at 12.32.33 PM.png 90.2 KB View Download

@bettes: Previous mocks had removed the text "You have certificates on file that identify those servers", so I removed this text and similar descriptions for the other certificate tabs, see CL at [1], and attached screenshot.

Could you verify that those strings are intentionally back, before I re-add them? Also if that is the case, are those strings identical to the Options UI?

[1] https://codereview.chromium.org/1819563002/diff/180001/chrome/app/settings_strings.grdp

Deleted: certificate_list_collapsed.png 111 KB

	certificate_list_collapsed.png 111 KB View Download

The removal of the text was not intentional. We should keep it for now. 

Does each authority certificate really have it's own expand-more icon?? What's underneath that? 

Also, note the 24px padding between tabs and content. See attached 

Deleted: Screen Shot 2016-03-30 at 5.17.29 PM.png 14.5 KB

	Screen Shot 2016-03-30 at 5.17.29 PM.png 14.5 KB View Download

Each certificate authority has many certificates (this is similar for all other tabs), see screenshot where I expanded a few of them.

Deleted: certificates_expanded.png 109 KB

	certificates_expanded.png 109 KB View Download

Cool. Looks like it's working pretty well for the most part. Two things I see in your screenshot: 

1. The last row in any list shouldn't have a rule line appended to it. Right now you have two rule lines stacked on top of each other. See attachment
2. The focus tab color should be Google Blue 500 

Thanks

Deleted: Screen Shot 2016-04-01 at 11.06.58 AM.png 50.6 KB

	Screen Shot 2016-04-01 at 11.06.58 AM.png 50.6 KB View Download

No2 is already being fixed by https://codereview.chromium.org/1842403004 (see before/after at https://imgur.com/a/4tLcm). I will address no1 in a separate CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0b9741782d2e63238afb2c740d35898fd4e7710

commit d0b9741782d2e63238afb2c740d35898fd4e7710
Author: dpapad <dpapad@chromium.org>
Date: Mon Apr 04 18:41:02 2016

MD Settings: Certificate manager, move "Import" button to the tab level.

BUG= 595768 

Review URL: https://codereview.chromium.org/1842403004

Cr-Commit-Position: refs/heads/master@{#384963}

[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_list.html
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_list.js
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/chrome/test/data/webui/settings/certificate_manager_page_test.js
[modify] https://crrev.com/d0b9741782d2e63238afb2c740d35898fd4e7710/ui/webui/resources/js/i18n_behavior.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9385c702c38d0150f843b7ed3403d9458d3b51dd

commit 9385c702c38d0150f843b7ed3403d9458d3b51dd
Author: dpapad <dpapad@chromium.org>
Date: Tue Apr 05 02:21:21 2016

MD Settings: Certificate manager, remove border from last certificate entry.

BUG= 595768 

Review URL: https://codereview.chromium.org/1856923002

Cr-Commit-Position: refs/heads/master@{#385089}

[modify] https://crrev.com/9385c702c38d0150f843b7ed3403d9458d3b51dd/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
[modify] https://crrev.com/9385c702c38d0150f843b7ed3403d9458d3b51dd/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.js
[modify] https://crrev.com/9385c702c38d0150f843b7ed3403d9458d3b51dd/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html