Issue 595734 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Mar 2016
Cc:	ma...@chromium.org
Components:	UI>Browser>Autofill
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

[Autofill] Check for full state name and abbreviation when determining types to upload.

Project Member Reported by se...@chromium.org, Mar 17 2016

Issue description

This logic was already implemented to limit profile duplication but it should be used for upload types too. 

For example a profile with the state "Tennessee" is used to fill a form with a select field containing state abbreviations. The fill will work, no duplicate profile will be created but we will not upload a vote for ADDRESS_HOME_STATE for the field.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb6aef375788d86e59a67dea2a8b50f3b61e49b

commit bcb6aef375788d86e59a67dea2a8b50f3b61e49b
Author: sebsg <sebsg@chromium.org>
Date: Fri Mar 18 15:26:35 2016

Added code to try getting the full text value and abbreviation of a possible state and compare these values to the saved profile's state value.

BUG= 595734 
TEST=AutofillManagerTest

Review URL: https://codereview.chromium.org/1814883002

Cr-Commit-Position: refs/heads/master@{#381973}

[modify] https://crrev.com/bcb6aef375788d86e59a67dea2a8b50f3b61e49b/components/autofill/core/browser/address.cc
[modify] https://crrev.com/bcb6aef375788d86e59a67dea2a8b50f3b61e49b/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/bcb6aef375788d86e59a67dea2a8b50f3b61e49b/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/bcb6aef375788d86e59a67dea2a8b50f3b61e49b/components/autofill/core/browser/autofill_profile.cc

Comment 2 by se...@chromium.org, Mar 18 2016

Status: Fixed (was: Started)

►

Issue 595734 link

Issue metadata

[Autofill] Check for full state name and abbreviation when determining types to upload.

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 18 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Mar 18 2016

Comment 2 Deleted

Sign in to add a comment