New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595726 link

Starred by 0 users

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Power metric error messages (non-failing) on Mac HDD Perf (5) bot

Project Member Reported by petrcermak@chromium.org, Mar 17 2016

Issue description

Example (https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%285%29/builds/1033/steps/page_cycler_site_isolation.basic_oopif/logs/stdio):
[ RUN      ] http://www.ebay.com
(INFO) 2016-03-17 04:02:18,800 power._StopInternal:48  Attempting to stop non-running monitor
(INFO) 2016-03-17 04:02:19,568 power.Start:93  Start: PowerMetric running
(INFO) 2016-03-17 04:02:22,231 power._StopInternal:51  StopInternal: PowerMetric running
(WARNING) 2016-03-17 04:02:22,231 powermetrics_power_monitor._KillPowerMetricsProcess:248  Error when trying to terminate powermetric process: OSError(1, 'Operation not permitted')
(INFO) 2016-03-17 04:02:22,436 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'c_state_ratio']
(INFO) 2016-03-17 04:02:22,439 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'cores', 0, 'c_state_ratio']
(INFO) 2016-03-17 04:02:22,439 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'cores', 1, 'c_state_ratio']
(INFO) 2016-03-17 04:02:23,661 power.Close:104  Closing power monitors
(INFO) 2016-03-17 04:02:23,662 platform.IsMonitoringPower:299  IsMonitoringPower: False
[       OK ] http://www.ebay.com (6319 ms)

The errors don't seem to be causing any test failures (the failure in the above example is most likely due to a timeout). Nevertheless, I think that someone should look into this.

nednguyen: I don't know who's the owner of the metric, could you please route it to the right person? Thanks!
 
Owner: rnep...@chromium.org
Randy: this may be caused by your work of refactoring the power monitoring. Can you look into this?
Cc: alexandermont@chromium.org
Since this is just impacting powermetrics_power_monitor, I dont know if its related to my work since if it causes problems here it would be likely to cause problems on other platforms as well. When did this start? Adding Alex since he did some refactoring to this power monitor.

Here are the last few changes to powermetric_power_monitor:

commit de5801005e1a5dd22d113167d2bed3e88867858f
Author: qyearsley <qyearsley@chromium.org>
Date:   Wed Dec 16 19:52:55 2015 -0800

    Run codespell on src/tools/telemetry.
    
    Review URL: https://codereview.chromium.org/1533523004
    
    Cr-Commit-Position: refs/heads/master@{#365729}

commit c6acaa07f5ee4c0e76ec4eedff74c24d591dfb75
Author: alexandermont <alexandermont@chromium.org>
Date:   Mon Nov 16 18:25:32 2015 -0800

    code cleanup for power monitoring
    
    resubmit to fix bug with previous cl
    
    BUG= 556653 
    
    Review URL: https://codereview.chromium.org/1445203003
    
    Cr-Commit-Position: refs/heads/master@{#359977}

commit bfe7c3b365ac8dc739aef8b54ab3f6f54e6a9491
Author: nednguyen <nednguyen@google.com>
Date:   Mon Nov 16 13:21:18 2015 -0800

    Revert of Improve readability of power monitoring code and add additional (patchset #7 id:120001 of https://codereview.chromium.org/1432093002/ )
    
    Reason for revert:
    Speculative revert since this may break page_cycler.typical_25
    
    BUG= 556653 
    
    Original issue's description:
    > Improve readability of power monitoring code and add additional
    > logging and validation.
    >
    > Committed: https://crrev.com/adce66abd74fb2d6e22da36eee85b7e324f962ba
    > Cr-Commit-Position: refs/heads/master@{#359640}
    
    TBR=mikecase@chromium.org,rnephew@google.com,rnephew@chromium.org,alexandermont@chromium.org
    
    Review URL: https://codereview.chromium.org/1452753002
    
    Cr-Commit-Position: refs/heads/master@{#359920}

commit 3d9d3f6cfbae798760aa6146fd98886ed213c593
Author: alexandermont <alexandermont@chromium.org>
Date:   Fri Nov 13 13:14:10 2015 -0800

    Improve readability of power monitoring code and add additional
    logging and validation.
    
    Review URL: https://codereview.chromium.org/1432093002
    
    Cr-Commit-Position: refs/heads/master@{#359640}

Cc: dtu@chromium.org rnep...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Summary: Power metric error messages (non-failing) on Mac HDD Perf (5) bot (was: Power metric errors failing on Mac HDD Perf (5) bot)
This is still happening on the latest builds:

Latest builds: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%285%29

Excerpt from https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%285%29/builds/1468/steps/page_cycler_site_isolation.basic_oopif/logs/stdio:
[ RUN      ] http://www.nationalgeographic.com/
(INFO) 2016-05-05 10:22:13,635 power._StopInternal:48  Attempting to stop non-running monitor
(INFO) 2016-05-05 10:22:14,093 power.Start:93  Start: PowerMetric running
(INFO) 2016-05-05 10:22:19,331 power._StopInternal:51  StopInternal: PowerMetric running
(WARNING) 2016-05-05 10:22:19,332 powermetrics_power_monitor._KillPowerMetricsProcess:248  Error when trying to terminate powermetric process: OSError(1, 'Operation not permitted')
(INFO) 2016-05-05 10:22:19,507 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'c_state_ratio']
(INFO) 2016-05-05 10:22:19,508 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'cores', 0, 'c_state_ratio']
(INFO) 2016-05-05 10:22:19,508 powermetrics_power_monitor.ParsePowerMetricsOutput:202  Field missing from powermetrics output: ['processor', 'packages', 0, 'cores', 1, 'c_state_ratio']
(INFO) 2016-05-05 10:22:21,254 power.Close:104  Closing power monitors
(INFO) 2016-05-05 10:22:21,254 platform.IsMonitoringPower:299  IsMonitoringPower: False
[       OK ] http://www.nationalgeographic.com/ (8128 ms)

The line where that error is printed from was last changed in https://codereview.chromium.org/1419743003.

Dave, do you know what that message might mean in this place, and whether it's a problem?
Labels: Performance-Sheriff-BotHealth
Cc: -petrcermak@chromium.org
Cc: -petrcermak@chromium.org

Comment 7 by benhenry@google.com, Dec 21 2016

Labels: -Performance-BotHealth
Status: Archived (was: Available)

Sign in to add a comment