[tracking bug] Add tests for NTPSnippetsService |
||||||||||
Issue descriptionNTPSnippetsService has become severely under-tested.
,
Apr 1 2016
Aand once more.
,
Apr 8 2016
^^
,
Apr 8 2016
lol ... this is called test-driven development, isn't it? ;-)
,
Apr 12 2016
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57b24841e5cbbd98566f5cb323bd0963d1c81d25 commit 57b24841e5cbbd98566f5cb323bd0963d1c81d25 Author: treib <treib@chromium.org> Date: Tue Apr 12 16:08:48 2016 [NTP Snippets] Clean up NTPSnippetsServiceTests BUG= 595723 Review URL: https://codereview.chromium.org/1878993002 Cr-Commit-Position: refs/heads/master@{#386703} [modify] https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25/components/ntp_snippets/ntp_snippet.cc [modify] https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25/components/ntp_snippets/ntp_snippet.h [modify] https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25/components/ntp_snippets/ntp_snippets_service_unittest.cc
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b37b6ff6a3564ae0702a7afce6c0d699a03d456a commit b37b6ff6a3564ae0702a7afce6c0d699a03d456a Author: treib <treib@chromium.org> Date: Thu Apr 14 10:54:05 2016 [NTP Snippets] Add tests for invalid or incomplete json BUG= 595723 Review URL: https://codereview.chromium.org/1889783002 Cr-Commit-Position: refs/heads/master@{#387279} [modify] https://crrev.com/b37b6ff6a3564ae0702a7afce6c0d699a03d456a/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/b37b6ff6a3564ae0702a7afce6c0d699a03d456a/components/ntp_snippets/ntp_snippets_service_unittest.cc
,
Apr 14 2016
First tests landed, more coming next week.
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c0086b4a519d448e269ec3d558aacf4e2e86156 commit 5c0086b4a519d448e269ec3d558aacf4e2e86156 Author: treib <treib@chromium.org> Date: Wed Apr 20 12:43:51 2016 [NTP Snippets] Add tests for scheduling/unscheduling BUG= 595723 Review URL: https://codereview.chromium.org/1896423002 Cr-Commit-Position: refs/heads/master@{#388475} [modify] https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156/components/ntp_snippets/ntp_snippets_service_unittest.cc
,
Apr 21 2016
One more tests CL landed this week. At that rate, this is going to take a while...
,
Apr 28 2016
I'm closing this bug now. All the new stuff we added recently got new tests immediately, so the overall state isn't quite as bad anymore.
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by treib@chromium.org
, Mar 24 2016