New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595721 link

Starred by 3 users
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
█ vollick@chromium.org
penghuang@chromium.org
█ markdittmer@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
piman@chromium.org
█ siev...@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
mus

Blocking:
issue 586365



Sign in to add a comment

Move gpu_messages.h => gpu/ipc/common

Project Member Reported by fsam...@chromium.org, Mar 17 2016 
I'm going to try to do this in a few patches, rather than one large patch to make them easier to land and stick.

Roughly (these may be merged into fewer CLs if they turn out simple enough),

1. Move content/common/gpu/gpu_memory_uma_stats.h to gpu/ipc/common/gpu_memory_uma_stats.h

2. Move content/common/gpu/gpu_process_launch_cases.h => gpu/ipc/common. I'd like to make this an enum class along the way.

3. Move content/common/gpu/gpu_stream_constants.h => gpu/ipc/common

4. Move content/common/gpu/gpu_param_traits* => gpu/ipc/common

5. Move content/common/gpu/gpu_messages.h => gpu/ipc/common

Comment 1 by fsam...@chromium.org, Mar 17 2016

Owner: fsam...@chromium.org
Status: Started (was: Untriaged)

Comment 2 by fsam...@chromium.org, Mar 17 2016

Blocking: 586365

Comment 3 by fsam...@chromium.org, Mar 19 2016 

Looks like I am doing it in one patch after all. It didn't turn out too bad.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19acfae06352bab6abff2ff7d13456e02be0b7ad

commit 19acfae06352bab6abff2ff7d13456e02be0b7ad
Author: fsamuel <fsamuel@chromium.org>
Date: Tue Mar 22 05:38:24 2016

gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we
cannot link skia into NaCl and so I split up gpu/ipc/common
into two source_sets in GN and two gypis on GYP:
command_buffer_traits and ipc_common_sources (GN) /
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG= 595721 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1809183002

Cr-Commit-Position: refs/heads/master@{#382514}

[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/components/mus/common/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/components/mus/public/interfaces/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/child_process_messages.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/content_message_generator.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/child_window_surface_win.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/child_window_surface_win.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/client/gpu_channel_host.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/client/gpu_channel_host.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/gpu_channel.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/gpu_channel.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/gpu_channel_manager.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/gpu_channel_unittest.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/gpu_command_buffer_stub.cc
[delete] https://crrev.com/b6bdb502908d2cc5ee9b9142b955e9e39e3f3870/content/common/gpu/gpu_param_traits.cc
[delete] https://crrev.com/b6bdb502908d2cc5ee9b9142b955e9e39e3f3870/content/common/gpu/gpu_param_traits.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/common/gpu/stream_texture_android.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/content_common.gypi
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/gpu/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/gpu/gpu_host_messages.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/renderer/gpu/stream_texture_host_android.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/content/renderer/media/android/stream_texture_factory_impl.cc
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/command_buffer/common/BUILD.gn
[add] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/command_buffer_traits.gypi
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/gpu.gyp
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/gpu_ipc_common.gypi
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/gpu_nacl.gyp
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/DEPS
[add] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_message_generator.cc
[add] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_message_generator.h
[rename] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_messages.h
[add] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_param_traits.cc
[add] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_param_traits.h
[rename] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_param_traits_macros.h
[rename] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/gpu_stream_constants.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/gpu/ipc/common/surface_handle.h
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/ppapi/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/ppapi/native_client/BUILD.gn
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/ppapi/ppapi_internal.gyp
[modify] https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad/ppapi/proxy/BUILD.gn

Comment 5 by fsam...@chromium.org, Mar 23 2016 

I'll leave this open for another day or two to make sure it sticks then I'll mark it as FIXED.

Comment 6 by fsam...@chromium.org, Mar 24 2016

Status: Fixed (was: Started)
I have a fair degree of confidence at this point that this will stick. I'm marking this as FIXED.
►

Sign in to add a comment