New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595715 link

Starred by 4 users
Status: Fixed
Owner:
█ pgeorgi@chromium.org
Last visit 26 days ago
Closed: Jan 2017
Cc:
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 630451



Sign in to add a comment

The cros firmware build does way too much and can be stripped down

Project Member Reported by pgeorgi@chromium.org, Mar 17 2016 
We have lots of toggles and build steps in ToT for image types that we don't build anymore.

This is a tracking bug for cleanups related to this area: Removing options (eg. non-unified depthcharge builds) and build steps (eg. slicing and reassembling a perfectly fine image into an image that looks just the same).

The goal is to make the build process easier to follow, so we don't get support inquiries from inside and outside the team because somebody somwhere ran into an obscure feature and broke their build.
Showing comments 103 - 202 of 202 Older ›
Project Member

Comment 103 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/35147f624e37d6c80c0fe70c09d539d264842752

commit 35147f624e37d6c80c0fe70c09d539d264842752
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 16:08:22 2016

cros_bundle_firmware: Add fwid strings to cb_copy

BUG= chromium:595715 
BRANCH=none
TEST=verify bit-equivalence of regions between image.bin and cb_with_fmap
with CL:397219 or similar.

Change-Id: Id635f96e94e14d743c608a9bd9a091aed6aff428
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397358
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/35147f624e37d6c80c0fe70c09d539d264842752/host/lib/bundle_firmware.py
Project Member

Comment 104 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/250ecd4bf96ae33704edb738ab767ab3cf00c47b

commit 250ecd4bf96ae33704edb738ab767ab3cf00c47b
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 16:22:50 2016

cros_bundle_firmware: Add correct GBB to cb_copy

BUG= chromium:595715 
BRANCH=none
TEST=verify bit-equivalence of regions between image.bin and cb_with_fmap
with CL:397219 or similar.

Change-Id: I6aa5bbbf09957d219eaceb9c920a879223ca30ae
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397359
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/250ecd4bf96ae33704edb738ab767ab3cf00c47b/host/lib/bundle_firmware.py
Project Member

Comment 105 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/2fc662e72fdb568e7d57efcd4ae7d12c3791813c

commit 2fc662e72fdb568e7d57efcd4ae7d12c3791813c
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 17:28:53 2016

cros_bundle_firmware: Add files in cbfs/ and rocbfs/ in one go.

That copy doesn't happen anymore (because RW is legitimately different
from RO now), so we don't need to be careful about the order of the
step.
On the upside, cb_with_fmap is much more similar to image.bin now.

BUG= chromium:595715 
BRANCH=none
TEST=built and made sure that FW_MAIN_[AB] don't contain the RO-only
files.

Change-Id: I3e47647f3a779c1180f15a9c6b3d2ca038b1e25f
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397279
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/2fc662e72fdb568e7d57efcd4ae7d12c3791813c/host/lib/bundle_firmware.py
Project Member

Comment 106 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/e5fec8c5bfc9e008c053dc56c4b104b88b1c1d9c

commit e5fec8c5bfc9e008c053dc56c4b104b88b1c1d9c
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 17:36:09 2016

cros_bundle_firmware: Fix the (unused) addition of files to RO and RW

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I3010600bc41169efff0cb91586c1328e8891f7c1
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397280
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/e5fec8c5bfc9e008c053dc56c4b104b88b1c1d9c/host/lib/bundle_firmware.py
Project Member

Comment 107 by bugdroid1@chromium.org, Nov 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/f84fb8e7a0de0edc20a0789c13b76e7086ef6a24

commit f84fb8e7a0de0edc20a0789c13b76e7086ef6a24
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 18:49:31 2016

cros_bundle_firmware: Setup fdt configuration values earlier

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I61d07d13752019288862670416b961a73028ee54
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397618
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Martin Roth <martinroth@chromium.org>

[modify] https://crrev.com/f84fb8e7a0de0edc20a0789c13b76e7086ef6a24/host/lib/bundle_firmware.py
Project Member

Comment 108 by bugdroid1@chromium.org, Nov 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/8a4d3ff6a11c3e9ea4e1e2c1c2e09a4226c1d8ef

commit 8a4d3ff6a11c3e9ea4e1e2c1c2e09a4226c1d8ef
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 18:52:42 2016

cros_bundle_firmware: Move uboot handling code closer together

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I0c4321473bba06319a4553f8fb168ef04e7902a0
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397619
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/8a4d3ff6a11c3e9ea4e1e2c1c2e09a4226c1d8ef/host/lib/bundle_firmware.py
Project Member

Comment 109 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/b6aab393c80096e2745af015ac0285a4b5cc6821

commit b6aab393c80096e2745af015ac0285a4b5cc6821
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 19:00:23 2016

cros_bundle_firmware: Don't rework the dtb for with_index'd regions

We don't have them anymore.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I587ea521a2b77dba0f07542306594b538c33da8b
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397620
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/b6aab393c80096e2745af015ac0285a4b5cc6821/host/lib/bundle_firmware.py
[modify] https://crrev.com/b6aab393c80096e2745af015ac0285a4b5cc6821/host/lib/pack_firmware.py
Project Member

Comment 110 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/8e17d3abd3c0dd0764748f742475c37fe26149cd

commit 8e17d3abd3c0dd0764748f742475c37fe26149cd
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 19:11:25 2016

cros_bundle_firmware: Move adding the payload earlier

That way it's also in cb_with_fmap.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: Ic4aeef1a8085dc0461884d4f66cd9bf67629f143
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397621
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/8e17d3abd3c0dd0764748f742475c37fe26149cd/host/lib/bundle_firmware.py
Project Member

Comment 111 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/232c2b7a0593cff88c5430ae76d7d374bd311280

commit 232c2b7a0593cff88c5430ae76d7d374bd311280
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 19:46:54 2016

cros_bundle_firmware: zero out unused space in RW sections pre-signing

This mirrors the current behavior for the cb_with_fmap file, leading to
identical content.

BUG= chromium:595715 
BRANCH=none
TEST=verify bit-equivalence of regions between image.bin and cb_with_fmap
with CL:397219 or similar.

Change-Id: Ied435269247efa8303d76e1b8e2dd0b2a1f7f25a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397622
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/232c2b7a0593cff88c5430ae76d7d374bd311280/host/lib/bundle_firmware.py
Project Member

Comment 112 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/e3a2c1adfd178eb3f69616eca60b8b68c2a51069

commit e3a2c1adfd178eb3f69616eca60b8b68c2a51069
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Oct 13 14:56:58 2016

cros_bundle_firmware: Zero out vblock areas

BUG= chromium:595715 
BRANCH=none
TEST=verify bit-equivalence of regions between image.bin and cb_with_fmap
with CL:397219 or similar.

Change-Id: I0e6e029a7bb645f92b06a8263d5b2d67a65bf16d
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397623
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/e3a2c1adfd178eb3f69616eca60b8b68c2a51069/host/lib/bundle_firmware.py
Project Member

Comment 113 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/b03b60ce06d43b7aa27e666f58717bd16044f4f0

commit b03b60ce06d43b7aa27e666f58717bd16044f4f0
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 12 11:14:16 2016

cros_bundle_firmware: Add test for image equivalence

Since the goal is to create an image that's equivalent to what the
packer is generating, test for that. Fail hard iff there's a difference.

One exception is the fmap region: Both versions are generated from the
same source (ultimately chromeos.fmd in the coreboot tree), but they
differ in the order of the fmap entries and in the fmap minor version
(1.0 vs 1.1).
Another is RW_SHARED, which is never used as-is (as it's usually an
inner node in the fmap region tree)

BUG= chromium:595715 
BRANCH=none
TEST=It now passes the test, but failed with some earlier commits (that
refer to this one) not applied.

Change-Id: I205487dd7c102d24606ce3657597394bc92818de
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/397219
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/b03b60ce06d43b7aa27e666f58717bd16044f4f0/host/lib/bundle_firmware.py
Project Member

Comment 114 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/4c3fa5bd412d12f062ec2ce8838bff9ef7920b5b

commit 4c3fa5bd412d12f062ec2ce8838bff9ef7920b5b
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 14 13:44:02 2016

cros_bundle_firmware: Cut down on PackFirmware uses

Move "pack" manipulation out of routines that are (or will be) used
outside the final packing step.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: Idf568edaa42e2c3eb451ef568bad2aa3b593b501
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/399018
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/4c3fa5bd412d12f062ec2ce8838bff9ef7920b5b/host/lib/bundle_firmware.py
Project Member

Comment 115 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/8e440668b1f437c4cad78a184f2ebbe860d184ff

commit 8e440668b1f437c4cad78a184f2ebbe860d184ff
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 14 13:44:59 2016

cros_bundle_firmware: Move legacy region handling for cb_with_fmap earlier

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I4cac09660cd449bb45e62f0d782c91639eea9ec1
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/399019
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/8e440668b1f437c4cad78a184f2ebbe860d184ff/host/lib/bundle_firmware.py
Project Member

Comment 116 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/246e3a4cd27ffe6ef1a697350eeab758aca3cd58

commit 246e3a4cd27ffe6ef1a697350eeab758aca3cd58
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Oct 25 08:37:17 2016

cros_bundle_firmware: Separate pack and cb_with_fmap handling some more

BUG= chromium:595715 
BRANCH=none
TEST=images are still identical (as determined by the mechanism
introduced in CL:397219)

Change-Id: Ic5e59f81eb3289eb51a3f2f30baf43d366180ec1
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404608
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/246e3a4cd27ffe6ef1a697350eeab758aca3cd58/host/lib/bundle_firmware.py
Project Member

Comment 117 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/84b568463cfc09c4722b0360811b406bdd2edd25

commit 84b568463cfc09c4722b0360811b406bdd2edd25
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 11:32:50 2016

cros_bundle_firmware: Drop the packing step

BUG= chromium:595715 
BRANCH=none
TEST=compared image.bin before and after this CL, only differences are
timestamps in the FWID regions and the order of regions in the FMAP.

Change-Id: I8bbc589f8afec25e118bd234b85eab4b86338f42
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404609
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/84b568463cfc09c4722b0360811b406bdd2edd25/host/lib/bundle_firmware.py
Project Member

Comment 118 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/30a822f3875c237a7beff9ba2b419c270c3e4373

commit 30a822f3875c237a7beff9ba2b419c270c3e4373
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: use higher level function for copying and slicing

Instead of a read/write through a variable, use shutil.
Instead of extracting an fmap region manually, use cbfstool.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I92fbee3649c394e94580bae468eb5b5227d36f4c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404610
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/30a822f3875c237a7beff9ba2b419c270c3e4373/host/lib/bundle_firmware.py
Project Member

Comment 119 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/84db6922a8d926f2085d89e7dd26c7db18c24dd6

commit 84db6922a8d926f2085d89e7dd26c7db18c24dd6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: Cut down on PackFirmware usage some more

Also remove some pack.AddProperty() calls because they're the last time
the object is touched and those properties won't do anything.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I123becfcfbf9d270127506b4352d54a0a0701dd8
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404611
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/84db6922a8d926f2085d89e7dd26c7db18c24dd6/host/cros_bundle_firmware
[modify] https://crrev.com/84db6922a8d926f2085d89e7dd26c7db18c24dd6/host/lib/bundle_firmware.py
Project Member

Comment 120 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/7a48715934ce78feca2913a0410e6794a78f8bd6

commit 7a48715934ce78feca2913a0410e6794a78f8bd6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: remove _BuildBlob() and _PrepareBootblock()

Not needed

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I721a6fb48bfc1066fae3891d4c081a634f1bd36c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404613
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/7a48715934ce78feca2913a0410e6794a78f8bd6/host/lib/bundle_firmware.py
Project Member

Comment 121 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/0737869269a590046bb165620ed23f552412bb24

commit 0737869269a590046bb165620ed23f552412bb24
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: remove RequireAllEntries() and CheckProperties()

Nothing is done with what they do to the pack object.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I93495f7c0373fd8cd88882b287da2eeb228f19e5
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404612
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/0737869269a590046bb165620ed23f552412bb24/host/lib/bundle_firmware.py
[modify] https://crrev.com/0737869269a590046bb165620ed23f552412bb24/host/lib/pack_firmware.py
Project Member

Comment 122 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/890963bada8c3cfdb42b069defda16a629dc4887

commit 890963bada8c3cfdb42b069defda16a629dc4887
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: Cut down on PackFirmware usage some more

Much of it isn't used anymore.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I754ae97a7fa58e3511bbd890e61570b8ec428a20
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404614
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/890963bada8c3cfdb42b069defda16a629dc4887/host/lib/bundle_firmware.py
Project Member

Comment 123 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-gale-private/+/f6dca5c13b360e7aaffe8fd27a180f6bfdfa60ec

commit f6dca5c13b360e7aaffe8fd27a180f6bfdfa60ec
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:14:20 2016
Project Member

Comment 124 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-gale-private/+/f6dca5c13b360e7aaffe8fd27a180f6bfdfa60ec

commit f6dca5c13b360e7aaffe8fd27a180f6bfdfa60ec
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:14:20 2016
Project Member

Comment 125 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-shogun-private/+/752c3640fb6b7a3aba6799d08661243ec8e8b8e6

commit 752c3640fb6b7a3aba6799d08661243ec8e8b8e6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:54:36 2016
Project Member

Comment 126 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-shogun-private/+/752c3640fb6b7a3aba6799d08661243ec8e8b8e6

commit 752c3640fb6b7a3aba6799d08661243ec8e8b8e6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:54:36 2016
Project Member

Comment 127 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-shogun-private/+/752c3640fb6b7a3aba6799d08661243ec8e8b8e6

commit 752c3640fb6b7a3aba6799d08661243ec8e8b8e6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:54:36 2016
Project Member

Comment 128 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cyclone-private/+/a468866c7d00230528a4c89e9e06108d251093cf

commit a468866c7d00230528a4c89e9e06108d251093cf
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:57:50 2016
Project Member

Comment 129 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-cyclone-private/+/a468866c7d00230528a4c89e9e06108d251093cf

commit a468866c7d00230528a4c89e9e06108d251093cf
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:57:50 2016
Project Member

Comment 130 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-rotor-private/+/961cdf57be8165a1be91ebf77fedf62478ae860d

commit 961cdf57be8165a1be91ebf77fedf62478ae860d
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:53:48 2016
Project Member

Comment 131 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-amenia-private/+/19cef77da49a49073b77deb89d710eee58f7b9f3

commit 19cef77da49a49073b77deb89d710eee58f7b9f3
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 15:39:12 2016
Project Member

Comment 132 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-amenia-private/+/19cef77da49a49073b77deb89d710eee58f7b9f3

commit 19cef77da49a49073b77deb89d710eee58f7b9f3
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 15:39:12 2016
Project Member

Comment 133 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-smaug-cheets-private/+/ec29d5eb5f4c8ed86b59d2baeef51ea00206101a

commit ec29d5eb5f4c8ed86b59d2baeef51ea00206101a
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:56:27 2016
Project Member

Comment 134 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-smaug-private/+/b9fa1321b5cf57c0e7cdf4d0cb9542e66a7853f0

commit b9fa1321b5cf57c0e7cdf4d0cb9542e66a7853f0
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:55:48 2016
Project Member

Comment 135 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/94bf45e2f6277e02066631edb390803dc6d823c6

commit 94bf45e2f6277e02066631edb390803dc6d823c6
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: Remove PackFirmware

Not used anymore

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I15e9a1bf21fde2dfe212ee4abdcdcc704ffd6b68
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404615
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/94bf45e2f6277e02066631edb390803dc6d823c6/host/lib/bundle_firmware.py
[delete] https://crrev.com/9767c3b1628414bfc611ddd44b9789ef75c52662/host/lib/pack_firmware.py
Project Member

Comment 136 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/9767c3b1628414bfc611ddd44b9789ef75c52662

commit 9767c3b1628414bfc611ddd44b9789ef75c52662
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: Move ifd handling out of PackFirmware

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: Iaa72cc17a6cad9b8f0f05507a588cda28d11b941
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/413122
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/9767c3b1628414bfc611ddd44b9789ef75c52662/host/lib/bundle_firmware.py
[modify] https://crrev.com/9767c3b1628414bfc611ddd44b9789ef75c52662/host/lib/pack_firmware.py
Project Member

Comment 137 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/a0ee5b2cbbd8c5fe64b6c86a0ce786e4b2fc7540

commit a0ee5b2cbbd8c5fe64b6c86a0ce786e4b2fc7540
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:05:16 2016

cros_bundle_firmware: remove unused function

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps

Change-Id: I0830cb3f44ba3fe361a4e01d7d9704badc310852
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414344
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/a0ee5b2cbbd8c5fe64b6c86a0ce786e4b2fc7540/host/lib/bundle_firmware.py
Project Member

Comment 138 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/a9d256e137a8b7414170c480e23a296945ddd298

commit a9d256e137a8b7414170c480e23a296945ddd298
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:31:57 2016

cros_bundle_firmware: don't add u-boot.dtb to CBFS

It's unused.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: If83ea687fda2c276cd802da052de18cba54dce74
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414345
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/a9d256e137a8b7414170c480e23a296945ddd298/host/lib/bundle_firmware.py
Project Member

Comment 139 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-storm-private/+/8f2e2afad69f766008eca3ff59b4af5179e0fc57

commit 8f2e2afad69f766008eca3ff59b4af5179e0fc57
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:55:08 2016
Project Member

Comment 140 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-smaug-kasan-private/+/70a86ee688ee4b2cee6ba25350addc195d4c8dc0

commit 70a86ee688ee4b2cee6ba25350addc195d4c8dc0
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Nov 29 16:56:49 2016
Project Member

Comment 141 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5aeb55d270df2c3d8c0ca07530f590e98d3b1e17

commit 5aeb55d270df2c3d8c0ca07530f590e98d3b1e17
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Nov 29 16:07:51 2016

chromeos-bootimage: drop unused symbols

Not used anywhere else in the tree: build-all-fw
Not used in this ebuild: efs, spring, vboot2

BUG= chromium:595715 
BRANCH=none
TEST=builds still pass

Change-Id: I5e90fb35a70c4973bdcae8df51bf61a06d0a56ec
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/415145
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/5aeb55d270df2c3d8c0ca07530f590e98d3b1e17/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 142 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5c5847dd6916a8520669f4f2c0c97ed480287d07

commit 5c5847dd6916a8520669f4f2c0c97ed480287d07
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Nov 29 16:09:25 2016

chromeos-memtest: Drop package

The only place it's hooked up is in chromeos-bootimage, but then the
result is never used anywhere.

BUG= chromium:595715 
BRANCH=none
TEST=builds still pass

Change-Id: I3d9898d62980a1cc92416e17cf0c00134441249b
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/415146
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[delete] https://crrev.com/80c20bf7fc30b81ee3c58ae3e6e19338935d229a/sys-boot/chromeos-memtest/chromeos-memtest-0.0.1-r5.ebuild
[modify] https://crrev.com/5c5847dd6916a8520669f4f2c0c97ed480287d07/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
[delete] https://crrev.com/80c20bf7fc30b81ee3c58ae3e6e19338935d229a/sys-boot/chromeos-memtest/chromeos-memtest-9999.ebuild
Project Member

Comment 143 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fc86f8492c52327dda6c3a48f021237c76eb3aff

commit fc86f8492c52327dda6c3a48f021237c76eb3aff
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Nov 29 17:43:00 2016

chromeos-u-boot: drop efs support

It's not requested anywhere in the tree and is the last remnant of the
portage use symbol.

BUG= chromium:595715 
BRANCH=none
TEST=builds still pass

Change-Id: Ifd321dbaa0a82271dbc1853b2aa69e9ad74310d3
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/414891
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/fc86f8492c52327dda6c3a48f021237c76eb3aff/sys-boot/chromeos-u-boot/chromeos-u-boot-9999.ebuild
Project Member

Comment 144 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/3f1a0929b15ab770a8a055d839ebdd6965c0cf2b

commit 3f1a0929b15ab770a8a055d839ebdd6965c0cf2b
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:37:06 2016

cros_bundle_firmware: Don't setup the internal FDT

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I006e9ec7d22599d5d54857fb74603a34e0066a56
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414346
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/3f1a0929b15ab770a8a055d839ebdd6965c0cf2b/host/cros_bundle_firmware
[modify] https://crrev.com/3f1a0929b15ab770a8a055d839ebdd6965c0cf2b/host/lib/bundle_firmware.py
Project Member

Comment 145 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/f8fae7f9ee337dcf29a95e6ae173f46775f5352f

commit f8fae7f9ee337dcf29a95e6ae173f46775f5352f
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:53:45 2016

cros_bundle_firmware: drop self.blobs use. it is always empty

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: Ib38caea502e170acc1fc9f0f20828cedc574f4ac
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414347
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/f8fae7f9ee337dcf29a95e6ae173f46775f5352f/host/cros_bundle_firmware
[modify] https://crrev.com/f8fae7f9ee337dcf29a95e6ae173f46775f5352f/host/lib/bundle_firmware.py
Project Member

Comment 146 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/e5541c814dd044a35dbe70de3ace308e07bc2fee

commit e5541c814dd044a35dbe70de3ace308e07bc2fee
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 16:00:43 2016

cros_bundle_firmware: stop using both region-name and REGION_NAME

We don't use the fdt anymore, so stick to FMAP_STYLE.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: Iced060cb3d363483ed831de206d3e94c11a66b16
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414348
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/e5541c814dd044a35dbe70de3ace308e07bc2fee/host/lib/bundle_firmware.py
Project Member

Comment 147 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/bcc6772c757111d33731e80e44655c3f63c04563

commit bcc6772c757111d33731e80e44655c3f63c04563
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Oct 26 14:16:27 2016

cros_bundle_firmware: remove support for default values

After the removal of uboot based firmware from chromeos-bootimage, all
invocations of cros_bundle_firmware also added the -D option.

Also drop code that is now unused and tests that test for the dead code.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps
CQ-DEPEND=CL:414364

Change-Id: If4fa588f720ec98c9bcaeab65af0d2e5f00bbb33
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414349
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/bcc6772c757111d33731e80e44655c3f63c04563/host/cros_bundle_firmware
[modify] https://crrev.com/bcc6772c757111d33731e80e44655c3f63c04563/host/lib/bundle_firmware.py
[modify] https://crrev.com/bcc6772c757111d33731e80e44655c3f63c04563/host/tests/bundle_firmware_ut.py
Project Member

Comment 148 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/a823b6699e19172071bdeb40872649d2a9d0935e

commit a823b6699e19172071bdeb40872649d2a9d0935e
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Nov 10 15:42:42 2016

cros_bundle_firmware: no need to create the GBB twice

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I1f068c33432dd11b05a12714d754a806a28e56e5
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414350
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/a823b6699e19172071bdeb40872649d2a9d0935e/host/lib/bundle_firmware.py
Project Member

Comment 149 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/7b71cabf2adf493d4415e86227411874afdda532

commit 7b71cabf2adf493d4415e86227411874afdda532
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Nov 10 15:51:51 2016

cros_bundle_firmware: Drop some more unused functions and symbols

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I09b879a9f91e08e14f2c7bfde55ed7adca0b498f
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414351
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/7b71cabf2adf493d4415e86227411874afdda532/host/cros_bundle_firmware
[modify] https://crrev.com/7b71cabf2adf493d4415e86227411874afdda532/host/lib/bundle_firmware.py
[modify] https://crrev.com/7b71cabf2adf493d4415e86227411874afdda532/host/tests/bundle_firmware_ut.py
Project Member

Comment 150 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/af7d1f5d1a8afb05e5832de537a12e90fdc98552

commit af7d1f5d1a8afb05e5832de537a12e90fdc98552
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Nov 23 15:00:47 2016

chromeos-bootimage: Drop setting defaults

That one is gone in its sibling CL stated in the CQ-DEPEND list

BUG= chromium:595715 
BRANCH=none
TEST=none
CQ-DEPEND=CL:414349

Change-Id: I8670d97d2d6d00a06de17ec6b7cbbe309234ae0a
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/414364
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/af7d1f5d1a8afb05e5832de537a12e90fdc98552/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 151 by bugdroid1@chromium.org, Dec 9 2016

Labels: merge-merged-chromeos-2016.05
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/baf378c5f2afdae9946600ef6ff07408a3668fe0

commit baf378c5f2afdae9946600ef6ff07408a3668fe0
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Dec 06 17:55:26 2016

util/cbfstool: Enable filling fmap regions with a given value

So far, cbfstool write, when used with the -u/-d options (to "fill
upwards/downwards") left the parts of the region alone for which there
was no new data to write.

When adding -i [0..255], these parts are overwritten with the given
value.

BUG= chromium:595715 
BRANCH=none
TEST=cbfstool write -u -i 0 ... does the right thing (fill the unused
space with zeroes)

Change-Id: I3752f731f8e6592b1a390ab565aa56e6b7de6765
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417319
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/baf378c5f2afdae9946600ef6ff07408a3668fe0/util/cbfstool/cbfstool.c
Project Member

Comment 152 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/51dafd18e5aee1bb8526790975a606a42a81f736

commit 51dafd18e5aee1bb8526790975a606a42a81f736
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Nov 23 15:01:47 2016

chromeos-bootimage: Don't specify the skeleton

That was made obsolete in cros-devutils and in fact doesn't work anymore.

BUG= chromium:595715 
BRANCH=none
TEST=none
CQ-DEPEND=CL:414352

Change-Id: Ic1ed926946d0a15da1e71b1588604a9d8c5cd3b4
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/414365
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/51dafd18e5aee1bb8526790975a606a42a81f736/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 153 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/376f5ad91d295bb49e8d753a0ea0ff2d86603d7a

commit 376f5ad91d295bb49e8d753a0ea0ff2d86603d7a
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Nov 23 15:02:26 2016

cros-devutils: Drop cros_write_firmware

BUG= chromium:595715 
BRANCH=none
TEST=none
CQ-DEPEND=CL:414353

Change-Id: Id0461ea52fd5556046a9121073650537707c91ae
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/414366
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/376f5ad91d295bb49e8d753a0ea0ff2d86603d7a/chromeos-base/cros-devutils/cros-devutils-9999.ebuild
Project Member

Comment 154 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/6f4595644864bf43705dbfbb8ab6d21030d9c83c

commit 6f4595644864bf43705dbfbb8ab6d21030d9c83c
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Nov 10 17:44:04 2016

cros_bundle_firmware: Drop skeleton option

We already pass the same file in as "coreboot", and slice it, then
reassemble it according to the IFD that's inside. That's needless
busywork.

BUG= chromium:595715 
BRANCH=none
TEST=Bit-identical build except for timestamps
CQ-DEPEND=CL:414365

Change-Id: I1cda0daca2c424c5801fba1af834b811a96a6f3c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414352
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/6f4595644864bf43705dbfbb8ab6d21030d9c83c/host/cros_bundle_firmware
[modify] https://crrev.com/6f4595644864bf43705dbfbb8ab6d21030d9c83c/host/lib/bundle_firmware.py
Project Member

Comment 155 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/5a63405741772b61d1a964e1362c750a8987733c

commit 5a63405741772b61d1a964e1362c750a8987733c
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_write_firmware: drop this ancient tool

BUG= chromium:595715 
BRANCH=none
TEST=none
CQ-DEPEND=CL:414366

Change-Id: I9ca19fcf2373cdfcd957a9546bad56559a9f1503
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/414353
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/5a63405741772b61d1a964e1362c750a8987733c/host/cros_bundle_firmware
[delete] https://crrev.com/6f4595644864bf43705dbfbb8ab6d21030d9c83c/host/cros_write_firmware
[delete] https://crrev.com/6f4595644864bf43705dbfbb8ab6d21030d9c83c/host/lib/write_firmware.py
Project Member

Comment 156 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/d2e3be81faa8d21f92325294530714a4b18a1b3e

commit d2e3be81faa8d21f92325294530714a4b18a1b3e
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Dec 06 20:59:23 2016

vendorcode/google/chromeos: Fill in firmware ID regions

Chrome OS images have three firmware ID regions, to store version
information for the read-only and the two read-write areas. Fill them
with a suitable default and allow configuring a different scheme.

There's already an override in google/foster and google/rotor to match
the naming scheme used so far (in depthcharge).

BUG= chromium:595715 
BRANCH=none
TEST=/build/$board/firmware/coreboot.rom has the expected values in the
regions.

Change-Id: I2fa2d51eacd832db6864fb67b6481b4d27889f52
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417320
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/vendorcode/google/chromeos/Makefile.inc
[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/mainboard/google/veyron/Kconfig
[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/vendorcode/google/chromeos/Kconfig
[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/mainboard/google/veyron_mickey/Kconfig
[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/mainboard/google/rotor/Kconfig
[modify] https://crrev.com/d2e3be81faa8d21f92325294530714a4b18a1b3e/src/mainboard/google/foster/Kconfig
Project Member

Comment 157 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/e8a88bf744f44d034f8606a556014e2bee37eda1

commit e8a88bf744f44d034f8606a556014e2bee37eda1
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:12:59 2016

vendorcode/google/chromeos: zero out SHARED_DATA region

BUG= chromium:595715 
BRANCH=none
TEST=/build/$board/firmware/coreboot.rom has a zeroed out SHARED_DATA
region if it exists.

Change-Id: I0b59f1f0e2f8645000f83cb3ca7f49e4da726341
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417821
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/e8a88bf744f44d034f8606a556014e2bee37eda1/src/vendorcode/google/chromeos/Makefile.inc
Project Member

Comment 158 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d417f7e7eba5e95f02a6c26a276eca427c6bb9dd

commit d417f7e7eba5e95f02a6c26a276eca427c6bb9dd
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Nov 23 15:02:26 2016

sys-boot/coreboot: Add fastboot flag to GBB for fastboot capable boards

Once the coreboot-generated GBB survives the packing process, this will
do the right thing.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I405684bf30c1f9764a947ca2226e1eb6b68b2dc0
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/415953
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/d417f7e7eba5e95f02a6c26a276eca427c6bb9dd/sys-boot/coreboot/coreboot-9999.ebuild
Project Member

Comment 159 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d395977626751a835be6c4975cc5de4a0bdb5153

commit d395977626751a835be6c4975cc5de4a0bdb5153
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Nov 23 15:02:26 2016

sys-boot/coreboot: Force dev switch on via GBB flags

We do that in depthcharge now for almost all boards (and there is no
known reason for the others: gale, link, storm, urara). Since GBB flags
are moved out of depthcharge, set them here.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I1b77cd46154d7a93c25c4a3ba802033ef48fb7c6
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/416408
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/d395977626751a835be6c4975cc5de4a0bdb5153/sys-boot/coreboot/coreboot-9999.ebuild
Project Member

Comment 161 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/462ee8f840f366b4c45590bbae38d72603a47f22

commit 462ee8f840f366b4c45590bbae38d72603a47f22
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: optimize file copying

Instead of copying a file twice using ReadFile and WriteFile, go for
shutil and get the job done in a single pass.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result

Change-Id: If1293c8f9020e5d24409b7f5e4e5e46e5547352b
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/415326
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/462ee8f840f366b4c45590bbae38d72603a47f22/host/lib/bundle_firmware.py
Project Member

Comment 162 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0babd54afc716aaadf632d4a7c43cb28b9f9363a

commit 0babd54afc716aaadf632d4a7c43cb28b9f9363a
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/coreboot: Determine Chrome OS version for the FWID fields

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:417320
TEST=/build/*/firmware/coreboot.rom (pre-cros_bundle_firmware) contains
the right data in the fields

Change-Id: Icb075e007c6166f8c602fcaf6d2711acccd8f36d
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/417820
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/0babd54afc716aaadf632d4a7c43cb28b9f9363a/sys-boot/coreboot/coreboot-9999.ebuild
Project Member

Comment 163 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/edc439ba219620b97c6f9a740bc77ee4750c1630

commit edc439ba219620b97c6f9a740bc77ee4750c1630
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: reuse existing GBB

Instead of creating a new GBB, reuse the one put in by the coreboot
ebuild. We still write the flags and hwid, but the pubkeys aren't
updated anymore.
A minor change in output is that the GBB region is filled up with 0x00
instead of 0xff.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result except as explained above.

Change-Id: Idce6195da885f242494cd31990e288d7ae1190d0
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/415327
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/edc439ba219620b97c6f9a740bc77ee4750c1630/host/lib/bundle_firmware.py
Project Member

Comment 164 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/3087de3da2dbea4124043aeb34eda9a6e8618c6d

commit 3087de3da2dbea4124043aeb34eda9a6e8618c6d
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: reuse existing GBB flags

Read the existing GBB flags from the image before manipulating them
according to fmap.dts and command line options.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result

Change-Id: I4622c05effe715f788377c508591ce09ad9887c8
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/415328
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/3087de3da2dbea4124043aeb34eda9a6e8618c6d/host/lib/bundle_firmware.py
Project Member

Comment 165 by bugdroid1@chromium.org, Dec 11 2016

Labels: merge-merged-firmware-reef-9042.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/a1e4fcb4c641fffb4cf9a7633e67985704ee9aab

commit a1e4fcb4c641fffb4cf9a7633e67985704ee9aab
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Dec 06 17:55:26 2016

util/cbfstool: Enable filling fmap regions with a given value

So far, cbfstool write, when used with the -u/-d options (to "fill
upwards/downwards") left the parts of the region alone for which there
was no new data to write.

When adding -i [0..255], these parts are overwritten with the given
value.

BUG= chromium:595715 
BRANCH=none
TEST=cbfstool write -u -i 0 ... does the right thing (fill the unused
space with zeroes)

Change-Id: I3752f731f8e6592b1a390ab565aa56e6b7de6765
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417319
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418926
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Aaron Durbin <adurbin@chromium.org>
Tested-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/a1e4fcb4c641fffb4cf9a7633e67985704ee9aab/util/cbfstool/cbfstool.c
Project Member

Comment 166 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/d589febd0b5669b169f999990b3e7022dabecfda

commit d589febd0b5669b169f999990b3e7022dabecfda
Author: Patrick Georgi <pgeorgi@google.com>
Date: Tue Dec 06 20:59:23 2016

vendorcode/google/chromeos: Fill in firmware ID regions

Chrome OS images have three firmware ID regions, to store version
information for the read-only and the two read-write areas. Fill them
with a suitable default and allow configuring a different scheme.

There's already an override in google/foster and google/rotor to match
the naming scheme used so far (in depthcharge).

BUG= chromium:595715 
BRANCH=none
TEST=/build/$board/firmware/coreboot.rom has the expected values in the
regions.

Change-Id: I2fa2d51eacd832db6864fb67b6481b4d27889f52
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417320
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418927
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Aaron Durbin <adurbin@chromium.org>
Tested-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/vendorcode/google/chromeos/Makefile.inc
[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/mainboard/google/veyron/Kconfig
[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/vendorcode/google/chromeos/Kconfig
[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/mainboard/google/veyron_mickey/Kconfig
[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/mainboard/google/rotor/Kconfig
[modify] https://crrev.com/d589febd0b5669b169f999990b3e7022dabecfda/src/mainboard/google/foster/Kconfig
Project Member

Comment 167 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/a7313c1b498b068541aef7bb2ee347db8590b020

commit a7313c1b498b068541aef7bb2ee347db8590b020
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:12:59 2016

vendorcode/google/chromeos: zero out SHARED_DATA region

BUG= chromium:595715 
BRANCH=none
TEST=/build/$board/firmware/coreboot.rom has a zeroed out SHARED_DATA
region if it exists.

Change-Id: I0b59f1f0e2f8645000f83cb3ca7f49e4da726341
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417821
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418928
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Aaron Durbin <adurbin@chromium.org>
Tested-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/a7313c1b498b068541aef7bb2ee347db8590b020/src/vendorcode/google/chromeos/Makefile.inc
Project Member

Comment 168 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/8bfff51b13ae59b555da5b8dcae90cf782291294

commit 8bfff51b13ae59b555da5b8dcae90cf782291294
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Dec 01 19:34:21 2016

fmap.dts: drop GBB flags

They're set in CL:381931, CL:415953, CL:416408 and enabled in CL:415328.
Finally, CL:416428 removes the last uses of these fmap entries.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical output for chromeos-bootimage (except for timestamps)
CQ-DEPEND=CL:381931,CL:415953,CL:416408,CL:415328,CL:416428

Change-Id: Ia37c6c3fbb8e1bb07b03ae6eb541218bf933e3af
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/415929
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/rotor/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/cyan/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/nyan_blaze/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_pinky/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/eve/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_mighty/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/falco/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/peach_pit/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/kevin/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_speedy/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/kunimitsu/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_rialto/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/cosmos/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/peppy/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/gru/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/purin/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/samus/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/nyan_big/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/glados/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_jaq/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/gale/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_shark/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/auron/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/pyro/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_gus/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/jecht/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/strago/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_mickey/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/storm/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_thea/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/reef/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/nyan/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/daisy/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_jerry/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/urara/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/elm/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/rambi/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_minnie/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/hana/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/lars/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/snappy/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/panther/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/link/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/foster/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/smaug/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/chell/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/oak/fmap.dts
[modify] https://crrev.com/8bfff51b13ae59b555da5b8dcae90cf782291294/board/veyron_nicky/fmap.dts
Project Member

Comment 169 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/d836a5ab3773c40b4a42fbe43a21d1a286a893fe

commit d836a5ab3773c40b4a42fbe43a21d1a286a893fe
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: stop parsing GBB flags from fmap.dts

With CL:415929 fmap.dts doesn't contain any more GBB flags.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result
CQ-DEPEND=CL:415929

Change-Id: Ic24121542b52a29d8f078c29c9d87f1e12cc13a2
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/416428
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/d836a5ab3773c40b4a42fbe43a21d1a286a893fe/host/lib/bundle_firmware.py
Project Member

Comment 170 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/428fc2ecd6b4ca991f7960856f955b9cb8743094

commit 428fc2ecd6b4ca991f7960856f955b9cb8743094
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: stop parsing hwid from fmap.dts

coreboot's build already sets it in the GBB, so no need to change it
again. It's still possible to override through cros_bundle_firmware
command line arguments.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result except for timestamps

Change-Id: I9b294b598232d826b42312dcf64648b3935c4edf
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417019
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/428fc2ecd6b4ca991f7960856f955b9cb8743094/host/lib/bundle_firmware.py
Project Member

Comment 171 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/64f29fbb5811a2630dff7624c27a82c102a72eee

commit 64f29fbb5811a2630dff7624c27a82c102a72eee
Author: Patrick Georgi <pgeorgi@google.com>
Date: Fri Oct 28 15:18:07 2016

cros_bundle_firmware: no need to wipe wiped regions

coreboot initializes all flash with 0xff, so writing all 0xff into a
region makes no sense.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result except for timestamps

Change-Id: I67fdebaad496d62d9470782d3f2415116e8ac14e
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417339
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/64f29fbb5811a2630dff7624c27a82c102a72eee/host/lib/bundle_firmware.py
Project Member

Comment 172 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/10aa2e2076f979590f0c776db6957254a2220837

commit 10aa2e2076f979590f0c776db6957254a2220837
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/chromeos-bootimage: no need for the fdt in cros_bundle_firmware

BUG= chromium:595715 
BRANCH=none
TEST=none
CQ-DEPEND=CL:417921

Change-Id: Iad1c9bb7b91e4d201a1a73026bf7338754cae1ab
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/417261
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/10aa2e2076f979590f0c776db6957254a2220837/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 173 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d4e28e64f977ea61c64abb66306054bca4e70f84

commit d4e28e64f977ea61c64abb66306054bca4e70f84
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/depthcharge: don't build the fmap anymore

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: Ifd30603ae93485e20cfdc63d14e2f1a826502034
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/417300
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/d4e28e64f977ea61c64abb66306054bca4e70f84/sys-boot/depthcharge/depthcharge-9999.ebuild
Project Member

Comment 174 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/991fe109d705728afd7103c4815a49349122b9df

commit 991fe109d705728afd7103c4815a49349122b9df
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: don't zero-extend regions manually

cbfstool can do this.

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:417319
TEST=bit-identical result except for timestamps

Change-Id: I6164730b5adbf0c888431a4f360009281ded6917
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417860
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/991fe109d705728afd7103c4815a49349122b9df/host/lib/bundle_firmware.py
Project Member

Comment 175 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/2e6fa8db2676b423fe151caab5219616f146056e

commit 2e6fa8db2676b423fe151caab5219616f146056e
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: don't repeat coreboot-ebuild's work

With CL:417821 SHARED_DATA is zeroed out and with CL:417820 the
FWID regions are filled in properly.

One side effect is that timestamps in FWID are now based on coreboot's
build time instead of cros_bundle_firmware's invocation time.

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:417821,CL:417820
TEST=bit-identical result

Change-Id: Iec19d8918998ef403f20ac143a9970baa8701411
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417861
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/2e6fa8db2676b423fe151caab5219616f146056e/host/lib/bundle_firmware.py
Project Member

Comment 176 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/c15453ade22762919a2839a0aaf6c1f80f956bdb

commit c15453ade22762919a2839a0aaf6c1f80f956bdb
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: drop support for uboot only builds

The ebuild always passes --coreboot-elf into cros_bundle_firmware.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I7adbaa27482a829a0092643b6eca2209b3b5fb4c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417920
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/c15453ade22762919a2839a0aaf6c1f80f956bdb/host/lib/bundle_firmware.py
Project Member

Comment 177 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/f59870a5c0b2b58bcd33eaa4bcf25352d6cad7db

commit f59870a5c0b2b58bcd33eaa4bcf25352d6cad7db
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: don't use fmap at all

Now that the coreboot build covers most of the bases, the code flow is
simple enough that we don't have to use the fmap to guide us.

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:417261
TEST=bit-identical result

Change-Id: I24877c1102cd40b49e7258c27680d64a0accd792
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417921
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/f59870a5c0b2b58bcd33eaa4bcf25352d6cad7db/host/cros_bundle_firmware
[modify] https://crrev.com/f59870a5c0b2b58bcd33eaa4bcf25352d6cad7db/host/lib/bundle_firmware.py
Project Member

Comment 178 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e85fa4b348187911fee85a7d30ef71ea04f8bac5

commit e85fa4b348187911fee85a7d30ef71ea04f8bac5
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/chromeos-bootimage: don't set enable-serial in GBB again

For the serial builds, cros_bundle_firmware was requested to set this
bit. This isn't necessary however, as it's already set by the coreboot
ebuild (and since recently, the GBB flags set in the coreboot build are
integrated to the final image)

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result

Change-Id: Ifc46ee603ee82c855efe931df496d61aa35a36a4
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418656
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/e85fa4b348187911fee85a7d30ef71ea04f8bac5/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 179 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f537fd0b3ced32ea774d2e0080ded8e9bd8073cd

commit f537fd0b3ced32ea774d2e0080ded8e9bd8073cd
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/chromeos-bootimage: handle rocbfs and legacy manually

Instead of passing those off to cros_bundle_firmware, do them once in
the beginning and base the final touches by cros_bundle_firmware on
that.
This should speed up the build slightly and is also a good first
step towards eliminating cros_bundle_firmware.

BUG= chromium:595715 
BRANCH=none
TEST=structurally identical result (but CBFS files from rocbfs are
added in a different order)

Change-Id: Icfe92c6274948534b65436433e74ac1d1b76d199
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418780
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/f537fd0b3ced32ea774d2e0080ded8e9bd8073cd/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 180 by bugdroid1@chromium.org, Dec 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cd450a41eaad08efa6b2b58a2d1e8c54d17aba44

commit cd450a41eaad08efa6b2b58a2d1e8c54d17aba44
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/chromeos-bootimage: Get rid of cros_bundle_firmware calls

After refactoring cros_bundle_firmware, it became clear what it's
_actually_ doing (well, and after moving some parts out and into other
places). It's simple enough that the ebuild can take over, eliminating
the complication of having to update cros-devutils every time the build
changes slightly.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical results

Change-Id: I3702ae0c97d33dbafdcf6d03308ef3a626dabf65
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418781
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/cd450a41eaad08efa6b2b58a2d1e8c54d17aba44/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 181 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/6bc3614a2acfb9116b481c1751f11a512b7ee5cf

commit 6bc3614a2acfb9116b481c1751f11a512b7ee5cf
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Dec 01 19:34:21 2016

fmap.dts: drop hardware id

coreboot build is already setting it in the GBB and it isn't used for
anything else. See coreboot/src/mainboard/*/*/Kconfig, GBB_HWID.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical output for chromeos-bootimage (except for timestamps)
CQ-DEPEND=CL:417019

Change-Id: Ib6013c24362b25eb3c6061121b69f13a613c1a83
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/416412
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/rotor/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/cyan/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan_blaze/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_pinky/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/eve/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_mighty/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/falco/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/peach_pit/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/kevin/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_speedy/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/kunimitsu/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_rialto/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/cosmos/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/peppy/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/gru/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/purin/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/samus/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan_big/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/glados/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_jaq/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/gale/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_shark/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/auron/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/pyro/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_gus/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/jecht/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/strago/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_mickey/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/storm/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_thea/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/reef/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/daisy/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_jerry/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/urara/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/elm/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/rambi/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_minnie/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/hana/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/lars/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/snappy/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/panther/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/link/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/foster/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/smaug/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/chell/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/oak/fmap.dts
[modify] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_nicky/fmap.dts
Project Member

Comment 182 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/cb739b2d305c44dfc168cebcfd809bb99693be34

commit cb739b2d305c44dfc168cebcfd809bb99693be34
Author: Patrick Georgi <pgeorgi@google.com>
Date: Thu Dec 01 19:34:21 2016

fmap.dts: drop fmap.dts

model is filled in by coreboot, so fmap.dts is now empty and unused.
Get rid of it before it somehow returns.

BUG= chromium:595715 
BRANCH=none
TEST=still builds
CQ-DEPEND=CL:417300

Change-Id: Idee8df5a6aa99b3355f6d0e266a0cb22902c476c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/417321
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/rotor/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/cyan/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan_blaze/fmap.dts
[modify] https://crrev.com/cb739b2d305c44dfc168cebcfd809bb99693be34/Makefile
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_pinky/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/eve/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_mighty/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/falco/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/peach_pit/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/kevin/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_speedy/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/kunimitsu/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_rialto/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/cosmos/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/peppy/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/gru/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/purin/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/samus/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan_big/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/glados/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_jaq/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/gale/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_shark/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/auron/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/pyro/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_gus/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/jecht/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/strago/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_mickey/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/storm/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_thea/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/reef/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/nyan/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/daisy/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_jerry/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/urara/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/elm/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/rambi/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_minnie/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/hana/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/lars/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/snappy/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/panther/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/link/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/foster/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/smaug/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/chell/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/oak/fmap.dts
[delete] https://crrev.com/6bc3614a2acfb9116b481c1751f11a512b7ee5cf/board/veyron_nicky/fmap.dts
Project Member

Comment 183 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/3de985f6b32fa8832476ae4694eacbf9612d016b

commit 3de985f6b32fa8832476ae4694eacbf9612d016b
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: drop tons of unused options and GBB modification

There are lots of options that aren't used anymore. Also drop
manipulation of the GBB according to command line options since those
options aren't used anymore.

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:418656
TEST=bit-identical result

Change-Id: I92524f938bb26d06055a3da305aeceeb433ed276
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/418775
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/3de985f6b32fa8832476ae4694eacbf9612d016b/host/cros_bundle_firmware
[modify] https://crrev.com/3de985f6b32fa8832476ae4694eacbf9612d016b/host/lib/bundle_firmware.py
Project Member

Comment 184 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/51caac320195e9b698671c181de5ec2986b8f8a2

commit 51caac320195e9b698671c181de5ec2986b8f8a2
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: reduce number of file copies

There's now an input file and an output file. No partial copies at
various points in time that are never again looked at and no multiple
names for what is essentially the same thing.

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result

Change-Id: Ic2a9508351fbfb564f001a8b689a6da174fe6cb1
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/418776
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/51caac320195e9b698671c181de5ec2986b8f8a2/host/cros_bundle_firmware
[modify] https://crrev.com/51caac320195e9b698671c181de5ec2986b8f8a2/host/lib/bundle_firmware.py
Project Member

Comment 185 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/8bc8a9e92811b645cd749d33179dfbc21989baeb

commit 8bc8a9e92811b645cd749d33179dfbc21989baeb
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

cros_bundle_firmware: inline a number of calls

Makes it much easier to see what's going on. There's a linear code flow
now (except for stuff that is _actually_ called repeatedly).

BUG= chromium:595715 
BRANCH=none
TEST=bit-identical result

Change-Id: Id1bbf9795c6551c0a5a9df60422cba1af3cf3e8a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/418777
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/cros_bundle_firmware
[modify] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/lib/bundle_firmware.py
Project Member

Comment 186 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/42c23c77527f9b7a8b8b83376fb67a3f936e0e1f

commit 42c23c77527f9b7a8b8b83376fb67a3f936e0e1f
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Wed Dec 07 10:42:21 2016

sys-boot/chromeos-bootimage: Refactor build flow

We do the same thing ~5 times, so instead of open coding it, put it in a
function.
Also changed the output a bit to be more meaningful.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I7f2eb6f2673bf1a6580372e2f956d006864e73cd
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/418782
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/42c23c77527f9b7a8b8b83376fb67a3f936e0e1f/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 187 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/686eb4e7fa4fae3a0ddb3b2852f16682b0b33268

commit 686eb4e7fa4fae3a0ddb3b2852f16682b0b33268
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Thu Dec 15 22:53:28 2016

chromeos-bootimage: fix payload placement in netboot image

As Julius noted in CL:418781, the payloads were put in the wrong regions
in the netboot image.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I2dccc78174acee79a836f9520d850f17cdf27b8c
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/420724
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/686eb4e7fa4fae3a0ddb3b2852f16682b0b33268/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 188 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7

commit ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Thu Dec 15 22:55:16 2016

chromeos-bootimage: drop unused local variables

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I064cc74ae13f6a70ea76458dff46e1da3fc2e704
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/420725
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 189 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7

commit ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Thu Dec 15 22:55:16 2016

chromeos-bootimage: drop unused local variables

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I064cc74ae13f6a70ea76458dff46e1da3fc2e704
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/420725
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/ac3ef809dd9d8e1d51593e4dd777b0d7023e9ef7/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 190 by bugdroid1@chromium.org, Dec 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/016411ac2cff13fa4130e4f9c0948e3fcbb4789f

commit 016411ac2cff13fa4130e4f9c0948e3fcbb4789f
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Dec 13 14:30:34 2016

chromeos-base/cros-devutils: don't install cros_bundle_firmware

That tool isn't used anymore.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: If08eb1fe8dd8a6f821e043868e92dfca0bfa9e5d
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/419395
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/016411ac2cff13fa4130e4f9c0948e3fcbb4789f/chromeos-base/cros-devutils/cros-devutils-9999.ebuild
Project Member

Comment 191 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/95b539b277b92a50b2ae3e0bd57f46e9c5c9ad28

commit 95b539b277b92a50b2ae3e0bd57f46e9c5c9ad28
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Dec 13 14:30:34 2016

sys-boot/chromeos-bootimage: don't filter out cbfstool's stderr

The right place to ensure reasonable output in scripts is in cbfstool
itself.

BUG= chromium:595715 
BRANCH=none
TEST=none

Change-Id: I8f3a8e01feb9fc6794f3341e24fa6310bd8b14d6
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/420790
Commit-Ready: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/95b539b277b92a50b2ae3e0bd57f46e9c5c9ad28/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
Project Member

Comment 192 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/8b3456a4ca895f01fec4036a73961e972ca17a46

commit 8b3456a4ca895f01fec4036a73961e972ca17a46
Author: Patrick Georgi <pgeorgi@google.com>
Date: Wed Dec 07 11:30:14 2016

Drop cros_bundle_firmware and related files

BUG= chromium:595715 
BRANCH=none
CQ-DEPEND=CL:419395
TEST=build still succeeds

Change-Id: I48289a937abf75a1dbf2bc66f2d1e69a6922348b
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/418783
Commit-Ready: Stefan Reinauer <reinauer@chromium.org>
Tested-by: Stefan Reinauer <reinauer@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/chromeos.dtsi
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/flashmap-twostop-2mb.dtsi
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/lib/exynos.py
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/bundle_firmware_ut.py
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/tegra250.dtsi
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/source.dts
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/source.dts
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/lib/fmap.py
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/make-test.sh
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/skeleton.dtsi
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/cros_bundle_firmware
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/lib/bundle_firmware.py
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/tegra-map.dts
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/tests/dts/flashmap-ro-1mb.dtsi
[delete] https://crrev.com/8bc8a9e92811b645cd749d33179dfbc21989baeb/host/lib/fdt.py
Project Member

Comment 193 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/958ecd8bde1b6d66ca5b281d01219d5b1071019d

commit 958ecd8bde1b6d66ca5b281d01219d5b1071019d
Author: Patrick Georgi <pgeorgi@chromium.org>
Date: Tue Dec 13 14:30:34 2016

sys-boot/chromeos-bootimage: exit on cbfstool error

Catch the error, report it and exit.

BUG= chromium:595715 
BRANCH=none
TEST=Revert CL:418926, rebuild coreboot-utils (host) and observe that
emerge-$board chromeos-bootimage bails out because -i is not accepted.
Also added if [ "$2" = "print" ]; then die "sudden death by test"; fi to
do_cbfstool and observed that the do_cbfstool invocation in a subshell
still does the right thing (report that error).

Change-Id: I4102d0c5b339678fcf09d8264e0ede7e94e605e4
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/420727
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/958ecd8bde1b6d66ca5b281d01219d5b1071019d/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild

Comment 194 by pgeorgi@chromium.org, Jan 6 2017

Blocking: 630451

Comment 195 by pgeorgi@chromium.org, Jan 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 196 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c54871a3662d0d05b1644c3bd69a1aa2cd41b54e

commit c54871a3662d0d05b1644c3bd69a1aa2cd41b54e
Author: Patrick Georgi <pgeorgi@google.com>
Date: Mon Dec 12 11:06:03 2016

firmware_FMap: Fix test with empty area_flags

While mosys emits a trailing space in the "value" style as part of the
" | " delimiter, it's lost somewhere along the way.

Instead, split by | and get rid of the surrounding spaces manually.

BUG=chrome-os-partner:60841, chromium:595715 
BRANCH=none
TEST=tested with a modified version of the file and static data, but
FAFT's "test_that --board=$board IP firmware_FMap" should also work again

Change-Id: Ia9d56487b3a571fac6217d7900fd9672441c91ff
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/418718
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
(cherry picked from commit c0db5fda9453a57a210aa68c54938bddac431e79)
Reviewed-on: https://chromium-review.googlesource.com/434539
Tested-by: Freddy Paul <freddy.paul@intel.com>
Reviewed-by: Benson Leung <bleung@google.com>
Commit-Queue: Freddy Paul <freddy.paul@intel.com>

[modify] https://crrev.com/c54871a3662d0d05b1644c3bd69a1aa2cd41b54e/server/site_tests/firmware_FMap/firmware_FMap.py
Project Member

Comment 197 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/5b996ea0496099869988b64566f60188b6880e14

commit 5b996ea0496099869988b64566f60188b6880e14
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jun 27 06:44:12 2018
Project Member

Comment 198 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/a17de0e5ff6e51de2ed52481a79068a866658136

commit a17de0e5ff6e51de2ed52481a79068a866658136
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jun 27 15:26:15 2018

memtest: punt

The ebuild was deleted two years ago in CL:415146.

BUG= chromium:595715 
TEST=precq passes

Change-Id: I680633150b07a414fc3639b0ee3e515ad2affbc0
Reviewed-on: https://chromium-review.googlesource.com/1114492
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a17de0e5ff6e51de2ed52481a79068a866658136/full.xml
Project Member

Comment 199 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0a3cb44a2806d3b6b5f501aa7fb6b3dd69a40f1a

commit 0a3cb44a2806d3b6b5f501aa7fb6b3dd69a40f1a
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 28 05:07:31 2018

cros-devutils: drop old python modules

The only python modules left here were for cros_bundle_firmware,
but we're deleting those, so drop the logic here.

BUG= chromium:595715 
TEST=precq passes

Change-Id: Id877dc3cbf9b99088bc3aa062cb24eae11d1c216
Reviewed-on: https://chromium-review.googlesource.com/1114480
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[modify] https://crrev.com/0a3cb44a2806d3b6b5f501aa7fb6b3dd69a40f1a/chromeos-base/cros-devutils/cros-devutils-9999.ebuild
Project Member

Comment 200 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/a933139ff58d28b34c985f58799ca13f837e15f9

commit a933139ff58d28b34c985f58799ca13f837e15f9
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 28 14:06:49 2018

drop more cros_bundle_firmware related files

A lot of stuff was dropped here in commit 8b3456a4ca895f01fec4036a739,
but a few files only used by that code was missed.  Drop them too.

BUG= chromium:595715 
TEST=precq passes
CQ-DEPEND=CL:1114480

Change-Id: I3dc21d287dcb3477e766bca51c5cc32413bd53ba
Reviewed-on: https://chromium-review.googlesource.com/1114478
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>

[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/tests/bin/board.bct
[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/tests/bin/bmpblk.bin
[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/tests/lorem.txt
[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/lib/cros_output.py
[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/lib/__init__.py
[delete] https://crrev.com/9b01c8823a62583b390388a22f76c76070ce6d8f/host/lib/tools.py
Project Member

Comment 201 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/960daf672c3bde6f0246f6fc7a798a2a459a9c17

commit 960daf672c3bde6f0246f6fc7a798a2a459a9c17
Author: Joel Kitching <kitching@google.com>
Date: Wed Aug 01 07:05:21 2018

chromeos-bootimage/coreboot: remove cbfs/ file additions

cbfs/ is currently unused.  Additionally, its addition into
CBFS is duplicated across both chromeos-bootimage and
coreboot, which would result in an error in chromeos-bootimage
("already in ROM image").

If cbfs/ directory exists, fail and show that it is deprecated.

BUG= chromium:595715 
BRANCH=None
TEST=emerge coreboot chromeos-bootimage

Change-Id: I47475506dec9bd08820d17cb1da3b70540555bc9
Reviewed-on: https://chromium-review.googlesource.com/1148174
Commit-Ready: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>

[modify] https://crrev.com/960daf672c3bde6f0246f6fc7a798a2a459a9c17/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[rename] https://crrev.com/960daf672c3bde6f0246f6fc7a798a2a459a9c17/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r28.ebuild
[modify] https://crrev.com/960daf672c3bde6f0246f6fc7a798a2a459a9c17/sys-boot/coreboot/coreboot-9999.ebuild
Project Member

Comment 202 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/992aada2fa603e71d7b39cee55ec01dcb1713ab5

commit 992aada2fa603e71d7b39cee55ec01dcb1713ab5
Author: Joel Kitching <kitching@google.com>
Date: Wed Aug 08 01:09:03 2018

chromeos-bootimage: clean up deprecation code for rocbfs/

Should use double brackets (since ebuilds use bash), and use
a tab instead of spaces.

BUG= chromium:595715 
BRANCH=None
TEST=emerge chromeos-bootimage

Change-Id: Ie7bf35bc7f5a9ccc05931f05ac9bcec04b62bed5
Reviewed-on: https://chromium-review.googlesource.com/1159923
Commit-Ready: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Joel Kitching <kitching@chromium.org>

[modify] https://crrev.com/992aada2fa603e71d7b39cee55ec01dcb1713ab5/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3.ebuild
[rename] https://crrev.com/992aada2fa603e71d7b39cee55ec01dcb1713ab5/sys-boot/chromeos-bootimage/chromeos-bootimage-0.0.3-r32.ebuild
Showing comments 103 - 202 of 202 Older ›
►

Sign in to add a comment