New issue
Advanced search Search tips

Issue 595709 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4%-4.5% regression in smoothness.tough_animation_cases at 381515:381573

Project Member Reported by tdres...@chromium.org, Mar 17 2016

Issue description

See the link to graphs below.
 
Cc: mtklein@chromium.org
Seems likely to be https://codereview.chromium.org/1808663003, based on the bisect results.

mtklein@, any likely suspects?
Cc: senorblanco@chromium.org
Hmm.  Most of those CLs are boring or reverted.  The first CL I'd investigate is
   senorblanco GrTessellator: don't reuse the previous vertex buffer on a cache miss.
GrTessellator is only used if GPU rasterization is on in Chrome, which it isn't for Windows or Linux currently. So it couldn't be the culprit.
Cc: ericwilligers@chromium.org
Owner: ericwilligers@chromium.org

=== Auto-CCing suspected CL author ericwilligers@chromium.org ===

Hi ericwilligers@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Web Animations: Use of hyphens is no longer supported
Author  : ericwilligers
Commit description:
  
Hyphenated names in Web Animations keyframes were deprecated in M50.

camelCase is now required.

BUG= 588025 

Review URL: https://codereview.chromium.org/1771733002

Cr-Commit-Position: refs/heads/master@{#381541}
Commit  : 356ff3329424333a5dd0d8f971bbee648ed5d9ad
Date    : Wed Mar 16 21:04:41 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@381538         37.660775   0.089724    6           good
chromium@381540         37.626412   0.055873    5           good
chromium@381541         59.423909   0.036071    4           bad         <-
chromium@381543         59.497739   0.039588    5           bad
chromium@381548         59.411042   0.09092     5           bad
chromium@381557         59.481812   0.075723    5           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 595709

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests smoothness.tough_animation_cases
Test Metric: mean_frame_time/mean_frame_time
Relative Change: 57.83%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6374
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9016216283768204000


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=595709

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: nyerramilli@chromium.org
Labels: TE-Triaged
based on bisect results, ericwilligers@ could you please check the issue.
@ericwilligers: Friendly Ping!

Thank you!
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Apr 20 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Web Animations: Use of hyphens is no longer supported
Author  : ericwilligers
Commit description:
  
Hyphenated names in Web Animations keyframes were deprecated in M50.

camelCase is now required.

BUG= 588025 

Review URL: https://codereview.chromium.org/1771733002

Cr-Commit-Position: refs/heads/master@{#381541}
Commit  : 356ff3329424333a5dd0d8f971bbee648ed5d9ad
Date    : Wed Mar 16 21:04:41 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@381540         37.661879   0.086429    5           good
chromium@381541         59.566579   0.13809     5           bad         <-
chromium@381542         59.613782   0.093161    5           bad
chromium@381544         59.454282   0.047223    5           bad
chromium@381548         59.492058   0.069582    5           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 595709

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_animation_cases
Test Metric: mean_frame_time/mean_frame_time
Relative Change: 57.82%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6443
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014880004639386704


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=595709

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Started (was: Assigned)
Uploaded https://codereview.chromium.org/1904663006/

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/626255f1edd3892e60180f1004693e2e8c8cef63

commit 626255f1edd3892e60180f1004693e2e8c8cef63
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Apr 21 07:36:37 2016

Web Animations: Use camelCase for property name in performance test

Hyphenated property names have been deprecated in the Web Animations
API.

BUG= 595709 

Review URL: https://codereview.chromium.org/1904663006

Cr-Commit-Position: refs/heads/master@{#388712}

[modify] https://crrev.com/626255f1edd3892e60180f1004693e2e8c8cef63/tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js

Status: Fixed (was: Started)
Performance has recovered for 9 metrics. With the other 4, there haven't been any runs since February or March.

Sign in to add a comment