New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595685 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 605107
issue 796990
issue 796991

Blocking:
issue 774740
issue 787459



Sign in to add a comment

Convert Web Notifications to use Mojo instead of IPC

Project Member Reported by peter@chromium.org, Mar 17 2016

Issue description

IPC has been deprecated, Mojo is the way to go, so we should move Notifications over to use Mojo instead.

This also gives us the opportunity to remove some intermediate layers and define the API in Blink, allowing it to be shared across the board.
 
Blocking: 571056
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2263dd5457199da3e51086903f0a1caec6bd86d4

commit 2263dd5457199da3e51086903f0a1caec6bd86d4
Author: peter <peter@chromium.org>
Date: Tue Mar 22 13:35:22 2016

Define a Mojo Notification structure in the Blink API

This will replace the PlatformNotification{Action, Data} structures
that currently live in //content. It's based on a similar CL for Web
Bluetooth: https://codereview.chromium.org/1784613002/

The stack will be switched over in a next CL. Since it's part of a
larger-scale refactoring, I'd like to land this separately to unblock
other people that will depend on this.

BUG= 595685 

Review URL: https://codereview.chromium.org/1814813002

Cr-Commit-Position: refs/heads/master@{#382564}

[modify] https://crrev.com/2263dd5457199da3e51086903f0a1caec6bd86d4/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2263dd5457199da3e51086903f0a1caec6bd86d4/third_party/WebKit/public/blink.gyp
[add] https://crrev.com/2263dd5457199da3e51086903f0a1caec6bd86d4/third_party/WebKit/public/platform/modules/notifications/notification.mojom

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed

commit e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed
Author: peter <peter@chromium.org>
Date: Wed Mar 23 01:24:13 2016

Generate Blink's Mojo bindings both for regular and WTF variants

Mojo files defined in the API boundary will most likely be consumed
from both within and outside of Blink. This generates them both in the
regular variant, backed by the Mojo (STL) times, and the WTF variant.

I chose to use "wtf" as the variant rather than "blink" because of the
namespacing that's already in place: "blink::mojom::wtf::*" vs.
"blink::mojom::blink::*".

BUG= 595685 

Review URL: https://codereview.chromium.org/1819473002

Cr-Commit-Position: refs/heads/master@{#382761}

[modify] https://crrev.com/e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed/third_party/WebKit/public/blink.gyp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2

commit 108f14fc423eb09975fe1b8d3ca7e26ab452c0e2
Author: peter <peter@chromium.org>
Date: Tue Apr 19 17:37:32 2016

Move the notification constants to Blink

With Notifications departing from //content on the renderer side we need
a place where we can access them. The long-term goal however is for the
embedder to indicate these constants, for which I added TODOs.

BUG= 595685 

Review URL: https://codereview.chromium.org/1901133002

Cr-Commit-Position: refs/heads/master@{#388236}

[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/browser/DEPS
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/browser/notifications/notification_database_data_unittest.cc
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/child/notifications/notification_manager.h
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/common/OWNERS
[delete] https://crrev.com/cb0b829783d26fe083f951a58c2395bef0f06840/content/common/notification_constants.h
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/content/content_common.gypi
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp
[add] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h
[modify] https://crrev.com/108f14fc423eb09975fe1b8d3ca7e26ab452c0e2/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b9207d55ba05be221e68505a5c726a0978a4973

commit 1b9207d55ba05be221e68505a5c726a0978a4973
Author: peter <peter@chromium.org>
Date: Tue Apr 19 19:33:46 2016

Migrate notifications to use the PermissionStatus enum

TBR=mkwst for NotificationPermissionClientImpl.cpp
BUG= 595685 

Review URL: https://codereview.chromium.org/1898153002

Cr-Commit-Position: refs/heads/master@{#388279}

[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/browser/DEPS
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/child/notifications/notification_manager.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/common/DEPS
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/common/platform_notification_messages.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/shell/browser/layout_test/layout_test_notification_manager.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[delete] https://crrev.com/d1a7ca28d7d40c3fa23568249d14dc378b1ecc9c/third_party/WebKit/public/platform/modules/notifications/WebNotificationPermission.h
[modify] https://crrev.com/1b9207d55ba05be221e68505a5c726a0978a4973/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Comment 6 by peter@chromium.org, Apr 20 2016

Blockedon: 605107
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd303897bfe40025be26eaaf729568429373ef79

commit bd303897bfe40025be26eaaf729568429373ef79
Author: peter <peter@chromium.org>
Date: Mon May 16 21:08:26 2016

Use the Blink PermissionStatus variant for notifications in Blink

Blink shouldn't use the non-Blink variant types, so update these to use
the appropriate variant instead.

BUG= 595685 

Review-Url: https://codereview.chromium.org/1979593002
Cr-Commit-Position: refs/heads/master@{#393916}

[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/content/child/notifications/notification_manager.h
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/content/renderer/BUILD.gn
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[modify] https://crrev.com/bd303897bfe40025be26eaaf729568429373ef79/third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5987942de604fb5d51ef70e208931b713522955

commit c5987942de604fb5d51ef70e208931b713522955
Author: peter <peter@chromium.org>
Date: Tue May 17 19:22:15 2016

Introduce the Blink NotificationService, move permission checks there

This introduces the Mojo NotificationService in Blink and moves
permission checks over from the IPC code-path to the Mojo code-path.

BUG= 595685 

Review-Url: https://codereview.chromium.org/1948223004
Cr-Commit-Position: refs/heads/master@{#394185}

[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/DEPS
[add] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/blink_notification_service_impl.cc
[add] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/child/notifications/notification_manager.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/common/platform_notification_messages.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/content_browser.gypi
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/renderer/mojo/blink_service_registry_impl.cc
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/content/renderer/mojo/blink_service_registry_impl.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/notifications/Notification.h
[add] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[add] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/public/platform/modules/notifications/OWNERS
[modify] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[add] https://crrev.com/c5987942de604fb5d51ef70e208931b713522955/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Project Member

Comment 10 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3925867d699f8c5983f1f084b805e6b60fb8c52c

commit 3925867d699f8c5983f1f084b805e6b60fb8c52c
Author: peter <peter@chromium.org>
Date: Wed May 18 18:21:40 2016

Revert of Introduce the Blink NotificationService, move permission checks there (patchset #8 id:130001 of https://codereview.chromium.org/1948223004/ )

Reason for revert:
Causing crashes for users on Windows. Reverting.

BUG=612770

Original issue's description:
> Introduce the Blink NotificationService, move permission checks there
>
> This introduces the Mojo NotificationService in Blink and moves
> permission checks over from the IPC code-path to the Mojo code-path.
>
> BUG= 595685 
>
> Committed: https://crrev.com/c5987942de604fb5d51ef70e208931b713522955
> Cr-Commit-Position: refs/heads/master@{#394185}

TBR=dcheng@chromium.org,cmumford@chromium.org,esprehn@chromium.org,haraken@chromium.org,jam@chromium.org,mvanouwerkerk@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 595685 

Review-Url: https://codereview.chromium.org/1995663003
Cr-Commit-Position: refs/heads/master@{#394473}

[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/DEPS
[delete] https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f/content/browser/notifications/blink_notification_service_impl.cc
[delete] https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/child/notifications/notification_manager.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/common/platform_notification_messages.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/content_browser.gypi
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/renderer/mojo/blink_service_registry_impl.cc
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/content/renderer/mojo/blink_service_registry_impl.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/Source/modules/notifications/Notification.h
[delete] https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[delete] https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/public/platform/modules/notifications/OWNERS
[modify] https://crrev.com/3925867d699f8c5983f1f084b805e6b60fb8c52c/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[delete] https://crrev.com/7b6fd6417a48eadd78858d225b80d5f82d7ad40f/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd

commit f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd
Author: peter <peter@chromium.org>
Date: Fri Jun 03 14:09:23 2016

Introduce the Blink NotificationService, move permission checks there

This introduces the Mojo NotificationService in Blink and moves
permission checks over from the IPC code-path to the Mojo code-path.

This CL is a re-land of the original CL that was reverted because of
crash reports: https://codereview.chromium.org/1948223004/. In
addition, it removes usage of WeakPtr as pointed out by yszhen@.

TBR=esprehn, jam, dcheng, mvanouwerkerk, haraken
BUG= 595685 

Review-Url: https://codereview.chromium.org/2003023002
Cr-Commit-Position: refs/heads/master@{#397701}

[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/DEPS
[add] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/blink_notification_service_impl.cc
[add] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/child/notifications/notification_manager.cc
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/child/notifications/notification_manager.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/common/platform_notification_messages.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/content_browser.gypi
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/renderer/mojo/blink_service_registry_impl.cc
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/content/renderer/mojo/blink_service_registry_impl.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/notifications/Notification.h
[add] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[add] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/public/platform/modules/notifications/OWNERS
[modify] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
[add] https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Blocking: -571056
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886

commit f8ea4c45d43e8e4871f9a51f74fa8d74618c0886
Author: peter <peter@chromium.org>
Date: Mon Feb 13 18:08:36 2017

Mojoify the notificationclick and notificationclose events

BUG= 595685 

Review-Url: https://codereview.chromium.org/2682353002
Cr-Commit-Position: refs/heads/master@{#450007}

[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/common/service_worker/OWNERS
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/common/service_worker/service_worker_event_dispatcher.typemap
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/f8ea4c45d43e8e4871f9a51f74fa8d74618c0886/content/renderer/service_worker/service_worker_context_client.h

Comment 14 by awdf@chromium.org, Nov 16 2017

Owner: awdf@chromium.org

Comment 15 by awdf@chromium.org, Nov 16 2017

Made this doc to track the next stage of work to mojoify non-persistent notifications:

https://docs.google.com/document/d/1EcZgtdi57IhgbU1npnGgL6O5doXOqCIAqb6rUAE5K7k/edit#

Comment 16 by peter@chromium.org, Nov 21 2017

Blockedon: 787459

Comment 17 by awdf@chromium.org, Nov 21 2017

Blockedon: -787459

Comment 18 by awdf@chromium.org, Nov 21 2017

Blocking: 787459

Comment 19 by peter@chromium.org, Nov 21 2017

Cc: peter@chromium.org
 Issue 787312  has been merged into this issue.
Components: Blink>Internals>Modularization
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce083220582169c3bfddb603a7e2b818850c576

commit bce083220582169c3bfddb603a7e2b818850c576
Author: Anita Woodruff <awdf@chromium.org>
Date: Thu Nov 23 11:41:13 2017

[Notifications] Add NotificationsWithMojo feature flag for tests

Bug:  595685 
Change-Id: I1f92563fcbaeea7c521857ba236c5733f96ec6d8
Reviewed-on: https://chromium-review.googlesource.com/782561
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518891}
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/content/child/runtime_features.cc
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/content/public/common/content_features.cc
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/content/public/common/content_features.h
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/LayoutTests/virtual/mojo-notifications/http/tests/notifications/README.txt
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/bce083220582169c3bfddb603a7e2b818850c576/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db4af372b6675e54dc05fbf18880285732ee905

commit 2db4af372b6675e54dc05fbf18880285732ee905
Author: Anita Woodruff <awdf@chromium.org>
Date: Thu Nov 23 14:00:59 2017

[Layout Tests] Added tests for notification onshow event

- Previously the onshow event was only tested implicitly within the
click-* and close-* tests.

- Added an explicit test as a precursor to migrating the notification
Show() path to mojo independently of the other notification methods.
(Migration will be implemented incrementally using a runtime flag
only enabled in a virtual test suite during development).

Bug:  595685 
Change-Id: I388fd414f786078a3e39da66240501c9d4628f74
Reviewed-on: https://chromium-review.googlesource.com/787652
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518919}
[add] https://crrev.com/2db4af372b6675e54dc05fbf18880285732ee905/third_party/WebKit/LayoutTests/http/tests/notifications/resources/show-event-test.js
[add] https://crrev.com/2db4af372b6675e54dc05fbf18880285732ee905/third_party/WebKit/LayoutTests/http/tests/notifications/show-dedicated-worker.html
[add] https://crrev.com/2db4af372b6675e54dc05fbf18880285732ee905/third_party/WebKit/LayoutTests/http/tests/notifications/show-document.html
[add] https://crrev.com/2db4af372b6675e54dc05fbf18880285732ee905/third_party/WebKit/LayoutTests/http/tests/notifications/show-shared-worker.html

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e38b49817e932d3020ebda23493d6cb021a025

commit d6e38b49817e932d3020ebda23493d6cb021a025
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Nov 28 20:37:43 2017

Stop passing the origin in the GetPermissionStatus() call for notifications

We can make the browser process authoritative by having the interface
request be routed through RendererInterfaceBinders.

A consequence of this is that we no longer will be able to establish a
connection after the context is destroyed. That's fine, but leads to a
minor change in behaviour: when calling Notification.permission from
a detached context, it will now always return "denied".

Other features tend to reject the promise in this situation, but we
don't have one of those. Throwing when accessing the property will
definitely have (bad) side effects.

Bug:  595685 
Change-Id: I51b988cedabd0689bb118a3d841a6864eb64a24a
Reviewed-on: https://chromium-review.googlesource.com/791550
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519820}
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/browser/renderer_interface_binders.cc
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/LayoutTests/http/tests/notifications/request-permission-detached-context.html
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/d6e38b49817e932d3020ebda23493d6cb021a025/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Comment 24 by peter@chromium.org, Nov 30 2017

Blockedon: 729021
Cc: noel@chromium.org
Based on conversation with Noel: we're now using RendererInterfaceBinders for making the browser process authoritative about the origin (#c23), which is much better, but there is a known race condition for non-sync Mojo calls.

It's OK to continue development behind a flag, but we shouldn't enable the new Mojo-based code path by default until Issue 729021 has been fixed. Balazs (engedy@) is actively working on that.

Comment 25 by noel@chromium.org, Nov 30 2017

Cc: slangley@chromium.org sa...@chromium.org

Comment 26 by noel@chromium.org, Dec 1 2017

> we're now using RendererInterfaceBinders for making the browser process authoritative about the origin (#c23), which is much better, but there is a known race condition for non-sync Mojo calls.

Yeap.  The race potential is that the Origin is read on the browser-side, instead of using the Origin provided by the renderer in the API request.

Note that if you do need to move ahead, and not worry about issue 729021 for now, there's a subtle way to use RendererInterfaceBinders (RIB) for the non-sync case that sammc@ recommended.

  - move your stuff into RIB
  - but leave the Origin on the API (so no change in behavior)
  - add a TODO to remove the Origin from the API later

HTH.
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e001c61097751c73ecf8fce3bb8c780a926c68ac

commit e001c61097751c73ecf8fce3bb8c780a926c68ac
Author: Peter Beverloo <peter@chromium.org>
Date: Fri Dec 01 17:55:04 2017

Remove blink::mojom::NotificationService from service_manager:connector

A connection is now always obtained through one of the navigation:*
interface providers, so it doesn't have to be in this one anymore.

Bug:  595685 
Change-Id: I280dfce5d876329baff8f469790ded8b320ae7ca
Reviewed-on: https://chromium-review.googlesource.com/796412
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520981}
[modify] https://crrev.com/e001c61097751c73ecf8fce3bb8c780a926c68ac/content/public/app/mojo/content_browser_manifest.json

Project Member

Comment 28 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5

commit 0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5
Author: Anita Woodruff <awdf@chromium.org>
Date: Thu Dec 07 15:22:10 2017

[Mojoification] Hook up DisplayNonPersistentNotification()

- When run with --enable-blink-features=NotificationsWithMojo,
notification-showing now goes through Mojo.

- Tested manually that a notification with the expected origin
and title displays when a non-persistent notification is shown.

- All other notification data still needs to be hooked up.

- Notification events are also not yet implemented, so this patch
updates the virtual TestExpectations to skip these/expect timeouts.

Bug:  595685 
Change-Id: I3f74f0f434db1e639da1b753554e7c4776b58448
Reviewed-on: https://chromium-review.googlesource.com/788153
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522429}
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/LayoutTests/http/tests/notifications/notification-creation-detached-context.html
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/LayoutTests/http/tests/notifications/request-permission-detached-context.html
[rename] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/LayoutTests/http/tests/notifications/resources/window-detached-context.html
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/0c787794fc5cf92cb41bb5c0d53d3499e9fe6cf5/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Project Member

Comment 29 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf2f6b30521dca16eb0873a76ecc9b06f64fedb7

commit cf2f6b30521dca16eb0873a76ecc9b06f64fedb7
Author: Anita Woodruff <awdf@chromium.org>
Date: Wed Dec 13 14:35:56 2017

[Notification Mojoification] Set runtime flag enabled when it should be

- This omission was purely an oversight when the flag was added in
crrev.com/782561

Bug:  595685 
Change-Id: I52d852b924047f76defed5ac08009afc8e7023c1
Reviewed-on: https://chromium-review.googlesource.com/824262
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523770}
[modify] https://crrev.com/cf2f6b30521dca16eb0873a76ecc9b06f64fedb7/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd1fa7e795750ca1bf07fb982ca42caca776feb5

commit fd1fa7e795750ca1bf07fb982ca42caca776feb5
Author: Anita Woodruff <awdf@chromium.org>
Date: Mon Dec 18 16:34:14 2017

[Notifications] Rename non_persistent_notification_id to request_id

- Now all the integer ids are request ids to avoid confusion with the
string notification ids.

Bug:  595685 
Change-Id: Idd8008f59bb4a3db8eadf1455c6185fc7a01b338
Reviewed-on: https://chromium-review.googlesource.com/829553
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524725}
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_event_dispatcher_impl.h
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_id_generator.cc
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_id_generator.h
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/common/platform_notification_messages.h
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/renderer/notifications/notification_manager.cc
[modify] https://crrev.com/fd1fa7e795750ca1bf07fb982ca42caca776feb5/content/renderer/notifications/notification_manager.h

Project Member

Comment 31 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5fb71ede8b4076f9ebd01bb033ed870c8b204e8

commit e5fb71ede8b4076f9ebd01bb033ed870c8b204e8
Author: Anita Woodruff <awdf@chromium.org>
Date: Tue Dec 19 13:28:29 2017

[Notifications] Browser tests for non-persistent notifications

-  This CL adds a test for non-persistent notification properties,
(previously only persistent notification properties were tested
with a browser test).

- Also added a skeleton test for non-persistent notifications with
mojo enabled - custom properties are not yet supported when this
flag is enabled, but we can at least test that the right number
of notifications are displayed. (Had to start generating a
notification id and stop waiting for the notification event to
arrive to make this pass.)

Bug:  595685 
Change-Id: Icf666e605ed8e7cde21424f8fce1627d5b47778f
Reviewed-on: https://chromium-review.googlesource.com/822262
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525011}
[modify] https://crrev.com/e5fb71ede8b4076f9ebd01bb033ed870c8b204e8/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/e5fb71ede8b4076f9ebd01bb033ed870c8b204e8/chrome/test/data/notifications/platform_notification_service.html
[modify] https://crrev.com/e5fb71ede8b4076f9ebd01bb033ed870c8b204e8/content/browser/notifications/blink_notification_service_impl.cc

Comment 32 by awdf@chromium.org, Dec 21 2017

Blockedon: 796990

Comment 33 by awdf@chromium.org, Dec 21 2017

Blockedon: 796991

Comment 34 by awdf@chromium.org, Dec 21 2017

Splitting out two sub-issues of this bug:
1. Non persistent notifications (in progress) -  Issue 796990 
2. Persistent notifications (not started) -  Issue 796991 

Comment 35 by awdf@chromium.org, Jan 5 2018

Blocking: 774740
Project Member

Comment 36 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de15be70a17bce0000e0ab476120dd90a063360

commit 3de15be70a17bce0000e0ab476120dd90a063360
Author: Anita Woodruff <awdf@chromium.org>
Date: Wed Jan 17 12:06:11 2018

[Mojoification] Add notification.mojom with struct traits

- Added NotificationData mojo struct and struct traits to
allow conversion to/from blink::WebNotificationData and
content::PlatformNotificationData.

- The struct traits live in //content/common/ for now because there
is still event dispatching code in //content/renderer/. Once
mojification is complete, they can be moved to //content/browser/.

- Note the mojo pathway is still behind the NotificationsWithMojo
flag while development continues.

Bug:  595685 ,  796990 ,  796991 
Change-Id: I60e195f8c0bf9a2c0e8f9dc78ebaf95349b738c8
Reviewed-on: https://chromium-review.googlesource.com/832396
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529718}
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/browser/notifications/OWNERS
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/BUILD.gn
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/DEPS
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/OWNERS
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/notification_struct_traits.cc
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/notification_struct_traits.h
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/notification_struct_traits_unittest.cc
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/notifications/notification_types.typemap
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/common/typemaps.gni
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/content/test/BUILD.gn
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/platform/mojo/NotificationStructTraits.cpp
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/platform/mojo/NotificationStructTraits.h
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/platform/mojo/NotificationStructTraitsTest.cpp
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/public/platform/modules/notifications/NotificationTypes.typemap
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/public/platform/modules/notifications/OWNERS
[add] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/public/platform/modules/notifications/notification.mojom
[modify] https://crrev.com/3de15be70a17bce0000e0ab476120dd90a063360/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e3c370f735edef8128ae377f6fe163e02df2b0

commit b0e3c370f735edef8128ae377f6fe163e02df2b0
Author: Anita Woodruff <awdf@chromium.org>
Date: Fri Jan 19 19:45:50 2018

[Mojoification] Add notification resources

- Added NotificationResources mojo struct and struct traits to
allow conversion to/from blink::WebNotificationResources and
content::NotificationResources.

- The struct traits live in //content/common/ for now because there
is still event dispatching code in //content/renderer/. Once
mojification is complete, they can be moved to //content/browser/.

- Note the mojo pathway is still behind the NotificationsWithMojo
flag while development continues.

Bug:  595685 ,  796990 ,  796991 
Change-Id: I82955f5d072545a66c31e8a7a502ac36eb8b6008
Reviewed-on: https://chromium-review.googlesource.com/874692
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530585}
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/common/notifications/notification_struct_traits.cc
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/common/notifications/notification_struct_traits.h
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/common/notifications/notification_struct_traits_unittest.cc
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/content/common/notifications/notification_types.typemap
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/modules/notifications/NotificationManager.h
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/platform/mojo/DEPS
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/platform/mojo/NotificationStructTraits.cpp
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/platform/mojo/NotificationStructTraits.h
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/Source/platform/mojo/NotificationStructTraitsTest.cpp
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/public/platform/modules/notifications/NotificationTypes.typemap
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/public/platform/modules/notifications/notification.mojom
[modify] https://crrev.com/b0e3c370f735edef8128ae377f6fe163e02df2b0/third_party/WebKit/public/platform/modules/notifications/notification_service.mojom

Comment 38 by awdf@chromium.org, Apr 23 2018

Blockedon: -729021
Issue 729021 has progressed enough that we're no longer blocked on it completing, according to peter@
Status: Fixed (was: Started)
Project Member

Comment 40 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf70c90e75549b9de74c38c912ced29e52b6d037

commit bf70c90e75549b9de74c38c912ced29e52b6d037
Author: Han Leon <leon.han@intel.com>
Date: Thu Aug 30 01:22:16 2018

[OnionSoup] Use mojom NotificationData instead of WebNotificationData inside Blink

This CL is part of Onion Soup effort for Notification APIs, trying to
use blink::mojom::blink::NotificationData everywhere instead of
blink::WebNotificationData inside Blink.

Also, this CL removes typemapping between blink::WebNotificationData and
blink.mojom.NotificationData, thus building notification.mojom no longer
needs to depend on WebXXX types, which makes it possible for us to move
notification.mojom into blink/public/mojom/notifications/ for next step,
further, notification.mojom movement will facilitate moving
content/common/service_worker/service_worker.mojom into
blink/public/mojom/ in future.

After this CL, the only usage of blink::WebNotificationData is to carry
notification data from Content layer into Blink, which is dispatched via
content.mojom.ServiceWorker.DispatchNotification{Click, Close}Event.

BUG= 595685 ,789854

Change-Id: I2ce6141c55fe874ab11f9f236b4734b9a9d79617
Reviewed-on: https://chromium-review.googlesource.com/1192360
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587362}
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/content/common/notifications/notification_struct_traits.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/content/common/notifications/notification_struct_traits.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/public/platform/modules/notifications/notification.mojom
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/public/platform/modules/notifications/notification_types.typemap
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/public/platform/modules/notifications/web_notification_data.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data_test.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_manager.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader_test.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits.cc
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits.h
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits_test.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b17c0711807cf41c608bdf52b4a6696f53ef3c79

commit b17c0711807cf41c608bdf52b4a6696f53ef3c79
Author: Han Leon <leon.han@intel.com>
Date: Wed Sep 05 02:30:47 2018

[OnionSoup] Move image validation out of notification struct traits

Currently blink.mojom.NotificationResources is typemapped with
content::NotificationResources, and its struct traits impl depends on
content/public/common/content_features.h to do some custom validation
against the notification image, which makes it hard to move these struct
traits into Blink.
This CL moves such validation out of struct traits to the receiver of
messages : content::BlinkNotificationServiceImpl.

BUG= 595685 

Change-Id: I5b2990da087d7e2e3ba30e80973d396632b5d15b
Reviewed-on: https://chromium-review.googlesource.com/1201903
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#588743}
[modify] https://crrev.com/b17c0711807cf41c608bdf52b4a6696f53ef3c79/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/b17c0711807cf41c608bdf52b4a6696f53ef3c79/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/b17c0711807cf41c608bdf52b4a6696f53ef3c79/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/b17c0711807cf41c608bdf52b4a6696f53ef3c79/content/common/notifications/notification_struct_traits.cc
[modify] https://crrev.com/b17c0711807cf41c608bdf52b4a6696f53ef3c79/content/common/notifications/notification_struct_traits_unittest.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95

commit 96d6b6e8c279a9e463ff7cd7e2408b409e43ef95
Author: Han Leon <leon.han@intel.com>
Date: Thu Sep 06 06:21:06 2018

[OnionSoup] Move notification.mojom into blink/public/mojom/

This CL is part of Onion Soup effort for Notification APIs, moving
notification.mojom from blink/public/platform/modules/notifications/
into blink/public/mojom/notifications/, which facilitates moving
content/common/service_worker/service_worker.mojom into
blink/public/mojom/ in future.

This CL:
  - moves notification.mojom into blink/public/mojom/notifications/.
  - moves those native types typemapped with notification.mojom mojom
    types from content/public/common into Blink common:
        content::PlatformNotificationData
     -> blink::PlatformNotificationData
        content::PlatformNotificationData::Direction
     -> blink::PlatformNotificationData::Direction
        content::NotificationResources
     -> blink::NotificationResources
  - of course, moves the corresponding struct traits from Content common
    into Blink common as well.

BUG= 595685 , 789846 

Change-Id: Id4e43f5f290ee248ee29e71cb05b62197b47c180
Reviewed-on: https://chromium-review.googlesource.com/1195114
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589107}
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/notifications/persistent_notification_handler_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/chrome/browser/push_messaging/push_messaging_notification_manager.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/notification_database_data.proto
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/notification_database_data_conversions.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/notification_database_data_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/notification_database_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/common/BUILD.gn
[delete] https://crrev.com/4a86825c52dab5f6a1df2c7298b279bedc4bdfe7/content/common/notifications/DEPS
[delete] https://crrev.com/4a86825c52dab5f6a1df2c7298b279bedc4bdfe7/content/common/notifications/notification_struct_traits.h
[delete] https://crrev.com/4a86825c52dab5f6a1df2c7298b279bedc4bdfe7/content/common/notifications/notification_types.typemap
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/common/typemaps.gni
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/public/browser/notification_database_data.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/public/common/BUILD.gn
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/renderer/notifications/notification_data_conversions.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/renderer/notifications/notification_data_conversions.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/renderer/notifications/notification_data_conversions_unittest.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/test/BUILD.gn
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/test/mock_platform_notification_service.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/content/test/mock_platform_notification_service.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/notifications/OWNERS
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/notifications/notification_resources.cc
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/notifications/notification_struct_traits.cc
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/notifications/notification_struct_traits_unittest.cc
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/notifications/platform_notification_data.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/common/test/run_all_unittests.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/DEPS
[copy] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/notifications/OWNERS
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/notifications/notification_resources.h
[add] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/notifications/notification_struct_traits.h
[add] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/notifications/notification_types.typemap
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/common/notifications/platform_notification_data.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/mojom/notifications/OWNERS
[rename] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/mojom/notifications/notification.mojom
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/platform/modules/notifications/notification_service.mojom
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/renderer/modules/notifications/notification_data.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/renderer/modules/notifications/notification_resources_loader.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.h
[modify] https://crrev.com/96d6b6e8c279a9e463ff7cd7e2408b409e43ef95/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc

Sign in to add a comment