Issue metadata
Sign in to add a comment
|
Chrome looses the OFFLINE thunder icon in URL Omnibox when switched from incognito tab to non-incognito tab
Reported by
ahalder@etouch.net,
Mar 17 2016
|
||||||||||||||||||||
Issue descriptionApplication Version: Chrome Dev 51.0.2681.0 Android Build Number: 5.0.1/LRX22C.I9500XXUHOK2 Device: Samsung Galaxy S4 Pre-condition: 1. 'Enabled as saved pages' flag should be ENABLED under chrome://flags 2. 'Merge tabs and apps' mode should be ON 3. Save a page offline ex. m.gsmarena.com (make sure the page you save offline doesn't update the URL omnibox color like for ex. m.facebook.com) Steps to reproduce: 1. Turn WiFi / data connection OFF > Launch Chrome 2. Open the offline saved page > Observe the Offline icon in URL Omnibox 3. Now open an incognito tab > Perform step 2 4. Close the incognito tab from 'Close all incognito tab' Chrome notification > Observe the Offline icon in URL Omnibox of the non-incognito tab 5. Open an NTP > Perform steps 2 and 3 again 6. Switch back to non-incognito tab now > Observe the Offline icon in URL Omnibox of the non-incognito tab Observed behavior: Chrome looses the OFFLINE thunder icon in URL Omnibox when switched from incognito tab to non-incognito tab Expected behavior: Chrome should maintain the OFFLINE thunder icon in URL Omnibox when switched from incognito tab to non-incognito tab Frequency: <5/5> Additional comments: Last Good Build: 50.0.2661.17 First Bad Build: 50.0.2661.18 This issue is seen on Android L and M devices ex. Spice Mi-498 (6.0/MRA58M), Samsung Galaxy S4 (5.0.1/LRX22C), Karbonn Sparkle V (5.1.1/LMY47V), Micromax Canvas A1 (6.0.1/MMB29Q), Moto G 2nd Gen (5.0.2/LXB22.99-16.3)
,
Mar 17 2016
,
Mar 21 2016
https://codereview.chromium.org/1821003003/
,
Mar 22 2016
Patchset was landed, but the bug was not updated for some reason: https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95 Cr-Commit-Position: refs/heads/master@{#382445}
,
Mar 22 2016
,
Mar 23 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1e097fb6fa1e1cd303ebe2bd12d2a01267906cb commit c1e097fb6fa1e1cd303ebe2bd12d2a01267906cb Author: Filip Gorski <fgorski@chromium.org> Date: Wed Mar 23 15:43:02 2016 [Offline pages] Fixing disappearing bolt when switching from incognito This patch fixes the following issue: When switching form an incognito tab with offline page opened, to a regular tab with an offline page, the status gets updated to the correct color, but the icon disappears, or actually does not get updated. This happens when tabs are merged with other applications only, which is only affecting phones. BUG= 595649 Review URL: https://codereview.chromium.org/1821003003 Cr-Commit-Position: refs/heads/master@{#382445} (cherry picked from commit eb2e9f919ec99512c32c5c7879f28d0df23cbe95) Review URL: https://codereview.chromium.org/1822103004 . Cr-Commit-Position: refs/branch-heads/2661@{#356} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/c1e097fb6fa1e1cd303ebe2bd12d2a01267906cb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
,
Mar 23 2016
,
Mar 30 2016
This issue is now not reproducible on latest M50-50.0.2661.57 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dknandiraju@chromium.org
, Mar 17 2016