New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595646 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue v8:4690
issue v8:4981
issue 608287

Blocking:
issue v8:4866
issue 602214



Sign in to add a comment

Incorrect line numbers for throw messages and stack trace in ignition

Project Member Reported by mythria@chromium.org, Mar 17 2016

Issue description

There are few layout tests that fail because interpreter does not have correct translation to source line numbers. The following are the tests that fail:

fast/dom/error-to-string-stack-overflow.html
fast/events/window-onerror-06.html
fast/events/window-onerror-10.html
fast/events/window-onerror-12.html
fast/events/window-onerror-isolatedworld-01.html
fast/events/window-onerror-isolatedworld-02.html
inspector/console/console-stack-overflow.html
virtual/pointerevent/fast/events/window-onerror-06.html
virtual/pointerevent/fast/events/window-onerror-10.html
virtual/pointerevent/fast/events/window-onerror-12.html
virtual/pointerevent/fast/events/window-onerror-isolatedworld-01.html
virtual/pointerevent/fast/events/window-onerror-isolatedworld-02.html
virtual/trustedeventsdefaultaction/fast/events/window-onerror-06.html
virtual/trustedeventsdefaultaction/fast/events/window-onerror-10.html
virtual/trustedeventsdefaultaction/fast/events/window-onerror-12.html
virtual/trustedeventsdefaultaction/fast/events/window-onerror-isolatedworld-01.html
virtual/trustedeventsdefaultaction/fast/events/window-onerror-isolatedworld-02.html
inspector/console/console-log-linkify-stack-in-errors.html
inspector/sources/debugger-async/async-operation-breakpoints.html
inspector/sources/debugger-async/async-operation-events.html
inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html
inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
inspector/sources/debugger-pause/pause-on-elements-panel.html
inspector/sources/debugger-step/debugger-step-into-across-timeouts.html
inspector/sources/debugger-step/debugger-step-into-async1.html
inspector/sources/debugger-step/debugger-step-into-async2.html
inspector/sources/debugger-step/debugger-step-out-across-timeouts.html
inspector/sources/debugger-step/debugger-step-out-event-listener.html
inspector/sources/debugger-step/debugger-step-over-across-timeouts.html
inspector/sources/debugger-step/step-through-event-listeners.html
inspector/sources/debugger/debugger-compile-and-run.html
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
inspector-protocol/debugger/continueToLocation.html
inspector-protocol/debugger/setScriptSource.html

 
Blockedon: v8:4690
Blocking: v8:4866
Blocking: 602214
Cc: -yangguo@chromium.org
Owner: yangguo@chromium.org
These tests no longer fail:

inspector/console/console-log-linkify-stack-in-errors.html
inspector/sources/debugger/debugger-compile-and-run.html


These tests no longer exist:

inspector/sources/debugger-async/async-operation-breakpoints.html
inspector/sources/debugger-async/async-operation-events.html
inspector/sources/debugger-step/debugger-step-into-async1.html
inspector/sources/debugger-step/debugger-step-into-async2.html
#5 should have fixed all async stepping related failures.
Status: Started (was: Available)
Blockedon: v8:4981
Project Member

Comment 9 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94271b31605e73c7111bdc7049c111277e0b575a

commit 94271b31605e73c7111bdc7049c111277e0b575a
Author: yangguo <yangguo@chromium.org>
Date: Mon May 02 08:23:29 2016

LayoutTests: adapt inspector debug step test to V8's interpreter.

When debugging using V8's interpreter, there are slight differences at
return statements that directly returns the value of the previous
statement. This fixes the test case to work regardless of the
difference.

R=machenbach@chromium.org, rmcilroy@chromium.org
BUG= chromium:595646 

Review-Url: https://codereview.chromium.org/1940793002
Cr-Commit-Position: refs/heads/master@{#390904}

[modify] https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises-expected.txt
[modify] https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises.html

Blockedon: 608287
Dependencies for the remaining test failures:

Blocked on v8:4981 (Interpreter bug at stack overflow)
inspector/console/console-stack-overflow.html
fast/dom/error-to-string-stack-overflow.html

Blocked on chromium:608287 (Needs to rebaseline test expectation)
inspector/sources/debugger-frameworks/frameworks-jquery.html

Blocked on v8:4765 (LiveEdit)
inspector-protocol/debugger/setScriptSource


Project Member

Comment 12 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898

commit fbb9c98e14eedc0e1177c5919ea078a5ef1e0898
Author: yangguo <yangguo@chromium.org>
Date: Mon May 02 13:23:11 2016

LayoutTests: adapt framework blackboxing test to V8's interpreter.

When debugging using V8's interpreter, there are slight differences at
return statements that directly returns the value of the previous
statement. This fixes the test case to work regardless of the
difference.

R=machenbach@chromium.org, rmcilroy@chromium.org
BUG= chromium:595646 

Review-Url: https://codereview.chromium.org/1936993002
Cr-Commit-Position: refs/heads/master@{#390929}

[modify] https://crrev.com/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html

These are all fixed now \o/! Thanks Yang.
Status: Fixed (was: Started)

Sign in to add a comment