Incorrect line numbers for throw messages and stack trace in ignition |
||||||||
Issue descriptionThere are few layout tests that fail because interpreter does not have correct translation to source line numbers. The following are the tests that fail: fast/dom/error-to-string-stack-overflow.html fast/events/window-onerror-06.html fast/events/window-onerror-10.html fast/events/window-onerror-12.html fast/events/window-onerror-isolatedworld-01.html fast/events/window-onerror-isolatedworld-02.html inspector/console/console-stack-overflow.html virtual/pointerevent/fast/events/window-onerror-06.html virtual/pointerevent/fast/events/window-onerror-10.html virtual/pointerevent/fast/events/window-onerror-12.html virtual/pointerevent/fast/events/window-onerror-isolatedworld-01.html virtual/pointerevent/fast/events/window-onerror-isolatedworld-02.html virtual/trustedeventsdefaultaction/fast/events/window-onerror-06.html virtual/trustedeventsdefaultaction/fast/events/window-onerror-10.html virtual/trustedeventsdefaultaction/fast/events/window-onerror-12.html virtual/trustedeventsdefaultaction/fast/events/window-onerror-isolatedworld-01.html virtual/trustedeventsdefaultaction/fast/events/window-onerror-isolatedworld-02.html inspector/console/console-log-linkify-stack-in-errors.html inspector/sources/debugger-async/async-operation-breakpoints.html inspector/sources/debugger-async/async-operation-events.html inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html inspector/sources/debugger-breakpoints/event-listener-breakpoints.html inspector/sources/debugger-pause/pause-on-elements-panel.html inspector/sources/debugger-step/debugger-step-into-across-timeouts.html inspector/sources/debugger-step/debugger-step-into-async1.html inspector/sources/debugger-step/debugger-step-into-async2.html inspector/sources/debugger-step/debugger-step-out-across-timeouts.html inspector/sources/debugger-step/debugger-step-out-event-listener.html inspector/sources/debugger-step/debugger-step-over-across-timeouts.html inspector/sources/debugger-step/step-through-event-listeners.html inspector/sources/debugger/debugger-compile-and-run.html inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html inspector-protocol/debugger/continueToLocation.html inspector-protocol/debugger/setScriptSource.html
,
Mar 24 2016
,
Apr 11 2016
,
Apr 28 2016
These tests no longer fail: inspector/console/console-log-linkify-stack-in-errors.html inspector/sources/debugger/debugger-compile-and-run.html These tests no longer exist: inspector/sources/debugger-async/async-operation-breakpoints.html inspector/sources/debugger-async/async-operation-events.html inspector/sources/debugger-step/debugger-step-into-async1.html inspector/sources/debugger-step/debugger-step-into-async2.html
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5ea84123040a93948ef3e1c49ff53f0c8e6dba33 commit 5ea84123040a93948ef3e1c49ff53f0c8e6dba33 Author: yangguo <yangguo@chromium.org> Date: Thu Apr 28 13:16:48 2016 [debugger,interpreter] add source position to stack checks. DevTools uses the debug interrupt to trap on function entry. Without source position at the stack check, we would get bogus source positions. R=mstarzinger@chromium.org BUG= chromium:595646 LOG=N Review-Url: https://codereview.chromium.org/1925063002 Cr-Commit-Position: refs/heads/master@{#35864} [modify] https://crrev.com/5ea84123040a93948ef3e1c49ff53f0c8e6dba33/src/interpreter/bytecode-array-builder.cc [modify] https://crrev.com/5ea84123040a93948ef3e1c49ff53f0c8e6dba33/src/interpreter/bytecode-array-builder.h [modify] https://crrev.com/5ea84123040a93948ef3e1c49ff53f0c8e6dba33/src/interpreter/bytecode-generator.cc [add] https://crrev.com/5ea84123040a93948ef3e1c49ff53f0c8e6dba33/test/mjsunit/debug-stack-check-position.js [modify] https://crrev.com/5ea84123040a93948ef3e1c49ff53f0c8e6dba33/test/unittests/interpreter/bytecode-array-builder-unittest.cc
,
Apr 29 2016
#5 should have fixed all async stepping related failures.
,
Apr 29 2016
,
May 2 2016
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94271b31605e73c7111bdc7049c111277e0b575a commit 94271b31605e73c7111bdc7049c111277e0b575a Author: yangguo <yangguo@chromium.org> Date: Mon May 02 08:23:29 2016 LayoutTests: adapt inspector debug step test to V8's interpreter. When debugging using V8's interpreter, there are slight differences at return statements that directly returns the value of the previous statement. This fixes the test case to work regardless of the difference. R=machenbach@chromium.org, rmcilroy@chromium.org BUG= chromium:595646 Review-Url: https://codereview.chromium.org/1940793002 Cr-Commit-Position: refs/heads/master@{#390904} [modify] https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises-expected.txt [modify] https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises.html
,
May 2 2016
,
May 2 2016
Dependencies for the remaining test failures: Blocked on v8:4981 (Interpreter bug at stack overflow) inspector/console/console-stack-overflow.html fast/dom/error-to-string-stack-overflow.html Blocked on chromium:608287 (Needs to rebaseline test expectation) inspector/sources/debugger-frameworks/frameworks-jquery.html Blocked on v8:4765 (LiveEdit) inspector-protocol/debugger/setScriptSource
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898 commit fbb9c98e14eedc0e1177c5919ea078a5ef1e0898 Author: yangguo <yangguo@chromium.org> Date: Mon May 02 13:23:11 2016 LayoutTests: adapt framework blackboxing test to V8's interpreter. When debugging using V8's interpreter, there are slight differences at return statements that directly returns the value of the previous statement. This fixes the test case to work regardless of the difference. R=machenbach@chromium.org, rmcilroy@chromium.org BUG= chromium:595646 Review-Url: https://codereview.chromium.org/1936993002 Cr-Commit-Position: refs/heads/master@{#390929} [modify] https://crrev.com/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
,
Jun 10 2016
These are all fixed now \o/! Thanks Yang.
,
Jun 10 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mythria@chromium.org
, Mar 17 2016