Version: 51 OS: Android Part of the Ballista project (https://github.com/chromium/ballista). Experimentally implement the Share API on Android.
WIP CLs: 1. https://codereview.chromium.org/1806253002/ 2. https://codereview.chromium.org/1814133002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eeea499401e03bcf098437d92bf35cf10ba4675 commit 4eeea499401e03bcf098437d92bf35cf10ba4675 Author: mgiuca <mgiuca@chromium.org> Date: Wed Apr 27 06:25:38 2016 Added navigator.actions.share experimental web API (stub). Requires the enable-experimental-web-platform-features flag. Currently does nothing; future CLs will implement this on Android as an experiment. BUG=595608 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1806253002 Cr-Commit-Position: refs/heads/master@{#390004} [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/ballista/resources/mock-ballista-service.js [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/ballista/share-arity.html [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/ballista/share-error.html [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/ballista/share-success.html [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/ballista/share-types.html [modify] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/Actions.cpp [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/Actions.h [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/Actions.idl [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/NavigatorActions.cpp [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/NavigatorActions.h [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/NavigatorActions.idl [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/ballista/OWNERS [modify] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/modules/modules.gypi [modify] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in [modify] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/public/blink.gyp [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/public/platform/modules/ballista/OWNERS [add] https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675/third_party/WebKit/public/platform/modules/ballista/ballista.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c commit dd70f8bd8dec6675360f79b1cdfcc8c98e87053c Author: mgiuca <mgiuca@chromium.org> Date: Wed Apr 27 07:17:09 2016 Revert of Added navigator.actions.share experimental web API (stub). (patchset #19 id:460001 of https://codereview.chromium.org/1806253002/ ) Reason for revert: The LayoutTests added by this CL are failing on Mac bots. BUG= 607086 Original issue's description: > Added navigator.actions.share experimental web API (stub). > > Requires the enable-experimental-web-platform-features flag. Currently > does nothing; future CLs will implement this on Android as an > experiment. > > BUG=595608 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/4eeea499401e03bcf098437d92bf35cf10ba4675 > Cr-Commit-Position: refs/heads/master@{#390004} TBR=mkwst@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595608 Review URL: https://codereview.chromium.org/1924753002 Cr-Commit-Position: refs/heads/master@{#390009} [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/LayoutTests/ballista/resources/mock-ballista-service.js [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/LayoutTests/ballista/share-arity.html [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/LayoutTests/ballista/share-error.html [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/LayoutTests/ballista/share-success.html [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/LayoutTests/ballista/share-types.html [modify] https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/Actions.cpp [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/Actions.h [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/Actions.idl [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/NavigatorActions.cpp [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/NavigatorActions.h [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/NavigatorActions.idl [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/Source/modules/ballista/OWNERS [modify] https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c/third_party/WebKit/Source/modules/modules.gypi [modify] https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in [modify] https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/dd70f8bd8dec6675360f79b1cdfcc8c98e87053c/third_party/WebKit/public/blink.gyp [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/public/platform/modules/ballista/OWNERS [delete] https://crrev.com/04a12d0b4696b365f89f7b867f360dc0cb1a1f60/third_party/WebKit/public/platform/modules/ballista/ballista.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d123f9a4d82543ae3769094df5c4cac24cd2d693 commit d123f9a4d82543ae3769094df5c4cac24cd2d693 Author: mgiuca <mgiuca@chromium.org> Date: Tue Jul 12 00:59:09 2016 Added Web Share (navigator.share) experimental web API (stub). Requires the enable-experimental-web-platform-features flag. Currently does nothing; future CLs will implement this on Android as an experiment. Re-land of r390004. BUG=595608 Review-Url: https://codereview.chromium.org/1806253002 Cr-Commit-Position: refs/heads/master@{#404759} [modify] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webshare/share-arity.html [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webshare/share-error.html [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webshare/share-success.html [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/LayoutTests/webshare/share-types.html [modify] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/modules/modules.gypi [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/modules/webshare/NavigatorShare.h [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/modules/webshare/OWNERS [modify] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in [modify] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/public/blink.gyp [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/public/platform/modules/webshare/OWNERS [add] https://crrev.com/d123f9a4d82543ae3769094df5c4cac24cd2d693/third_party/WebKit/public/platform/modules/webshare/webshare.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5 commit cd237c67f5dd71579483a6ca33e3e0bc947ff4e5 Author: mgiuca <mgiuca@chromium.org> Date: Tue Aug 02 02:11:47 2016 Added experimental Web Share API on Android behind flag. On Android, navigator.share now sends a system intent. Requires the enable-experimental-web-platform-features flag. BUG=595608 Review-Url: https://codereview.chromium.org/1814133002 Cr-Commit-Position: refs/heads/master@{#409121} [modify] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java [add] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java [add] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java [modify] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/chrome/android/java_sources.gni [modify] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/cd237c67f5dd71579483a6ca33e3e0bc947ff4e5/third_party/WebKit/public/platform/modules/webshare/webshare.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/610f5e1ea1b1b38926263489d3d235fc834686de commit 610f5e1ea1b1b38926263489d3d235fc834686de Author: mgiuca <mgiuca@chromium.org> Date: Tue Aug 09 00:16:46 2016 navigator.share: Resolve promise only after user chooses a target. Previously, would immediately resolve as soon as the share dialog was shown. This introduces a new issue where the promise *never* resolves or rejects if the user cancels the share picker (I'm not sure how to do this or if it's even possible). Introduces a bunch of new functionality in the ShareHelper class to support this new use case. BUG=595608 Review-Url: https://codereview.chromium.org/2203273002 Cr-Commit-Position: refs/heads/master@{#410511} [modify] https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java [modify] https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java [modify] https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b746d1fc69b4e2037479b97874ca4cea5ad0842 commit 8b746d1fc69b4e2037479b97874ca4cea5ad0842 Author: amineer <amineer@chromium.org> Date: Mon Aug 15 16:57:44 2016 Revert of navigator.share: Resolve promise only after user chooses a target. (patchset #5 id:80001 of https://codereview.chromium.org/2203273002/ ) Reason for revert: Looks to be causing a large number of crashes, see crbug.com/637194. Original issue's description: > navigator.share: Resolve promise only after user chooses a target. > > Previously, would immediately resolve as soon as the share dialog was > shown. This introduces a new issue where the promise *never* resolves > or rejects if the user cancels the share picker (I'm not sure how to do > this or if it's even possible). > > Introduces a bunch of new functionality in the ShareHelper class to > support this new use case. > > BUG=595608 > > Committed: https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de > Cr-Commit-Position: refs/heads/master@{#410511} TBR=dtrainor@chromium.org,mgiuca@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595608 Review-Url: https://codereview.chromium.org/2241303002 Cr-Commit-Position: refs/heads/master@{#411975} [modify] https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java [modify] https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java [modify] https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/906820b686d31b48d8c75e89ec3fe67b5c9f36b0 commit 906820b686d31b48d8c75e89ec3fe67b5c9f36b0 Author: mgiuca <mgiuca@chromium.org> Date: Tue Aug 16 05:57:35 2016 navigator.share: Resolve promise only after user chooses a target. Previously, would immediately resolve as soon as the share dialog was shown. This introduces a new issue where the promise *never* resolves or rejects if the user cancels the share picker (I'm not sure how to do this or if it's even possible). Introduces a bunch of new functionality in the ShareHelper class to support this new use case. Reland of https://crrev.com/410511 (to fix https://crbug.com/637194). BUG=595608,637194 Review-Url: https://codereview.chromium.org/2203273002 Cr-Commit-Position: refs/heads/master@{#412175} [modify] https://crrev.com/906820b686d31b48d8c75e89ec3fe67b5c9f36b0/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/906820b686d31b48d8c75e89ec3fe67b5c9f36b0/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java [modify] https://crrev.com/906820b686d31b48d8c75e89ec3fe67b5c9f36b0/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java [modify] https://crrev.com/906820b686d31b48d8c75e89ec3fe67b5c9f36b0/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java
Comment 1 by mgiuca@chromium.org
, Mar 31 2016