New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] Extra Text seen on scroll bar when select "Show scrolling perf issues" option in devTool

Project Member Reported by sb00348...@techmahindra.com, Mar 17 2016

Issue description

Version: 51.0.2681.0 dev
OS: Ubuntu 12.04,14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome go to NTP page >> open devtool
(2)Click on "Show scrolling perf issues" option from Rendering setting  in "Customized and control devTool" and observe marked screen shot.


What is the expected output? 
Text should not display on scroll bar.

What do you see instead?
Instead Extra Text is seen on top of the scroll bar.



good build:50.0.2634.0 dev
bad build:50.0.2635.0 dev

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/11ed0249bc070ad5541385aa8ee9a5704fe2c04f..ee0b6981de62e9a234d031eab793da8d7752197b

Suspecting https://codereview.chromium.org/1639363002

@dtapuska: Please help in re-assigning if it is not related to your change.

 
Actual.png
233 KB View Download
Expected.png
220 KB View Download
Labels: -Pri-2 ReleaseBlock-Stable OS-Mac Pri-1
Able to reproduce the issue on Mac 10.11 using chrome version 51.0.2681.0.

Adding the blocker label as this is recent regression.Please feel free to remove if not required.

Thanks,
Status: Started (was: Assigned)
Yes it appears to be mine.

Potential fix here: https://codereview.chromium.org/1810363002
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9

commit 8f35ce554d594f2069d7f4515602e3fb6a5fc5a9
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Mar 18 19:36:34 2016

Fix display of wheel event listeners on a page.

Fields were getting duplicated for scrollbars. Mark the entire
inner viewport as blocked on scroll if we have a wheel listener
we don't need to iterate the tree.

BUG= 595591 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1810363002

Cr-Commit-Position: refs/heads/master@{#382053}

[modify] https://crrev.com/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9/cc/debug/debug_rect_history.h

Status: Fixed (was: Started)
The double text is no longer displayed.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d17a1bfafce005d086278b83889fb5945ade2d1

commit 6d17a1bfafce005d086278b83889fb5945ade2d1
Author: leviw <leviw@chromium.org>
Date: Fri Mar 18 23:21:06 2016

Revert of Fix display of wheel event listeners on a page. (patchset #1 id:1 of https://codereview.chromium.org/1810363002/ )

Reason for revert:
Failing on continuous builders.

https://chromegw.corp.google.com/i/official.desktop.continuous/builders/win%20stable/builds/464/steps/compile/logs/stdio

BUG=596215

Original issue's description:
> Fix display of wheel event listeners on a page.
>
> Fields were getting duplicated for scrollbars. Mark the entire
> inner viewport as blocked on scroll if we have a wheel listener
> we don't need to iterate the tree.
>
> BUG= 595591 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/8f35ce554d594f2069d7f4515602e3fb6a5fc5a9
> Cr-Commit-Position: refs/heads/master@{#382053}

TBR=aelias@chromium.org,dtapuska@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 595591 

Review URL: https://codereview.chromium.org/1816723003

Cr-Commit-Position: refs/heads/master@{#382131}

[modify] https://crrev.com/6d17a1bfafce005d086278b83889fb5945ade2d1/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/6d17a1bfafce005d086278b83889fb5945ade2d1/cc/debug/debug_rect_history.h

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1936b3f6dcdd44c9a7db4e1686437568a7dd1aad

commit 1936b3f6dcdd44c9a7db4e1686437568a7dd1aad
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Mar 21 15:45:41 2016

Re-land fix display of wheel event listeners on a page.

Fields were getting duplicated for scrollbars. Mark the entire
inner viewport as blocked on scroll if we have a wheel listener
we don't need to iterate the tree.

This was reverted in https://codereview.chromium.org/1816723003 because
the sheriff thought it caused a build failure; but the actual failure was
from merge of https://chromium.googlesource.com/chromium/src/+/58cef5be289f5004932682c17694aaa7724bae70
and subsequent fix https://chromium.googlesource.com/chromium/src/+/98aba017dee34d0c08df009095e1fe7bbd6acb49

BUG= 595591 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/1816083002

Cr-Commit-Position: refs/heads/master@{#382295}

[modify] https://crrev.com/1936b3f6dcdd44c9a7db4e1686437568a7dd1aad/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/1936b3f6dcdd44c9a7db4e1686437568a7dd1aad/cc/debug/debug_rect_history.h

Labels: Hotlist-Input-Dev

Sign in to add a comment