New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595588 link

Starred by 1 user
Status: Fixed
Owner:
█ lshang@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
calamity@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD History: Show a spinner when new data is loading

Project Member Reported by tsergeant@chromium.org, Mar 17 2016 
What steps will reproduce the problem?
(1) Enable MD History
(2) Navigate to chrome://history
(3) Scroll to the bottom of the page

What is the expected output? What do you see instead?
I see new data pop in without any warning. I expect to see a spinner indicating that new data is loading.

It would also be good to show a spinner in the toolbar when data is loading from a search.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f88d690f487221c8a78d54e84c502155de80366

commit 3f88d690f487221c8a78d54e84c502155de80366
Author: lshang <lshang@chromium.org>
Date: Tue Apr 26 00:58:17 2016

MD History: Add spinners when new data is loading or searching

Add a spinner indicating that more history is loading when scroll down to the
bottom of the page.

Also add a spinner when searching terms in history.

BUG= 595588 

Review URL: https://codereview.chromium.org/1864023002

Cr-Commit-Position: refs/heads/master@{#389645}

[modify] https://crrev.com/3f88d690f487221c8a78d54e84c502155de80366/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/3f88d690f487221c8a78d54e84c502155de80366/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/3f88d690f487221c8a78d54e84c502155de80366/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/3f88d690f487221c8a78d54e84c502155de80366/chrome/browser/resources/md_history/history_toolbar.js
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc7b70947e4bb31adeab5d3e0f18564851eac21

commit dcc7b70947e4bb31adeab5d3e0f18564851eac21
Author: tsergeant <tsergeant@chromium.org>
Date: Tue May 03 22:28:46 2016

MD History: Remove spinner from the botttom of history-list

On the advice of UI, we are removing this spinner for the moment.
Depending on load speed in the wild, we may investigate adding a loading
message back in a way which doesn't overlay the content. The spinner
next to the search field is unchanged.

BUG= 595588 

Review-Url: https://codereview.chromium.org/1946493003
Cr-Commit-Position: refs/heads/master@{#391379}

[modify] https://crrev.com/dcc7b70947e4bb31adeab5d3e0f18564851eac21/chrome/browser/resources/md_history/history_list.html

Comment 3 by tsergeant@chromium.org, Jun 22 2016

Labels: Proj-MaterialDesign-WebUI
Status: Fixed (was: Assigned)
►

Sign in to add a comment