New issue
Advanced search Search tips

Issue 595584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

CC Animation: Perform optimizations

Project Member Reported by loyso@chromium.org, Mar 17 2016

Issue description

- Use bitset instead of unordered_set in LayerAnimationController
- Use unordered_map in AnimationTimeline
- Make cc::ElementAnimations move-only type so LayerToElementAnimationsMap would be:
  using LayerToElementAnimationsMap =
      std::unordered_map<int, ElementAnimations>;
instead of
  using LayerToElementAnimationsMap =
      std::unordered_map<int, scoped_ptr<ElementAnimations>>;


 

Comment 1 by loyso@chromium.org, Mar 17 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3

commit b8634c4d77f7d4017bf69832ca191d09b7cf3ad3
Author: loyso <loyso@chromium.org>
Date: Fri Mar 18 00:36:09 2016

CC Animation: Use bitset instead of unordered_set in LayerAnimationController

A performance optimization. This avoids any heap allocations.

BUG= 595584 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1806223002

Cr-Commit-Position: refs/heads/master@{#381850}

[modify] https://crrev.com/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3/cc/animation/layer_animation_controller.cc
[modify] https://crrev.com/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3/cc/animation/layer_animation_controller.h
[modify] https://crrev.com/b8634c4d77f7d4017bf69832ca191d09b7cf3ad3/cc/animation/target_property.h

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f47b36532d07544d99c07ad06c8a45e3e62f92

commit 79f47b36532d07544d99c07ad06c8a45e3e62f92
Author: loyso <loyso@chromium.org>
Date: Mon Mar 21 01:01:54 2016

CC Animation: Use unordered_map instead of vector.

A performance optimization to align the implementation with
AnimationTimeline::id_to_player_map_

BUG= 595584 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1814103002

Cr-Commit-Position: refs/heads/master@{#382241}

[modify] https://crrev.com/79f47b36532d07544d99c07ad06c8a45e3e62f92/cc/animation/animation_host.cc
[modify] https://crrev.com/79f47b36532d07544d99c07ad06c8a45e3e62f92/cc/animation/animation_host.h
[modify] https://crrev.com/79f47b36532d07544d99c07ad06c8a45e3e62f92/cc/animation/animation_timeline.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0605b3e38b266326e405e7fffd7301e1e839fde

commit c0605b3e38b266326e405e7fffd7301e1e839fde
Author: loyso <loyso@chromium.org>
Date: Tue Mar 29 00:09:02 2016

CC Animation: Add perf tests for AnimationHost with AnimationTimelines

These are the perf tests for https://codereview.chromium.org/1814103002

BUG= 595584 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1823773003

Cr-Commit-Position: refs/heads/master@{#383623}

[modify] https://crrev.com/c0605b3e38b266326e405e7fffd7301e1e839fde/cc/animation/animation_host_perftest.cc
[modify] https://crrev.com/c0605b3e38b266326e405e7fffd7301e1e839fde/cc/test/fake_layer_tree_host.cc

Comment 5 by loyso@chromium.org, Apr 5 2016

Status: Fixed (was: Started)
We want to merge LayerAnimationController into cc::ElementAnimations. It will make it a ref-counted object:

using LayerToElementAnimationsMap =
      std::unordered_map<int, scoped_refptr<ElementAnimations>>;

So marking this task as fixed.

Sign in to add a comment