New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595582 link

Starred by 1 user
Status: Fixed
Owner:
█ lshang@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
calamity@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD History: Selection does not clear when changing to 'Open Tabs'

Project Member Reported by tsergeant@chromium.org, Mar 17 2016 
What steps will reproduce the problem?
(1) Enable MD History (chrome://flags#enable-md-history)
(2) Navigate to chrome://history
(3) Select history items using the checkbox
(4) Click 'Open Tabs' in the left-hand menu

What is the expected output? What do you see instead?
Items should be deselected.

Instead, the items remain selected, the toolbar remains light blue, and if I click any of the toolbar buttons then the selection bugs out.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4642db726b0ada9a888a6469c6fbcde9fe14c84e

commit 4642db726b0ada9a888a6469c6fbcde9fe14c84e
Author: lshang <lshang@chromium.org>
Date: Mon Mar 21 00:08:15 2016

MD History: Clear selection when changing to 'Open Tabs'

At present, when click 'Open Tabs' on the Material Design History page, the
selected items on the history page don't get cleared and the toolbar remains light
blue. This CL fixes this by unselecting all items before it switches to the other
tab.

BUG= 595582 

Review URL: https://codereview.chromium.org/1807293005

Cr-Commit-Position: refs/heads/master@{#382238}

[modify] https://crrev.com/4642db726b0ada9a888a6469c6fbcde9fe14c84e/chrome/browser/resources/md_history/side_bar.js

Comment 2 by lshang@chromium.org, Mar 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment