Issue 595577 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	dcheng@chromium.org
Closed:	Mar 2016
Cc:	danakj@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
clang

Blocking:
issue 578344

Tool shouldn't rename things instantiated from template parameters

Project Member Reported by dcheng@chromium.org, Mar 17 2016

Issue description

template <void f()>
void g() {
  f();
}

void foo();

g<foo>();

results in the function template body changing to void g() { Foo(); }

which is wrong

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c13719228662d502c7b1b5973edbcb69236b8203

commit c13719228662d502c7b1b5973edbcb69236b8203
Author: dcheng <dcheng@chromium.org>
Date: Sat Mar 19 01:02:32 2016

Don't rename references to functions that originate from template args.

BUG= 595577 

Review URL: https://codereview.chromium.org/1806903003

Cr-Commit-Position: refs/heads/master@{#382160}

[modify] https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
[modify] https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203/tools/clang/rewrite_to_chrome_style/tests/template-expected.cc
[modify] https://crrev.com/c13719228662d502c7b1b5973edbcb69236b8203/tools/clang/rewrite_to_chrome_style/tests/template-original.cc

Comment 2 by dcheng@chromium.org, Mar 19 2016

Status: Fixed (was: Started)

►

Issue 595577 link

Issue metadata

Tool shouldn't rename things instantiated from template parameters

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 19 2016

Comment 1 Deleted

Comment 2 by dcheng@chromium.org, Mar 19 2016

Comment 2 Deleted

Sign in to add a comment