[Passwords] Change interaction from dropdown to sub-page |
||||||||
Issue descriptionTo anticipate large lists like these and to avoid multiple scrolling modes, clicking on Manage Passwords should take you to a sub-page and not a dropdown. Hopefully you can recycle the code from the "Manage search engines" sub-page. Preview: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width&fr=0&c=show
,
Mar 18 2016
Just to confirm: do we still want to scroll if there are more than 6 items? If we don't scroll and make the sub-page get at long as it wants, then the "Never saved" section can end up below the fold.
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb3880246bcb734401a374ca9c15af5a815196d9 commit cb3880246bcb734401a374ca9c15af5a815196d9 Author: hcarmona <hcarmona@chromium.org> Date: Thu Mar 24 23:33:51 2016 Move passwords and password exceptions list into a sub page. BUG= 595574 Review URL: https://codereview.chromium.org/1829993002 Cr-Commit-Position: refs/heads/master@{#383187} [modify] https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp [modify] https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html [modify] https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js [modify] https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9/chrome/browser/resources/settings/settings_page/settings_router.js
,
Mar 25 2016
Hey Hector, sorry for the lag. Scrolling will only happen on the page level. So the lists can runs as long as it wants and pushes content down the page.
,
Mar 25 2016
Setting default priority/type
,
Mar 25 2016
Setting default priority/type
,
Mar 25 2016
,
Mar 25 2016
Screenshot for http://crrev.com/1834033002
,
Mar 25 2016
This is functionally correct, but there's a lot of layout issues I see. Should we handle them here or on a new bug?
,
Mar 25 2016
We can handle the layout issues here. If it's something too big we can always pull it out into it's own issue. The links are still not there and I'm missing the descriptive text across the top. (coming in followup CLs)
,
Mar 26 2016
1. Doesn't look like you're using our standard 13px font-size 2. Refer to crbug/597860 and folio on how to build sub-pages https://goo.gl/tlAI9Z 3. Refer to page-specific spec on building passwords https://goo.gl/3dX3uw 4. Make sure menu icons are displayed in google grey 500
,
Mar 26 2016
1. Doesn't look like you're using our standard 13px font-size Reason it looks big in the original screenshot is b/c I had changed the "Font size" setting in my test profile without realizing. Updated screenshot attached. 2. Refer to crbug/597860 and folio on how to build sub-pages https://goo.gl/tlAI9Z I rebased to get the updated code. Changes from that should be included in the attached screenshot. The heading and arrow should be correct now and I will update the spacing on the lists and the sub-headings based on #3. 3. Refer to page-specific spec on building passwords https://goo.gl/3dX3uw Didn't know this existed. I'll use this to update the passwords and post a new screenshot after those changes are done. 4. Make sure menu icons are displayed in google grey 500 I'll update --paper-grey-500 to --google-gray-500 in the CL with changes from #3. Thanks for the feedback!
,
Mar 26 2016
Nice. Much better! Re: #3, I just added it for you :)
,
Mar 29 2016
Here's an updated screenshot taking #3 into account.
,
Mar 30 2016
I'd like to review this on my machine, but before committing some things to note: - we're removing underlines for hyperlinks. They should just be colored Google Blue 700 - Confirm column labels are 12px, font-weight: 500. (they look like 400) - (NEW) icon colors are now Google Grey 600. https://goo.gl/qMfCq4 (x and overflow menu) - (NEW) the top and bottom padding of "Access your passwords..." should be 24dp.
,
Mar 30 2016
Will all pages have 24px after the heading or just passwords? (the 24px padding on top of "Access your passwords...")
,
Mar 31 2016
- we're removing underlines for hyperlinks. They should just be colored Google Blue 700 * Will fix separately so all links are uniform - Confirm column labels are 12px, font-weight: 500. (they look like 400) * Fixed - (NEW) icon colors are now Google Grey 600. https://goo.gl/qMfCq4 (x and overflow menu) * Fixed - (NEW) the top and bottom padding of "Access your passwords..." should be 24dp. * Will fix in followup CL
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e2be002b0a51a571d13e0724020f684c8ea80b8 commit 7e2be002b0a51a571d13e0724020f684c8ea80b8 Author: hcarmona <hcarmona@chromium.org> Date: Thu Mar 31 19:42:21 2016 Make the passwords list have 3 columns and not over-scroll. Also moves CSS to HTML to match other, newer, elements. Screenshot is attached to bug. BUG= 595574 Review URL: https://codereview.chromium.org/1834033002 Cr-Commit-Position: refs/heads/master@{#384361} [delete] https://crrev.com/dce97597a49d6238e2dc041e2c80d89c3558dd1f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.css [modify] https://crrev.com/7e2be002b0a51a571d13e0724020f684c8ea80b8/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/7e2be002b0a51a571d13e0724020f684c8ea80b8/chrome/browser/resources/settings/settings_resources.grd
,
Apr 6 2016
,
May 24 2016
,
May 24 2016
,
Jan 6 2017
@hcarmona, anything left to fix on this bug?
,
Jan 6 2017
,
Jan 9 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bettes@chromium.org
, Mar 17 2016Owner: hcarmona@chromium.org
Status: Assigned (was: Untriaged)