New issue
Advanced search Search tips

Issue 595574 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 546836
issue 671375



Sign in to add a comment

[Passwords] Change interaction from dropdown to sub-page

Project Member Reported by bettes@chromium.org, Mar 17 2016

Issue description

To anticipate large lists like these and to avoid multiple scrolling modes, clicking on Manage Passwords should take you to a sub-page and not a dropdown. 

Hopefully you can recycle the code from the "Manage search engines" sub-page. 

Preview:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width&fr=0&c=show


 
Screen Shot 2016-03-16 at 8.32.00 PM.png
119 KB View Download

Comment 1 by bettes@chromium.org, Mar 17 2016

Cc: tbuck...@chromium.org dbeam@chromium.org bettes@chromium.org
Owner: hcarmona@chromium.org
Status: Assigned (was: Untriaged)
Just to confirm: do we still want to scroll if there are more than 6 items?

If we don't scroll and make the sub-page get at long as it wants, then the "Never saved" section can end up below the fold.

Comment 4 by bettes@chromium.org, Mar 25 2016

Hey Hector, sorry for the lag. 

Scrolling will only happen on the page level. So the lists can runs as long as it wants and pushes content down the page.  
Labels: Pri-2 Type-Bug
Setting default priority/type
Setting default priority/type
Blocking: 546836
Screenshot for http://crrev.com/1834033002
1834033002 - 1.png
81.9 KB View Download

Comment 9 by bettes@chromium.org, Mar 25 2016

This is functionally correct, but there's a lot of layout issues I see. Should we handle them here or on a new bug? 
We can handle the layout issues here. If it's something too big we can always pull it out into it's own issue.

The links are still not there and I'm missing the descriptive text across the top. (coming in followup CLs)
1. Doesn't look like you're using our standard 13px font-size
2. Refer to crbug/597860 and folio on how to build sub-pages https://goo.gl/tlAI9Z
3. Refer to page-specific spec on building passwords https://goo.gl/3dX3uw
4. Make sure menu icons are displayed in google grey 500


1. Doesn't look like you're using our standard 13px font-size
   Reason it looks big in the original screenshot is b/c I had changed the "Font size" setting in my test profile without realizing. Updated screenshot attached.

2. Refer to crbug/597860 and folio on how to build sub-pages https://goo.gl/tlAI9Z
   I rebased to get the updated code. Changes from that should be included in the attached screenshot.
   The heading and arrow should be correct now and I will update the spacing on the lists and the sub-headings based on #3.

3. Refer to page-specific spec on building passwords https://goo.gl/3dX3uw
   Didn't know this existed. I'll use this to update the passwords and post a new screenshot after those changes are done.

4. Make sure menu icons are displayed in google grey 500
   I'll update --paper-grey-500 to --google-gray-500 in the CL with changes from #3.

Thanks for the feedback!
1834033002 - 1 (updated).png
70.9 KB View Download
Nice. Much better! Re: #3, I just added it for you :)
Here's an updated screenshot taking #3 into account. 
1834033002 - 2.png
75.4 KB View Download
I'd like to review this on my machine, but before committing some things to note: 

- we're removing underlines for hyperlinks. They should just be colored Google Blue 700
- Confirm column labels are 12px, font-weight: 500. (they look like 400) 
- (NEW) icon colors are now Google Grey 600. https://goo.gl/qMfCq4 (x and overflow menu)
- (NEW) the top and bottom padding of "Access your passwords..." should be 24dp. 

Screen Shot 2016-03-29 at 4.55.24 PM.png
18.2 KB View Download
Will all pages have 24px after the heading or just passwords? (the 24px padding on top of "Access your passwords...")
- we're removing underlines for hyperlinks. They should just be colored Google Blue 700
  * Will fix separately so all links are uniform

- Confirm column labels are 12px, font-weight: 500. (they look like 400) 
  * Fixed

- (NEW) icon colors are now Google Grey 600. https://goo.gl/qMfCq4 (x and overflow menu)
  * Fixed

- (NEW) the top and bottom padding of "Access your passwords..." should be 24dp.
  * Will fix in followup CL
1834033002 - Patch 4.png
73.0 KB View Download
Cc: kolos@chromium.org
Labels: MD-Settings-PasswordsForms
Labels: -MD-Settings-PasswordsForms Hotlist-MD-Settings-PasswordsForms
@hcarmona, anything left to fix on this bug?
Blockedon: 671375
Blockedon: -671375
Blocking: 671375
Status: Fixed (was: Assigned)

Sign in to add a comment