CC Animation: Merge LayerAnimationController and AnimationRegistrar into AnimationPlayer and AnimationHost respectively.
Note that we want to change layer-to-LAC relationship from 1:1 to 1:many (Many AnimationPlayers attached to one cc::Layer). Taking all the animation groups, blocked properties etc into consideration.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c607f80d496a842aa45a56c783bccbe48fbd0853 commit c607f80d496a842aa45a56c783bccbe48fbd0853 Author: loyso <loyso@chromium.org> Date: Thu Apr 14 00:34:27 2016 CC Animation: Make AnimationRegistrar a private member of AnimationHost. AnimationRegistrar will be merged into AnimationHost in the dependent CL. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1877073006 Cr-Commit-Position: refs/heads/master@{#387172} [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/animation_host.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/animation_host.h [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/element_animations.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/animation/layer_animation_controller_unittest.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/test/layer_tree_test.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/trees/layer_tree_host.h [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/c607f80d496a842aa45a56c783bccbe48fbd0853/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2 commit ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2 Author: loyso <loyso@chromium.org> Date: Thu Apr 14 01:33:46 2016 CC Animation: Erase AnimationRegistrar Merge AnimationRegistrar into AnimationHost. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1881373002 Cr-Commit-Position: refs/heads/master@{#387197} [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/BUILD.gn [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/animation_host.cc [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/animation_host.h [delete] https://crrev.com/5afcf89f2009d3e76bef46cada5393038b488a03/cc/animation/animation_registrar.cc [delete] https://crrev.com/5afcf89f2009d3e76bef46cada5393038b488a03/cc/animation/animation_registrar.h [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/element_animations.cc [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/layer_animation_controller.cc [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/layer_animation_controller.h [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/animation/layer_animation_controller_unittest.cc [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/cc.gyp [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/trees/layer_tree_host.cc [modify] https://crrev.com/ab8b62956a7f42d6b5f0a1a73934ee217b2f10b2/cc/trees/layer_tree_host_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de0a0025d97917aabb9574f4e69e87215f5bb871 commit de0a0025d97917aabb9574f4e69e87215f5bb871 Author: loyso <loyso@chromium.org> Date: Fri Apr 15 02:28:38 2016 CC Animation: Make layer_animation_controller a private member of ElementAnimations. LayerAnimationController will be merged to ElementAnimations in the dependent CL. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1887593003 Cr-Commit-Position: refs/heads/master@{#387525} [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/animation/animation_host.cc [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/animation/animation_player.cc [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/animation/element_animations.cc [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/animation/element_animations.h [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/032567ef1cded026eb25079f0e39c08f30fc852c commit 032567ef1cded026eb25079f0e39c08f30fc852c Author: loyso <loyso@chromium.org> Date: Mon Apr 18 03:27:30 2016 CC Animation: Make LayerAnimationController to have just one value observer. - Erase ElementAnimations::ValueObserver - Refactor active and pending observer notifications to that single observer. LayerAnimationController will be merged to ElementAnimations in the dependent CL. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1882733005 Cr-Commit-Position: refs/heads/master@{#387856} [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/element_animations.cc [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/element_animations.h [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/layer_animation_controller.cc [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/layer_animation_controller.h [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/layer_animation_controller_unittest.cc [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/animation/layer_animation_value_observer.h [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/test/animation_test_common.cc [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/test/animation_test_common.h [modify] https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c/cc/trees/layer_tree_host_unittest_animation.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c commit cf570e7b6c0b0b64154facb87cbfb3d85bbc720c Author: loyso <loyso@chromium.org> Date: Mon Apr 18 23:08:18 2016 CC Animation: Make ElementAnimations a ref-counted object. It will be merged with ref-counted LayerAnimationController. In the future we may introduce blink::CompositorElementAnimations with m_elementAnimations wrapper which holds a ref-counted reference. A Drive-by: enhance the comment in ElementAnimations::OnAnimationWaitingForDeletion. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1894023002 Cr-Commit-Position: refs/heads/master@{#388067} [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/animation_host.cc [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/animation_host.h [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/animation_player.cc [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/animation_player.h [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/element_animations.cc [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/element_animations.h [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/cc/test/animation_timelines_test_common.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b commit deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b Author: loyso <loyso@chromium.org> Date: Mon Apr 18 23:19:04 2016 CC Animation: Make LayerAnimationController to have just one event observer. Next step: unify LayerAnimationEventObserver with AnimationDelegate in the dependent CL. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1893253002 Cr-Commit-Position: refs/heads/master@{#388072} [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/cc/animation/element_animations.cc [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/cc/animation/element_animations.h [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/cc/animation/layer_animation_controller.cc [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/cc/animation/layer_animation_controller.h [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/cc/animation/layer_animation_controller_unittest.cc [modify] https://crrev.com/deaa7fda6ae480160e3b0d5f86ca984a4c3eff1b/ui/compositor/layer_animator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79c0bfc015fc21ed804ce2064ac0603ca50ed79c commit 79c0bfc015fc21ed804ce2064ac0603ca50ed79c Author: loyso <loyso@chromium.org> Date: Mon Apr 18 23:46:42 2016 CC Animation: Erase LayerAnimationEventObserver. Use AnimatiodDelegate in ui::LayerAnimator instead. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1898683002 Cr-Commit-Position: refs/heads/master@{#388082} [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/BUILD.gn [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/animation/element_animations.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/animation/element_animations.h [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/animation/layer_animation_controller.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/animation/layer_animation_controller.h [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/animation/layer_animation_controller_unittest.cc [delete] https://crrev.com/e696e47994432cc1075f3fb74de7c7e9ac2b29a4/cc/animation/layer_animation_event_observer.h [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/cc/cc.gyp [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animation_sequence.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animation_sequence.h [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animation_sequence_unittest.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animator.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animator.h [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/layer_animator_unittest.cc [modify] https://crrev.com/79c0bfc015fc21ed804ce2064ac0603ca50ed79c/ui/compositor/test/layer_animator_test_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47a0f19c0ea71537c0465269e6145d30678b0751 commit 47a0f19c0ea71537c0465269e6145d30678b0751 Author: loyso <loyso@chromium.org> Date: Fri Apr 22 00:30:09 2016 CC Animation: Merge LayerAnimationController into ElementAnimations. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1904653002 Cr-Commit-Position: refs/heads/master@{#388974} [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/BUILD.gn [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation_host.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation_host.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation_player.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation_player.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/animation_player_unittest.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/element_animations.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/element_animations.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/animation/element_animations_unittest.cc [delete] https://crrev.com/9eeecffa94e5d7fdf331c275d092b207e31206b1/cc/animation/layer_animation_controller.cc [delete] https://crrev.com/9eeecffa94e5d7fdf331c275d092b207e31206b1/cc/animation/layer_animation_controller.h [delete] https://crrev.com/9eeecffa94e5d7fdf331c275d092b207e31206b1/cc/animation/layer_animation_controller_unittest.cc [delete] https://crrev.com/9eeecffa94e5d7fdf331c275d092b207e31206b1/cc/animation/layer_animation_value_observer.h [delete] https://crrev.com/9eeecffa94e5d7fdf331c275d092b207e31206b1/cc/animation/layer_animation_value_provider.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/cc.gyp [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/cc_tests.gyp [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/layers/layer.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/test/animation_test_common.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/test/animation_test_common.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/test/animation_timelines_test_common.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/test/animation_timelines_test_common.h [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/test/layer_tree_test.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/trees/layer_tree_host_common_unittest.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/trees/layer_tree_host_unittest_animation.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/trees/occlusion_tracker_unittest.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/cc/trees/tree_synchronizer_unittest.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/ui/compositor/layer_animator.cc [modify] https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751/ui/compositor/layer_animator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9419f1a2b215d272c08bea8a01b7a45629843ce9 commit 9419f1a2b215d272c08bea8a01b7a45629843ce9 Author: loyso <loyso@chromium.org> Date: Tue Apr 26 00:52:49 2016 CC Animation: Erase ElementAnimations::ObserverType. Use LayerTreeType instead. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1911283002 Cr-Commit-Position: refs/heads/master@{#389642} [modify] https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9/cc/animation/animation_host.cc [modify] https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9/cc/animation/animation_host.h [modify] https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9/cc/animation/element_animations.cc [modify] https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9/cc/animation/element_animations.h [modify] https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9/cc/animation/element_animations_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34e7ffb72463d53265455eb1b81e4eb1792fbc4e commit 34e7ffb72463d53265455eb1b81e4eb1792fbc4e Author: loyso <loyso@chromium.org> Date: Tue Apr 26 03:30:29 2016 CC Animation: Remove Observers and Observations in namings. BUG= 595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1912023003 Cr-Commit-Position: refs/heads/master@{#389683} [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/animation.cc [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/animation.h [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/animation_host.cc [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/element_animations.cc [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/element_animations.h [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e/cc/trees/layer_tree_host_unittest_animation.cc
Comment 1 by loyso@chromium.org
, Mar 17 2016