Mocks 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width&fr=0&c=show

- Username added to edit password dialog
- allow text to be copy-able within the dialog
- allow domains (in saved and not saved) to act as links. Style them with a underline upon hover. See attached 

Deleted: links.png 47.0 KB

	links.png 47.0 KB View Download

The edit dialog uses "Website" and the list uses "Domain". Which string should we use?

Screenshot for http://crrev.com/1817123003

Deleted: 595538 - 1.png 68.5 KB

	595538 - 1.png 68.5 KB View Download

Let's use website for both. Thanks!

Setting default priority/type

Setting default priority/type

bettes@, what do you think about putting the icon inside the edit field? I've seen some fields that put the icon directly inside the field (see the clear button in downloads search).

Does it make sense to do this for all our inputs that have a button they interact with?

(screenshot of what this could look like)

Deleted: show-in-input-field.png 15.8 KB

	show-in-input-field.png 15.8 KB View Download

Let's keep it outside so it's click/touch target is clearly separated from the menu component. 

Ensure a 16px padding between eye icon and menu

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c67c3d74edbb8275a9fef22b236973e5f63332b

commit 2c67c3d74edbb8275a9fef22b236973e5f63332b
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Mar 30 00:11:38 2016

Implement the password edit UI.

See screenshot in bug.

BUG= 595538 

Review URL: https://codereview.chromium.org/1817123003

Cr-Commit-Position: refs/heads/master@{#383874}

[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[add] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[add] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c67c3d74edbb8275a9fef22b236973e5f63332b

commit 2c67c3d74edbb8275a9fef22b236973e5f63332b
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Mar 30 00:11:38 2016

Implement the password edit UI.

See screenshot in bug.

BUG= 595538 

Review URL: https://codereview.chromium.org/1817123003

Cr-Commit-Position: refs/heads/master@{#383874}

[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[add] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[add] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64fa78f7076e976ac4b4e72104af0b3e3680e599

commit 64fa78f7076e976ac4b4e72104af0b3e3680e599
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Apr 06 00:03:27 2016

Handle the button presses in the password edit dialog.

CL includes tests for this element.

BUG= 595538 

Review URL: https://codereview.chromium.org/1822913003

Cr-Commit-Position: refs/heads/master@{#385331}

[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/64fa78f7076e976ac4b4e72104af0b3e3680e599/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Thanks for taking care of this missing functionality. 

Will it be possible to copy the username and the origin from the list (i.e. w/o edit dialog)? 

Right now it's not possible to copy w/o first showing the edit dialog.

bettes@ is there a reason to prevent the username or website in the list from being copy-able?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01169ce8869769a57004aa8acf0177e560dc930a

commit 01169ce8869769a57004aa8acf0177e560dc930a
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Apr 15 00:44:42 2016

Make the saved password website link-able.

BUG= 595538 

Review URL: https://codereview.chromium.org/1860783004

Cr-Commit-Position: refs/heads/master@{#387494}

[modify] https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
[modify] https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a/chrome/common/extensions/api/passwords_private.idl
[modify] https://crrev.com/01169ce8869769a57004aa8acf0177e560dc930a/third_party/closure_compiler/externs/passwords_private.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f01343295501f5113c8b5a97d9008a9a95aa894a

commit f01343295501f5113c8b5a97d9008a9a95aa894a
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Apr 25 19:22:44 2016

Make the URLs in the password exceptions list clickable.

Required updating the passwords private API to return the link URL.

No UI change. Links behave the same as the saved password URL links by
underlining only on hover.

BUG= 595538 

Review URL: https://codereview.chromium.org/1907813002

Cr-Commit-Position: refs/heads/master@{#389533}

[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/common/extensions/api/passwords_private.idl
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/test/data/extensions/api_test/passwords_private/test.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/third_party/closure_compiler/externs/passwords_private.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f01343295501f5113c8b5a97d9008a9a95aa894a

commit f01343295501f5113c8b5a97d9008a9a95aa894a
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Apr 25 19:22:44 2016

Make the URLs in the password exceptions list clickable.

Required updating the passwords private API to return the link URL.

No UI change. Links behave the same as the saved password URL links by
underlining only on hover.

BUG= 595538 

Review URL: https://codereview.chromium.org/1907813002

Cr-Commit-Position: refs/heads/master@{#389533}

[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/common/extensions/api/passwords_private.idl
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/test/data/extensions/api_test/passwords_private/test.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/f01343295501f5113c8b5a97d9008a9a95aa894a/third_party/closure_compiler/externs/passwords_private.js

From #14:
Will it be possible to copy the username and the origin from the list (i.e. w/o edit dialog)? 

From #15:
Right now it's not possible to copy w/o first showing the edit dialog.
bettes@, is there a reason to prevent the username or website in the list from being copy-able?

Hectory, if it's possible to add this functionality without needing the edit dialog and without disrupting the visual style, than that'd be a nice-to-have, but my answer to the above questions are "No, it's not possible at this time." 

We can look to revisiting after v1 but i dont find it critical. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d8a49b38c58daee9280ff66935dfb3867af957d

commit 2d8a49b38c58daee9280ff66935dfb3867af957d
Author: hcarmona <hcarmona@chromium.org>
Date: Wed May 18 23:48:59 2016

Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG= 595538 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1991943003
Cr-Commit-Position: refs/heads/master@{#394605}

[modify] https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

It was super easy to enable copying from the list for username and origin without affecting the visual style.

That brings us up to par with the previous dialog for copy-ability and link-ability. Marking this issue as "Fixed".

Great thanks for adding these missing functionalities, Hector!

Recently, we made some efforts to change the password page (https://docs.google.com/presentation/d/1MKbyV0i3dpqSN39IHKHz1oNcfXSb50w4tykU4NPjNww). Could you help us to transfer the changes to new MD design, please?

* Hiding the scheme of the origins and showing the full url in the tooltip? It is how it looks like now. We come up to this solution with UX and security team.

* Credentials that were saved in Android applications. At this point, it is shown as android://[package_name] (e.g. android://com.netflix.mediaclient, see attached "android_credentials_new.png"). Recently, we implemented the backend stuff (https://codereview.chromium.org/1615653005) to show more readable names (like netflix.com, see android_credentials_old.png).

* Focus traversing on the password page (the tab moves between sections, the arrows moves between entries, usernames are focusable as well). 

* Copying origins in "Never save" section as well.

* Search field. Simple search in shown origins and usernames. Probably very useful for users with many saved passwords.

* Auto signin checkbox.

And one more note:
* At this point, there is no backend code to edit origin, username nor password. Could we rename "Edit"  to "View"?

Thanks.

Best regards,
Maxim

Deleted: android_credentials_old.png 4.3 KB

	android_credentials_old.png 4.3 KB View Download

Deleted: android_credentials_new.png 5.3 KB

	android_credentials_new.png 5.3 KB View Download

Just a quick response to the questions:

* Hiding the scheme of the origins and showing the full url in the tooltip? It is how it looks like now. We come up to this solution with UX and security team.

We shouldn't need to update the passwords private API For the tooltip. I can point you in the right direction if you want to look at adding this. Should be straight forward.

* Credentials that were saved in Android applications. At this point, it is shown as android://[package_name] (e.g. android://com.netflix.mediaclient, see attached "android_credentials_new.png"). Recently, we implemented the backend stuff (https://codereview.chromium.org/1615653005) to show more readable names (like netflix.com, see android_credentials_old.png).

Need to update API to get the changes. Depending on how we handle this, the UI might need to change or it will pick up the changes automatically. We can sync up about this over hangouts.

* Focus traversing on the password page (the tab moves between sections, the arrows moves between entries, usernames are focusable as well).

Will be taken care of by a11y effort. We haven't done a full look through this yet.

* Copying origins in "Never save" section as well.

Easy to do. I'll create a CL for this today.

* Search field. Simple search in shown origins and usernames. Probably very useful for users with many saved passwords.

On my TODO list. Mocks show a single search field on top that will filter both sections.

* Auto signin checkbox.

We need mocks from Alan (bettes@) for where to add this. Probably underneath the "Access your passwords..." message.

And one more note:
* At this point, there is no backend code to edit origin, username nor password. Could we rename "Edit"  to "View"?

Sounds good. Changes we need for this are:
    * Rename "Edit" menu to "View"
    * Rename "Edit saved password" title to "Viewing saved password"
    * Remove the "Save" and "Cancel" buttons from this UI
If Alan is OK w/ this, then I can make these changes quickly.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43cf3a459557f660757c8f261c523b222a894df

commit b43cf3a459557f660757c8f261c523b222a894df
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Jun 03 00:07:18 2016

[MD Settings Passwords] Make password exceptions copy-able.

No visible UI change, just making the exception url copy-able.

BUG= 595538 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2037833002
Cr-Commit-Position: refs/heads/master@{#397551}

[modify] https://crrev.com/b43cf3a459557f660757c8f261c523b222a894df/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Thanks for quick response, Hector! And thanks that you have added missed stuff to your TODO list. Highly appreciated!

As for Android credentials, here is some points (it might be enough, since the most complicated part, the backend, is done). The backend fills |affiliated_web_realm| of |PasswordForm|. It is the site name affiliated to the given Android app and it is supposed to be shown as an origin. 

We need just to read the field and append with "(Android)" in UI. At this point, this function (https://cs.chromium.org/chromium/src/components/password_manager/core/browser/password_ui_utils.cc?q=GetShownOriginAndLinkUrl&l=24) does that. 

If you have any questions, I am glad to answer in this thread or by hangouts. 

Best regards,
Maxim

Search screenshots

Deleted: empty-search.png 53.6 KB

	empty-search.png 53.6 KB View Download

Deleted: search-red.png 42.2 KB

	search-red.png 42.2 KB View Download

Deleted: no-results.png 37.8 KB

	no-results.png 37.8 KB View Download

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!

@hcarmona it looks like this bug has become a bit overloaded. Can you file separate bugs for any remaining issues and close this one? Thanks!

Finished looking for missing functionality, filed  Issue 705574  and  Issue 705575 . Closing this bug.