New issue
Advanced search Search tips

Issue 595532 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Privacy and Security] Replace icons with overflow menu in Manage Certificates

Project Member Reported by bettes@chromium.org, Mar 17 2016

Issue description

tl;dr 
We're replacing the line of icons with an overflow icon, and including each action within the menu. 

From our email thread:  

In current mocks, each certificate entry is associated with a dedicated list of icons (view, edit, export, import, delete, see attachments). This results in too many icons on the page, and it takes too long to render (3-4 seconds on my machine). The problem is mostly present on the "Authorities" tab, because that is the certificate category with the most entries.

Note that in the old Options UI, there is a single set of buttons at the bottom, and the list items do not have any dedicated icons. The button set corresponds to the certificate that is selected at a given time (see old_ca_certificates_list attachment).

Also another thing to note (which I have mentioned in the folio comments a few weeks ago), is that the "import" icon makes little sense to be per-entry, since it simply imports a new certificate, has nothing to do with the row on which it is displayed.

Should there be any changes to the current mocks? Specifically
1) What should we do with the current "import" icon?
2) Per-entry icons vs single icon-set?
    Solution1:  Have single set of icons (similar to the buttons in the old Options UI).
    Solution2: Create a "dots" popup menu per-entry similar to search engine entries and move (view, edit, export, delete) options there.
    Solution3: Lazily render the icons for an entry, only when the parent certificate authority is expanded. I tried this and it does improve performance, with the caveat that expanding the certificate authority snaps to its full height instead of animating to it.
    Other thoughts: ?
 
ca_certificates_list_collapsed.png
114 KB View Download
ca_certificates_list_expanded.png
130 KB View Download
old_ca_certificates_list.png
117 KB View Download

Comment 1 by bettes@chromium.org, Mar 17 2016

Cc: tbuck...@chromium.org dbeam@chromium.org bettes@chromium.org
Owner: dpa...@chromium.org
Demetrios, 
I'm assigning this to you for now. Let me know when your fixes have landed and we can proceed from there. 

Comment 2 by bettes@chromium.org, Mar 17 2016

Status: Assigned (was: Untriaged)

Comment 3 by bettes@chromium.org, Mar 17 2016

Status: Assigned (was: Untriaged)

Comment 4 by dpa...@chromium.org, Mar 17 2016

The version shown at ca_certificates_list_collapsed.png and 	ca_certificates_list_expanded.png was never landed (it only exists on my local repo), so technically there is nothing to fix, I am just going to modify my uncommitted CL to the latest mocks. You might as well just merge this to  crbug.com/547073 .

Comment 5 by dvadym@chromium.org, Mar 21 2016

Components: Privacy
Labels: Pri-2 Type-Bug
Setting default priority/type
Setting default priority/type

Comment 8 by dpa...@chromium.org, Mar 28 2016

Status: Fixed (was: Untriaged)
https://codereview.chromium.org/1819563002

Sign in to add a comment