New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 595512 link

Starred by 1 user
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

"Stop using an invalid certificate" is visible in page info for about:blank

Project Member Reported by lgar...@chromium.org, Mar 17 2016 
Chrome 51.0.2679.0 
OSX 10.11.3

What steps will reproduce the problem?
(1) Visit google.com (or any website).
(2) Execute `window.open()`.
(3) Click on the page icon.

What is the expected output? What do you see instead?
I can reproduce this reliably on OSX, but not Windows, so I suspect it's a problem for Mac but not Views.

The new code checks for identityInfo.show_ssl_decision_revoke_button just like the old code, but we also need to check that certificateId_ is truthy.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm&q=IDS_PAGEINFO_RESET_INVALID_CERTIFICATE_DECISIONS_BUTTON&sq=package:chromium&type=cs&l=654
Screen Shot 2016-03-16 at 17.10.28.png
49.5 KB View Download

Comment 1 by lgar...@chromium.org, Mar 17 2016 

Actually, it seems to be sufficient to visit about:blank directly and click on the page icon several times (no page refresh needed).

The button will show up about half the time, non-deterministically(!).

The fix is trivial, but meacer@ points out that this may be the sign of an improperly initialized variable.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99889dad84e0e17e216336a1255173c70d6776bf

commit 99889dad84e0e17e216336a1255173c70d6776bf
Author: lgarron <lgarron@chromium.org>
Date: Fri Mar 18 22:09:43 2016

Prevent the "Stop using an invalid certificate" button from showing up on about:blank for OSX.

BUG= 595512 ,  558581 
TEST=Visit about:blank, click on the page icon several times, and make sure that the "Stop using an invalid certificate" never appears.

Review URL: https://codereview.chromium.org/1813623002

Cr-Commit-Position: refs/heads/master@{#382107}

[modify] https://crrev.com/99889dad84e0e17e216336a1255173c70d6776bf/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/99889dad84e0e17e216336a1255173c70d6776bf/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Comment 3 by lgar...@chromium.org, Mar 22 2016

Status: Fixed (was: Started)
Just tested beta vs. Canary; the fix seems to be working.

Comment 4 by lgar...@chromium.org, Oct 19 2016

Components: UI>Browser>Omnibox>PageInfo

Comment 5 by lafo...@chromium.org, Oct 20 2016

Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo

Comment 6 by lgar...@chromium.org, Nov 24 2016

Components: -Security>UX
►

Sign in to add a comment