New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 595506 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

battor_agent's StopTracing command should accept an optional parameter to redirect output to a file

Project Member Reported by charliea@chromium.org, Mar 17 2016

Issue description

alexandermont@ made a great feature request: now that battor_agent is an interactive binary, it's kind of a pain in the butt that there's no way to tell StopTracing to redirect output to a file.

Before, the obvious way to do this was:

  ./battor_agent StopTracing > /tmp/trace.txt

However, it's not really possible to redirect output to a file like that anymore because the agent is now an interactive shell, and you need to be able to see the result of the last command that comes through STDOUT.

It should be pretty easy to add an optional parameter for StopTracing in the binary, so that you can do something like:

  # Start the shell
  ./battor_agent

  StartTracing
  StopTracing /tmp/trace.txt

and have the output be redirected to that file.
 
Cc: charliea@chromium.org
Owner: rnep...@chromium.org
Assigning this to rnephew@, who has graciously agreed to look into this :)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3f2d11370565d8c92d941beb9f554911675e66

commit 5f3f2d11370565d8c92d941beb9f554911675e66
Author: rnephew <rnephew@chromium.org>
Date: Thu Mar 24 15:58:34 2016

[Battor] Add ability to dump trace log to file.

BUG= 595506 

Review URL: https://codereview.chromium.org/1819573002

Cr-Commit-Position: refs/heads/master@{#383070}

[modify] https://crrev.com/5f3f2d11370565d8c92d941beb9f554911675e66/tools/battor_agent/battor_agent_bin.cc

Status: Fixed (was: Assigned)
Thanks for doing this Randy!

Sign in to add a comment