Issue metadata
Sign in to add a comment
|
Cannot save a document as PDF on Drive and FSP volumes |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Open any web site 2. Press Ctrl-P to open the print dialog 3. Set the destination to "Save as PDF" 4. Press the Save button What is the expected result? The save dialog pops up and the user can save the PDF on any volumes including Drive and FSP volumes What happens instead of that? The user can only save the PDF on the local Downloads folder. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36
,
Mar 17 2016
I guess it is triggered by https://codereview.chromium.org/1701163003. hirono@, is this issue working as intended? I suspect that hiding Drive volume might be unexpected...
,
Mar 17 2016
Let me take a look. Thank you for routing!
,
Mar 17 2016
The initial report is for Chrome 49. So maybe it's not caused by crrev.com/1701163003, which is submitted to Chrome 50. Investigating...
,
Mar 25 2016
#CBC-RS/TC-watchlist
,
Apr 2 2016
#CBC-RS/TC-watchlist
,
Apr 4 2016
It does not look a regression. Mark it as feature request.
,
Apr 4 2016
note: Currently we need native path here. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc&rcl=1459739742&l=302
,
Apr 12 2016
Found out it's actually regression. Print preview needs native path, but we have a drive-only hack to prepare native path for save-as dialog.
,
Apr 12 2016
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/072c195f6a8fb12d4970b889dca8f75779b5533e commit 072c195f6a8fb12d4970b889dca8f75779b5533e Author: hirono <hirono@chromium.org> Date: Tue Apr 12 08:04:57 2016 Show GoogleDrive volume in saving dialog that requires naitve path. crrev.com/376073 assumed we cannot create snapshot files for saving and it hides non-native volumes for saving dialog. However we have special hack for Google Drive to create snapshot files for saving. BUG= 595503 TEST=do repro steps at the bug Review URL: https://codereview.chromium.org/1877213002 Cr-Commit-Position: refs/heads/master@{#386619} [modify] https://crrev.com/072c195f6a8fb12d4970b889dca8f75779b5533e/ui/file_manager/file_manager/foreground/js/file_manager.js
,
Apr 12 2016
,
Apr 13 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7f99ba6a044b92b98981ab02242e0e510da1ff8 commit d7f99ba6a044b92b98981ab02242e0e510da1ff8 Author: Daichi Hirono <hirono@chromium.org> Date: Wed Apr 13 07:39:20 2016 Show GoogleDrive volume in saving dialog that requires naitve path. crrev.com/376073 assumed we cannot create snapshot files for saving and it hides non-native volumes for saving dialog. However we have special hack for Google Drive to create snapshot files for saving. BUG= 595503 TEST=do repro steps at the bug Review URL: https://codereview.chromium.org/1877213002 Cr-Commit-Position: refs/heads/master@{#386619} (cherry picked from commit 072c195f6a8fb12d4970b889dca8f75779b5533e) Review URL: https://codereview.chromium.org/1882393002 . Cr-Commit-Position: refs/branch-heads/2704@{#24} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/d7f99ba6a044b92b98981ab02242e0e510da1ff8/ui/file_manager/file_manager/foreground/js/file_manager.js
,
Apr 13 2016
,
Apr 14 2016
[Automated comment] Less than 2 weeks to go before stable on M50, manual review required.
,
May 12 2016
This is merge approved for 50. Can we do the merge so it will get picked up in a stable update?
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c137a2c568609897b520379cb5c673054116365 commit 7c137a2c568609897b520379cb5c673054116365 Author: Daichi Hirono <hirono@chromium.org> Date: Thu May 12 04:29:46 2016 Show GoogleDrive volume in saving dialog that requires naitve path. crrev.com/376073 assumed we cannot create snapshot files for saving and it hides non-native volumes for saving dialog. However we have special hack for Google Drive to create snapshot files for saving. BUG= 595503 TEST=do repro steps at the bug Review URL: https://codereview.chromium.org/1877213002 Cr-Commit-Position: refs/heads/master@{#386619} (cherry picked from commit 072c195f6a8fb12d4970b889dca8f75779b5533e) Review URL: https://codereview.chromium.org/1972003002 . Cr-Commit-Position: refs/branch-heads/2661@{#684} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/7c137a2c568609897b520379cb5c673054116365/ui/file_manager/file_manager/foreground/js/file_manager.js
,
May 17 2016
Issue 612201 has been merged into this issue.
,
May 17 2016
50.0.2661.103 and this hasn't been fixed?
,
May 17 2016
The fix is in 50.0.2661.104.
,
May 17 2016
Ah my bad.
,
May 17 2016
Verified on ChromeOS (8334.0.0 , 52.0.2734.0) (8172.28.0, 51.0.2704.42) (7978.76.0, 50.0.2661.104)
,
Dec 10
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abod...@chromium.org
, Mar 17 2016