Incognito tab strip background color when active and non-vibrant is incorrect |
|||||||||
Issue descriptionWhen running in Incognito, on a Mac that does not support vibrancy, the color behind the tabs should be closer to the spec ( #141618 with a 0.9 alpha ). The alpha value should be 1 because this area cannot be transparent. chrome/browser/themes/theme_properties.cc:48.
,
Mar 22 2016
,
May 6 2016
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74a440eaf0d6a6e6c1c0e1e59365c080e038b113 commit 74a440eaf0d6a6e6c1c0e1e59365c080e038b113 Author: shrike <shrike@chromium.org> Date: Fri May 20 16:18:17 2016 [Mac][Material Design] Adjust tabstrip Incognito, non-vibrant bg color. R=avi@chromium.org BUG= 595502 Review-Url: https://codereview.chromium.org/1992193003 Cr-Commit-Position: refs/heads/master@{#395089} [modify] https://crrev.com/74a440eaf0d6a6e6c1c0e1e59365c080e038b113/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
,
May 23 2016
,
May 23 2016
Leaving open pending cherry-pick to M52.
,
May 23 2016
,
May 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 24 2016
Please merge your change to M52 branch 2743 before 4:00 PM PST tomorrow, Wednesday (05/25).So we can take it for this week last M52 Dev release on Thursday (05/26).Thank you.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0baae3a7156a7bd2de20fb1e4923bc80c63f19e1 commit 0baae3a7156a7bd2de20fb1e4923bc80c63f19e1 Author: Jayson Adams <shrike@chromium.org> Date: Wed May 25 18:03:27 2016 [Mac][Material Design] Adjust tabstrip Incognito, non-vibrant bg color. R=avi@chromium.org BUG= 595502 Review-Url: https://codereview.chromium.org/1992193003 Cr-Commit-Position: refs/heads/master@{#395089} (cherry picked from commit 74a440eaf0d6a6e6c1c0e1e59365c080e038b113) Review URL: https://codereview.chromium.org/2010813002 . Cr-Commit-Position: refs/branch-heads/2743@{#55} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/0baae3a7156a7bd2de20fb1e4923bc80c63f19e1/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
,
May 25 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by shrike@chromium.org
, Mar 22 2016