Windows will need display layout code for Multi-DPI Display Awareness and ChromeOS has a form of DisplayLayout that supports gfx::Display layout in DIP. It would be good to use the same system.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c912b533f434aa8509495bf0dd6e2dd177d0fce commit 8c912b533f434aa8509495bf0dd6e2dd177d0fce Author: robliao <robliao@chromium.org> Date: Mon Mar 21 21:34:15 2016 Refactor JSONValueConverter Out of DisplayLayout Separate the JSON processing code out of DisplayLayout in preparing to move to ui/gfx since ui/gfx has no JSON dependency. BUG= 595498 Review URL: https://codereview.chromium.org/1808253004 Cr-Commit-Position: refs/heads/master@{#382398} [modify] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/ash.gyp [modify] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/display/display_layout.cc [modify] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/display/display_layout.h [add] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/display/json_converter.cc [add] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/display/json_converter.h [rename] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/ash/display/json_converter_unittest.cc [modify] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/chrome/browser/chromeos/display/display_preferences.cc [modify] https://crrev.com/8c912b533f434aa8509495bf0dd6e2dd177d0fce/chrome/browser/chromeos/display/display_preferences_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df372032b408542d782c18cfc057ed729e46665a commit df372032b408542d782c18cfc057ed729e46665a Author: robliao <robliao@chromium.org> Date: Wed Mar 23 00:42:34 2016 Convert ScopedVector<DisplayPlacement> to std::vector<DisplayPlacement> Now that JSONValueConverter isn't used any more, we can use std::vector. BUG= 595498 Review URL: https://codereview.chromium.org/1819533002 Cr-Commit-Position: refs/heads/master@{#382748} [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_layout.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_layout.h [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_layout_builder.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_layout_builder_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_layout_store.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_manager.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/display_manager_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/extended_mouse_warp_controller.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/extended_mouse_warp_controller_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/json_converter.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/json_converter_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/mouse_cursor_event_filter_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/screen_position_controller_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/ash/extended_desktop_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/df372032b408542d782c18cfc057ed729e46665a/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5 commit c0dfd6b2d5be7951bc1dfa61053f67d2514889f5 Author: robliao <robliao@chromium.org> Date: Thu Apr 07 21:33:56 2016 Move DisplayLayout and DisplayLayoutBuilder From ash To ui/display BUG= 595498 Review URL: https://codereview.chromium.org/1838833002 Cr-Commit-Position: refs/heads/master@{#385875} [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/ash.gyp [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_change_observer_chromeos.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_configuration_controller.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_configuration_controller.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_layout_store.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_layout_store.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_manager.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_manager.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_manager_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_util.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_util.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/display_util_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/extended_mouse_warp_controller.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/extended_mouse_warp_controller.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/extended_mouse_warp_controller_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/json_converter.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/json_converter.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/json_converter_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/mirror_window_controller.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/mouse_cursor_event_filter_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/root_window_transformers_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/screen_position_controller_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/unified_mouse_warp_controller.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/extended_desktop_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/test/display_manager_test_api.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/test/display_manager_test_api.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/touch/touch_transformer_controller.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/dock/docked_window_layout_manager_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/chromeos/display/display_preferences.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/chromeos/display/display_preferences.h [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/chromeos/policy/display_rotation_default_handler_browsertest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/BUILD.gn [modify] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/display.gyp [rename] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/manager/display_layout.cc [rename] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/manager/display_layout.h [rename] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/manager/display_layout_builder.cc [rename] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/manager/display_layout_builder.h [rename] https://crrev.com/c0dfd6b2d5be7951bc1dfa61053f67d2514889f5/ui/display/manager/display_layout_builder_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Mar 21 2016